From patchwork Sat Apr 6 23:17:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ian Eure X-Patchwork-Id: 25844 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id EEBC527BBE9; Sun, 7 Apr 2024 00:18:24 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 00EE527BBE2 for ; Sun, 7 Apr 2024 00:18:23 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtFIR-0007gP-3b; Sat, 06 Apr 2024 19:18:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtFIO-0007gG-LA for guix-patches@gnu.org; Sat, 06 Apr 2024 19:18:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rtFIO-0008NB-CF; Sat, 06 Apr 2024 19:18:00 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rtFIQ-0002qD-9D; Sat, 06 Apr 2024 19:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70249] [PATCH] gnu: open-ssh-session: =?utf-8?b?RG9u4oCZdA==?= require public key. Resent-From: Ian Eure Original-Sender: "Debbugs-submit" Resent-CC: guix@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, rekado@elephly.net, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Sat, 06 Apr 2024 23:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 70249 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70249@debbugs.gnu.org Cc: Ian Eure , Christopher Baines , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Christopher Baines , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by submit@debbugs.gnu.org id=B.171244545110791 (code B ref -1); Sat, 06 Apr 2024 23:18:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Apr 2024 23:17:31 +0000 Received: from localhost ([127.0.0.1]:41254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtFHv-0002nz-3I for submit@debbugs.gnu.org; Sat, 06 Apr 2024 19:17:31 -0400 Received: from lists.gnu.org ([2001:470:142::17]:60246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtFHr-0002ne-D2 for submit@debbugs.gnu.org; Sat, 06 Apr 2024 19:17:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtFHe-0007dZ-Sy for guix-patches@gnu.org; Sat, 06 Apr 2024 19:17:14 -0400 Received: from fhigh7-smtp.messagingengine.com ([103.168.172.158]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtFHc-000889-S1 for guix-patches@gnu.org; Sat, 06 Apr 2024 19:17:14 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 247871140090; Sat, 6 Apr 2024 19:17:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 06 Apr 2024 19:17:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm1; t=1712445431; x=1712531831; bh=H8 xkMWxqj56JOSz0jLl+1hDUmWy0IK0cxa5Xdn791RM=; b=JOzoUXvsIGouG8waif rzZQEIRPEem1+hh09ZdNbaEEv3rw6leFAnGa+zgCn1ZQe4AcrNWsLAAfLKIpXSM4 2fVzoMBk4BYQNTn4iZATWYIJKS4RXiEruhQQyWXiCHMCMt877eSO9oCn+SJuDROF H8KxaDbEGQ4ldEdEpxtBmijmVeXpFFsEnrolnf0aXfQoiwi1InQp1S7jDUN3cLgR nbVYLr1OkJO5FvnW5BMdn6bC6TvphJrZsuadS7v0ZjEBRoVYmyubvWXQlt5//sTL C+FANOGRhJ3QBIZht3ikJ1NzzRiXD5ejTbP/jmjmgfqHL6C+OQu0GK4t3ZSdXnnh nbTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1712445431; x=1712531831; bh=H8xkMWxqj56JO Sz0jLl+1hDUmWy0IK0cxa5Xdn791RM=; b=jAZoD0mKXl+2lPBOAqPHCRUsZBSDo 8edja13HcLAKCMpHw/QoDeZq4Xa+oTVdJJr56qFwKp/fDcDXSdEelOAi7LBcPMNp JDSHNP9B1cuHCRAWI4fJY+saLXSz/7CzvG1prO+RnuAtswClkRfm7rkFC5/P4lfb c6EMNnR9RI3Q8f6g7Aej5P+YUz/ZSDZdlNpjHwpWFNnfjp2fyrufkRDYJoqqHltq YOFFEwKNt5rEbfCz4fCC0LS2MxbqqrvGa63zixfAfztfWUZO+bmgtaNU6qEyYGlv 91bDwAHCkm8fYfs3wlx6AsU3Lnt3y6SwqEW3M8hlK/ST5XrqeV0Qo4AEg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudegfedgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffogggtgfesthekre dtredtjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdr thhvqeenucggtffrrghtthgvrhhnpefgueekffejudfgvdevteelteeitdeuuddufffhue fhiefhjeetuefhgfettedvteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 Apr 2024 19:17:09 -0400 (EDT) From: Ian Eure Date: Sat, 6 Apr 2024 16:17:06 -0700 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Received-SPF: pass client-ip=103.168.172.158; envelope-from=ian@retrospec.tv; helo=fhigh7-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * guix/scripts/offload.scm (open-ssh-session): Delete `public' binding. Public keys aren’t required for client connections, and this binding is unused. The behavior of assuming a ".pub"-suffixed file exists in the same directory as the secret key is undocumented and surprising. Change-Id: I9b532be2abe68dae0323e4ef6e1ceab1e5603359 --- guix/scripts/offload.scm | 3 --- 1 file changed, 3 deletions(-) base-commit: ab3731d255ff1ac8d6874bc0f68ad94f21f08e79 diff --git a/guix/scripts/offload.scm b/guix/scripts/offload.scm index 137e3b5fe3..93e9d3759c 100644 --- a/guix/scripts/offload.scm +++ b/guix/scripts/offload.scm @@ -213,9 +213,6 @@ (define* (open-ssh-session machine #:optional max-silent-time) When MAX-SILENT-TIME is true, it must be a positive integer denoting the number of seconds after which the connection times out." (let ((private (private-key-from-file* (build-machine-private-key machine))) - (public (public-key-from-file - (string-append (build-machine-private-key machine) - ".pub"))) (session (make-session #:user (build-machine-user machine) #:host (build-machine-name machine) #:port (build-machine-port machine)