diff mbox series

[bug#43119] gnu: Add guile-srfi-180.

Message ID b0edab72-2e23-016b-34d8-a1fd121c9042@riseup.net
State Accepted
Headers show
Series [bug#43119] gnu: Add guile-srfi-180. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job

Commit Message

Martin Becze Aug. 30, 2020, 9:14 p.m. UTC 
opps there is a lint fail. attached is a cleaner version.

On 8/30/20 1:11 PM, Martin Becze wrote:
> * gnu/packages/guile-xyz.scm (guile-srfi-180): New variable.
> ---
>   gnu/packages/guile-xyz.scm | 35 +++++++++++++++++++++++++++++++++++
>   1 file changed, 35 insertions(+)
> 
> diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
> index 9f9335c8f7..b6d163a8bd 100644
> --- a/gnu/packages/guile-xyz.scm
> +++ b/gnu/packages/guile-xyz.scm
> @@ -2887,6 +2887,41 @@ formatting combinators specified by
>   more expressive and flexible than the traditional @code{format} procedure.")
>         (license license:bsd-3))))
>   
> +(define-public guile-srfi-180
> +  (let ((commit "9188bf9724c6d320ef804579d222e855b007b193")
> +        (revision "0"))
> +    (package
> +      (name "guile-srfi-180")
> +      (version (git-version "0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (commit commit)
> +               (url "https://github.com/scheme-requests-for-implementation/srfi-180.git")))
> +         (sha256
> +          (base32
> +           "08lf70rsak8mwfij55xc37pg9zg7c87fizmhz7ln46skzj68sl3y"))
> +         (modules '((guix build utils)))
> +         (snippet
> +          '(begin
> +             (delete-file-recursively "srfi/files")
> +             (delete-file "srfi/run-r7rs-checks.guile.scm")
> +             (delete-file "srfi/run-r7rs-checks.scm")
> +             #t))
> +         (file-name (git-file-name name version))))
> +      (build-system guile-build-system)
> +      (native-inputs
> +       `(("guile" ,guile-3.0)))
> +      (propagated-inputs
> +       `(("guile-srfi-145" ,guile-srfi-145)))
> +      (home-page "https://srfi.schemers.org/srfi-180/")
> +      (synopsis "JSON parser and printer for Guile")
> +      (description
> +       "This library describes a JavaScript Object Notation (JSON) parser and printer.
> +It supports JSON that may be bigger than memory.")
> +      (license license:expat))))
> +
>   (define-public emacsy
>     (package
>       (name "emacsy")
>

Comments

Mathieu Othacehe Aug. 31, 2020, 8:14 a.m. UTC | #1 
Hey,

>> * gnu/packages/guile-xyz.scm (guile-srfi-180): New variable.

I'm getting a whole bunch of warnings when building srfi/180/body.scm,
such as:

--8<---------------cut here---------------start------------->8---
srfi/180/body.scm:237:11: warning: possibly unbound variable `textual-port?'
srfi/180/body.scm:198:4: warning: possibly unbound variable `eof-object'
srfi/180/body.scm:195:2: warning: possibly unbound variable `assume'
srfi/180/body.scm:191:23: warning: possibly unbound variable `make-json-error'
srfi/180/body.scm:190:29: warning: possibly unbound variable `make-json-error'
srfi/180/body.scm:186:16: warning: possibly unbound variable `valid-number?'
srfi/180/body.scm:167:29: warning: possibly unbound variable `make-json-error'
srfi/180/body.scm:146:59: warning: possibly unbound variable `bitwise-ior'
srfi/180/body.scm:111:15: warning: possibly unbound variable `make-json-error'
srfi/180/body.scm:106:15: warning: possibly unbound variable `make-json-error'
--8<---------------cut here---------------end--------------->8---

Do you think they could be fixed?

>> +       "This library describes a JavaScript Object Notation (JSON) parser and printer.
>> +It supports JSON that may be bigger than memory.")

Even though this description is a copy of the SRFI abstract, it seems a
bit vague. I would change "describes" to "implements" or "provides". The
affirmation "JSON bigger than memory" could also be expanded I think.

Thanks,

Mathieu
diff mbox series

Patch

From 4f41ab55cbd7509bef7b542ac745e33e296b429d Mon Sep 17 00:00:00 2001
From: Martin Becze <mjbecze@riseup.net>
Date: Sun, 30 Aug 2020 13:06:14 -0500
Subject: [PATCH v2] gnu: Add guile-srfi-180.

* gnu/packages/guile-xyz.scm (guile-srfi-180): New variable.
---
 gnu/packages/guile-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 9f9335c8f7..944df0eae4 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -2887,6 +2887,42 @@  formatting combinators specified by
 more expressive and flexible than the traditional @code{format} procedure.")
       (license license:bsd-3))))
 
+(define-public guile-srfi-180
+  (let ((commit "9188bf9724c6d320ef804579d222e855b007b193")
+        (revision "0")
+        (url "https://github.com/scheme-requests-for-implementation/srfi-180.git"))
+    (package
+      (name "guile-srfi-180")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (commit commit)
+               (url url)))
+         (sha256
+          (base32
+           "08lf70rsak8mwfij55xc37pg9zg7c87fizmhz7ln46skzj68sl3y"))
+         (modules '((guix build utils)))
+         (snippet
+          '(begin
+             (delete-file-recursively "srfi/files")
+             (delete-file "srfi/run-r7rs-checks.guile.scm")
+             (delete-file "srfi/run-r7rs-checks.scm")
+             #t))
+         (file-name (git-file-name name version))))
+      (build-system guile-build-system)
+      (native-inputs
+       `(("guile" ,guile-3.0)))
+      (propagated-inputs
+       `(("guile-srfi-145" ,guile-srfi-145)))
+      (home-page "https://srfi.schemers.org/srfi-180/")
+      (synopsis "JSON parser and printer for Guile")
+      (description
+       "This library describes a JavaScript Object Notation (JSON) parser and printer.
+It supports JSON that may be bigger than memory.")
+      (license license:expat))))
+
 (define-public emacsy
   (package
     (name "emacsy")
-- 
2.28.0