| Message ID | b08b2b94e1cba4bbb9cb2975b5055ebac4c9a402.1626004085.git.efraim@flashner.co.il |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#49521] gnu: java-xz: Update to 1.9. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/applying patch | fail | View Laminar job |
| cbaines/issue | success | View issue |
Le 11 juillet 2021 07:48:22 GMT-04:00, Efraim Flashner <efraim@flashner.co.il> a écrit : >* gnu/packages/java-compression.scm (java-xz): Update to 1.9. >[arguments]: Build with openjdk9. >--- > gnu/packages/java-compression.scm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/gnu/packages/java-compression.scm >b/gnu/packages/java-compression.scm >index 19b11954c1..033b55c988 100644 >--- a/gnu/packages/java-compression.scm >+++ b/gnu/packages/java-compression.scm >@@ -4,6 +4,7 @@ > ;;; Copyright © 2018 Marius Bakke <mbakke@fastmail.com> > ;;; Copyright © 2018 Mark H Weaver <mhw@netris.org> > ;;; Copyright © 2018, 2020 Tobias Geerinckx-Rice <me@tobias.gr> >+;;; Copyright © 2021 Efraim Flashner <efraim@flashner.co.il> > ;;; > ;;; This file is part of GNU Guix. > ;;; >@@ -289,16 +290,17 @@ It can be used as a replacement for the Apache >@code{CBZip2InputStream} / > (define-public java-xz > (package > (name "java-xz") >- (version "1.6") >+ (version "1.9") > (source (origin > (method url-fetch/zipbomb) > (uri (string-append "https://tukaani.org/xz/xz-java-" version ".zip")) > (sha256 > (base32 >- >"1z3p1ri1gvl07inxn0agx44ck8n7wrzfmvkz8nbq3njn8r9wba8x")))) >+ >"007d9f83277qn70swz9inqhyf0qxq6ygajpq5rqg0xgsyh1sdndi")))) > (build-system ant-build-system) > (arguments > `(#:tests? #f; no tests >+ #:jdk ,openjdk9 > #:phases > (modify-phases %standard-phases > (add-before 'install 'generate-pom > >base-commit: 7760d28920a920791645c4485f1345af45ee7787 Looks good, but building dependents will likely cause issues if they still use openjdk8. At the very least, we'll see a warning.
On Sun, Jul 11, 2021 at 12:08:35PM -0400, Julien Lepiller wrote: > Le 11 juillet 2021 07:48:22 GMT-04:00, Efraim Flashner <efraim@flashner.co.il> a écrit : > >* gnu/packages/java-compression.scm (java-xz): Update to 1.9. > >[arguments]: Build with openjdk9. > >--- > > gnu/packages/java-compression.scm | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > >diff --git a/gnu/packages/java-compression.scm > >b/gnu/packages/java-compression.scm > >index 19b11954c1..033b55c988 100644 > >--- a/gnu/packages/java-compression.scm > >+++ b/gnu/packages/java-compression.scm > >@@ -4,6 +4,7 @@ > > ;;; Copyright © 2018 Marius Bakke <mbakke@fastmail.com> > > ;;; Copyright © 2018 Mark H Weaver <mhw@netris.org> > > ;;; Copyright © 2018, 2020 Tobias Geerinckx-Rice <me@tobias.gr> > >+;;; Copyright © 2021 Efraim Flashner <efraim@flashner.co.il> > > ;;; > > ;;; This file is part of GNU Guix. > > ;;; > >@@ -289,16 +290,17 @@ It can be used as a replacement for the Apache > >@code{CBZip2InputStream} / > > (define-public java-xz > > (package > > (name "java-xz") > >- (version "1.6") > >+ (version "1.9") > > (source (origin > > (method url-fetch/zipbomb) > > (uri (string-append "https://tukaani.org/xz/xz-java-" version ".zip")) > > (sha256 > > (base32 > >- > >"1z3p1ri1gvl07inxn0agx44ck8n7wrzfmvkz8nbq3njn8r9wba8x")))) > >+ > >"007d9f83277qn70swz9inqhyf0qxq6ygajpq5rqg0xgsyh1sdndi")))) > > (build-system ant-build-system) > > (arguments > > `(#:tests? #f; no tests > >+ #:jdk ,openjdk9 > > #:phases > > (modify-phases %standard-phases > > (add-before 'install 'generate-pom > > > >base-commit: 7760d28920a920791645c4485f1345af45ee7787 > > Looks good, but building dependents will likely cause issues if they still use openjdk8. At the very least, we'll see a warning. Is that a problem? Starting with 1.9 they added some code that needs java 9 to compile. I test built the 4 packages which directly depend on java-xz and they built without problems. ¹https://git.tukaani.org/?p=xz-java.git;a=blob;f=NEWS;h=d18a53b23efdae4b7d2911ef7898189462fac689;hb=HEAD
Le 12 juillet 2021 08:38:14 GMT-04:00, Efraim Flashner <efraim@flashner.co.il> a écrit : >On Sun, Jul 11, 2021 at 12:08:35PM -0400, Julien Lepiller wrote: >> Le 11 juillet 2021 07:48:22 GMT-04:00, Efraim Flashner ><efraim@flashner.co.il> a écrit : >> >* gnu/packages/java-compression.scm (java-xz): Update to 1.9. >> >[arguments]: Build with openjdk9. >> >--- >> > gnu/packages/java-compression.scm | 6 ++++-- >> > 1 file changed, 4 insertions(+), 2 deletions(-) >> > >> >diff --git a/gnu/packages/java-compression.scm >> >b/gnu/packages/java-compression.scm >> >index 19b11954c1..033b55c988 100644 >> >--- a/gnu/packages/java-compression.scm >> >+++ b/gnu/packages/java-compression.scm >> >@@ -4,6 +4,7 @@ >> > ;;; Copyright © 2018 Marius Bakke <mbakke@fastmail.com> >> > ;;; Copyright © 2018 Mark H Weaver <mhw@netris.org> >> > ;;; Copyright © 2018, 2020 Tobias Geerinckx-Rice <me@tobias.gr> >> >+;;; Copyright © 2021 Efraim Flashner <efraim@flashner.co.il> >> > ;;; >> > ;;; This file is part of GNU Guix. >> > ;;; >> >@@ -289,16 +290,17 @@ It can be used as a replacement for the Apache >> >@code{CBZip2InputStream} / >> > (define-public java-xz >> > (package >> > (name "java-xz") >> >- (version "1.6") >> >+ (version "1.9") >> > (source (origin >> > (method url-fetch/zipbomb) >> > (uri (string-append "https://tukaani.org/xz/xz-java-" version >".zip")) >> > (sha256 >> > (base32 >> >- >> >"1z3p1ri1gvl07inxn0agx44ck8n7wrzfmvkz8nbq3njn8r9wba8x")))) >> >+ >> >"007d9f83277qn70swz9inqhyf0qxq6ygajpq5rqg0xgsyh1sdndi")))) >> > (build-system ant-build-system) >> > (arguments >> > `(#:tests? #f; no tests >> >+ #:jdk ,openjdk9 >> > #:phases >> > (modify-phases %standard-phases >> > (add-before 'install 'generate-pom >> > >> >base-commit: 7760d28920a920791645c4485f1345af45ee7787 >> >> Looks good, but building dependents will likely cause issues if they >still use openjdk8. At the very least, we'll see a warning. > >Is that a problem? Starting with 1.9 they added some code that needs >java 9 to compile. I test built the 4 packages which directly depend on >java-xz and they built without problems. > >¹https://git.tukaani.org/?p=xz-java.git;a=blob;f=NEWS;h=d18a53b23efdae4b7d2911ef7898189462fac689;hb=HEAD If dependents build fine, it should work.
On Mon, Jul 12, 2021 at 08:42:32AM -0400, Julien Lepiller wrote:
> If dependents build fine, it should work.
Thanks. Patch pushed.
diff --git a/gnu/packages/java-compression.scm b/gnu/packages/java-compression.scm index 19b11954c1..033b55c988 100644 --- a/gnu/packages/java-compression.scm +++ b/gnu/packages/java-compression.scm @@ -4,6 +4,7 @@ ;;; Copyright © 2018 Marius Bakke <mbakke@fastmail.com> ;;; Copyright © 2018 Mark H Weaver <mhw@netris.org> ;;; Copyright © 2018, 2020 Tobias Geerinckx-Rice <me@tobias.gr> +;;; Copyright © 2021 Efraim Flashner <efraim@flashner.co.il> ;;; ;;; This file is part of GNU Guix. ;;; @@ -289,16 +290,17 @@ It can be used as a replacement for the Apache @code{CBZip2InputStream} / (define-public java-xz (package (name "java-xz") - (version "1.6") + (version "1.9") (source (origin (method url-fetch/zipbomb) (uri (string-append "https://tukaani.org/xz/xz-java-" version ".zip")) (sha256 (base32 - "1z3p1ri1gvl07inxn0agx44ck8n7wrzfmvkz8nbq3njn8r9wba8x")))) + "007d9f83277qn70swz9inqhyf0qxq6ygajpq5rqg0xgsyh1sdndi")))) (build-system ant-build-system) (arguments `(#:tests? #f; no tests + #:jdk ,openjdk9 #:phases (modify-phases %standard-phases (add-before 'install 'generate-pom