From patchwork Wed Apr 5 15:34:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruno Victal X-Patchwork-Id: 11984 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 6F0D617366; Wed, 5 Apr 2023 16:35:28 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id EC31B1735B for ; Wed, 5 Apr 2023 16:35:26 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pk5A9-00049n-1L; Wed, 05 Apr 2023 11:35:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pk5A7-00049e-Az for guix-patches@gnu.org; Wed, 05 Apr 2023 11:35:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pk5A7-0007m3-2I for guix-patches@gnu.org; Wed, 05 Apr 2023 11:35:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pk5A6-0007JL-Cv for guix-patches@gnu.org; Wed, 05 Apr 2023 11:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62678] [PATCH] services: nginx: Harden php-location settings. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 Apr 2023 15:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62678 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62678@debbugs.gnu.org Cc: Bruno Victal X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168070889428084 (code B ref -1); Wed, 05 Apr 2023 15:35:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Apr 2023 15:34:54 +0000 Received: from localhost ([127.0.0.1]:52459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk59j-0007Ia-IW for submit@debbugs.gnu.org; Wed, 05 Apr 2023 11:34:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:49246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk59h-0007IT-On for submit@debbugs.gnu.org; Wed, 05 Apr 2023 11:34:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pk59h-00043G-7M for guix-patches@gnu.org; Wed, 05 Apr 2023 11:34:37 -0400 Received: from smtpmciv1.myservices.hosting ([185.26.107.237]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pk59f-0007ft-5U for guix-patches@gnu.org; Wed, 05 Apr 2023 11:34:36 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpmciv1.myservices.hosting (Postfix) with ESMTP id E7E4F2098E for ; Wed, 5 Apr 2023 17:34:25 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 9431E800AA; Wed, 5 Apr 2023 17:34:25 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7AgZigszt7Uo; Wed, 5 Apr 2023 17:34:25 +0200 (CEST) Received: from guix-nuc.home.arpa (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id EA9A2800A9; Wed, 5 Apr 2023 17:34:24 +0200 (CEST) From: Bruno Victal Date: Wed, 5 Apr 2023 16:34:08 +0100 Message-Id: X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Received-SPF: pass client-ip=185.26.107.237; envelope-from=mirai@makinata.eu; helo=smtpmciv1.myservices.hosting X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Incorporate advice from [2], which mitigates httpoxy[1] vulnerability and disallows passing non-php files to the PHP backend. [1]: [2]: , note 4. * gnu/services/web.scm (nginx-php-location): Only pass existing php files to backend. Mitigate httpoxy vulnerability. --- Tested with: make check-system TESTS="nginx php-fpm" gnu/services/web.scm | 4 ++++ 1 file changed, 4 insertions(+) base-commit: 6311493d7a6271bfbc51f4693857f9a12fe9965d diff --git a/gnu/services/web.scm b/gnu/services/web.scm index d56e893527..f5ed027bb4 100644 --- a/gnu/services/web.scm +++ b/gnu/services/web.scm @@ -1123,6 +1123,10 @@ (define* (nginx-php-location (uri "~ \\.php$") (body (list "fastcgi_split_path_info ^(.+\\.php)(/.+)$;" + ;; Mitigate https://httpoxy.org/ vulnerabilities + "fastcgi_param HTTP_PROXY \"\";" + ;; Only pass existing php files to the backend. + "if (!-f $document_root$fastcgi_script_name) { return 404; }" (string-append "fastcgi_pass unix:" socket ";") "fastcgi_index index.php;" (list "include " nginx-package "/share/nginx/conf/fastcgi.conf;")))))