From patchwork Wed Jul 8 19:43:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandros Theodotou X-Patchwork-Id: 23122 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 7BAFC27BBE3; Wed, 8 Jul 2020 20:44:10 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id BDC8E27BBE1 for ; Wed, 8 Jul 2020 20:44:09 +0100 (BST) Received: from localhost ([::1]:50902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtFzF-00089M-8r for patchwork@mira.cbaines.net; Wed, 08 Jul 2020 15:44:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtFzA-00089A-G9 for guix-patches@gnu.org; Wed, 08 Jul 2020 15:44:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55819) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jtFz7-0004qQ-Lv for guix-patches@gnu.org; Wed, 08 Jul 2020 15:44:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jtFz7-0000RY-K0 for guix-patches@gnu.org; Wed, 08 Jul 2020 15:44:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41552] [PATCH] gnu: Add remid-lv2. Resent-From: Alexandros Theodotou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 08 Jul 2020 19:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41552 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , 41552@debbugs.gnu.org Received: via spool by 41552-submit@debbugs.gnu.org id=B41552.15942374121653 (code B ref 41552); Wed, 08 Jul 2020 19:44:01 +0000 Received: (at 41552) by debbugs.gnu.org; 8 Jul 2020 19:43:32 +0000 Received: from localhost ([127.0.0.1]:39132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jtFye-0000Qb-DY for submit@debbugs.gnu.org; Wed, 08 Jul 2020 15:43:32 -0400 Received: from mout01.posteo.de ([185.67.36.141]:36868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jtFyd-0000QM-1n for 41552@debbugs.gnu.org; Wed, 08 Jul 2020 15:43:31 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id BE1F1160062 for <41552@debbugs.gnu.org>; Wed, 8 Jul 2020 21:43:24 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4B28qX5wTKz6tmM; Wed, 8 Jul 2020 21:43:19 +0200 (CEST) Message-ID: From: Alexandros Theodotou Date: Wed, 08 Jul 2020 20:43:15 +0100 In-Reply-To: <87lfl93beq.fsf@gnu.org> References: <94c136949f58964383c2fabe6a28aa80bc3c79ea.camel@zrythm.org> <87lfl93beq.fsf@gnu.org> User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi, Thanks for the feedback. I fixed the patch although I'm not sure what to do with the description/summary - I don't know what those are either, I just know that it's a cool audio plugin. Feel free to edit it. Thanks, Alex On Sat, 2020-05-30 at 13:33 +0200, Marius Bakke wrote: > Alexandros Theodotou writes: > > > Hi, > > > > This patch adds the reMID LV2 plugin. > > Thanks! > > [...] > > > +(define-public remid-lv2 > > + (package > > + (name "remid-lv2") > > + (version "0.3") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append "https://github.com/ssj71/" > > + "reMID.lv2/archive/v" > > + version ".tar.gz")) > > The GitHub /archive/ URLs are not stable: they might fall out of > GitHubs > cache and be regenerated, with different time stamps. So we should > use > git-fetch here instead. > > This is different from "/releases/", which are > uploaded. Unfortunately > GitHubs UI makes it difficult to tell the difference short of looking > at > the URL. > > > + (file-name (string-append name "-" version ".tar.gz")) > > + (sha256 > > + (base32 > > + "1kffpv90a967wwpsa0jb1jp5qnhf85m4ap8nfw8wih71rcrgg4h3" > > )))) > > + (build-system cmake-build-system) > > + (arguments > > + `(#:tests? #f)) ; no tests included > > + (inputs > > + `(("glib" ,glib) > > + ("alsa-lib" ,alsa-lib) > > + ("jack" ,jack-1) > > + ("lv2" ,lv2))) > > Nit: we usually sort inputs. Helpful when there are dozens. > > > + (native-inputs > > + `(("pkg-config" ,pkg-config))) > > + (home-page "https://github.com/ssj71/reMID.lv2") > > + (synopsis > > + "MIDI-controlled implementation of the SID 6581 chip used in > > the > > +Commodore 64") > > + (description > > + "The 6581 SID chip is the sound chip used in the Commodore > > 64 computer. > > +reMID is a MIDI implementation of the 6581 SID chip using the > > reSID library > > +to provide a virtual SID-based synthesizer, controllable in real- > > time via > > +MIDI. It includes support for scripted instruments that allow > > complex sonic > > +control of the chip.") > > Why yes, I know some of these words :-) would it make sense to define > "SID" here with @acronym? > > > + (license license:gpl2))) > > This is actually GPL2+, because none of the source files say "version > 2 > only" (and some actually say explicitly GPL2-or-later). > > Can you send an updated patch? From 7cc536dfeeea735afb8e15f83c5eef8aac020c4f Mon Sep 17 00:00:00 2001 From: Alexandros Theodotou Date: Wed, 8 Jul 2020 20:39:38 +0100 Subject: [PATCH] gnu: Add remid-lv2. * gnu/packages/music.scm (remid-lv2): New variable. --- gnu/packages/music.scm | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index d0f5bee3a0..6042015dda 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -5419,6 +5419,42 @@ automation that comes as an LV2 plugin bundle with a custom UI.") (home-page "https://git.zrythm.org/cgit/ZLFO/") (license license:agpl3+))) +(define-public remid-lv2 + (package + (name "remid-lv2") + (version "0.3") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/ssj71/reMID.lv2.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "062kriniidsrhzwrf89kfxm9wb0cmgrl07asnlmgil8vcl7gl9y5")))) + (build-system cmake-build-system) + (arguments + `(#:tests? #f)) ; no tests included + (inputs + `(("alsa-lib" ,alsa-lib) + ("glib" ,glib) + ("jack" ,jack-1) + ("lv2" ,lv2))) + (native-inputs + `(("pkg-config" ,pkg-config))) + (home-page "https://github.com/ssj71/reMID.lv2") + (synopsis + "MIDI-controlled implementation of the SID 6581 chip used in the +Commodore 64") + (description + "The 6581 SID chip is the sound chip used in the Commodore 64 computer. +reMID is a MIDI implementation of the 6581 SID chip using the reSID library +to provide a virtual SID-based synthesizer, controllable in real-time via +MIDI. It includes support for scripted instruments that allow complex sonic +control of the chip.") + (license license:gpl2+))) + (define-public vl1-emulator (package (name "vl1-emulator") -- 2.27.0