From patchwork Sat Jun 29 21:37:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: aurtzy X-Patchwork-Id: 65762 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 9A49327BBEA; Sat, 29 Jun 2024 22:46:09 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 970B027BBE2 for ; Sat, 29 Jun 2024 22:46:08 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNftX-0002Nm-Lz; Sat, 29 Jun 2024 17:46:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNftW-0002NP-3g for guix-patches@gnu.org; Sat, 29 Jun 2024 17:46:06 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNftS-00042F-JF for guix-patches@gnu.org; Sat, 29 Jun 2024 17:46:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sNftS-0001wa-1l; Sat, 29 Jun 2024 17:46:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65031] [PATCH v3] gnu: Add syncplay. References: <20230803061517.27336-1-aurtzy@gmail.com> In-Reply-To: <20230803061517.27336-1-aurtzy@gmail.com> Resent-From: aurtzy Original-Sender: "Debbugs-submit" Resent-CC: aurtzy@gmail.com, maxim.cournoyer@gmail.com, guix-patches@gnu.org Resent-Date: Sat, 29 Jun 2024 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65031 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: moreinfo patch To: 65031@debbugs.gnu.org Cc: aurtzy , aurtzy , Maxim Cournoyer X-Debbugs-Original-Xcc: aurtzy , Maxim Cournoyer Received: via spool by 65031-submit@debbugs.gnu.org id=B65031.17196975237410 (code B ref 65031); Sat, 29 Jun 2024 21:46:02 +0000 Received: (at 65031) by debbugs.gnu.org; 29 Jun 2024 21:45:23 +0000 Received: from localhost ([127.0.0.1]:53878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNfso-0001vO-DZ for submit@debbugs.gnu.org; Sat, 29 Jun 2024 17:45:22 -0400 Received: from mail-ot1-f49.google.com ([209.85.210.49]:49484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNfsm-0001v2-8d for 65031@debbugs.gnu.org; Sat, 29 Jun 2024 17:45:21 -0400 Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-701ef9594a2so973936a34.3 for <65031@debbugs.gnu.org>; Sat, 29 Jun 2024 14:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719697455; x=1720302255; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pNAwDxZLL6PhSEjfNcC/111X8TCylH5qIZp53nzSvVI=; b=diBd5l7nnNQ1wZjIBheFkygpkS7p5NsqyqVpL20avG/AVw5OhWVYvse2xdnKVJylqN dLTwqgX9/ryXAmrMROhb3yL+ErHkQqHPSTJzR6GlntfV4614RS/x0iZhZsAIX91hTEnz GSzCPrW6BiEaeQuaUx9yDjfpAD6G33odg3xCsLJDzAegqf+8gfaTQTE6iIoZs4Y+gAA5 9mTygRLGNX3YM7MZiFQ9Pmp408E5PI0xC6OKVnN2azOObLOtB553bwf8W/paCV8LbUi/ 0VWXBrabGuqwlkM+lxDvzU9nPzYlC6Wf9QwC/sEm8FHFEx2ZQLFjEQxQpFk8D0I53i0c azFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719697455; x=1720302255; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pNAwDxZLL6PhSEjfNcC/111X8TCylH5qIZp53nzSvVI=; b=lLGBopIot3mm4127KSV6aMOy5mlAqfy3TgOyamdFjbuhyR8swMK7ZlEpWpTHD16gvH Q4CVy9QdZPnl8hYT5ppHBztvkbQT9pqg+Fm9OzFyLzwcGrf1TRfLrbLm9vllaku+1qQD 6NdxW5rI06qALVcVjgJp7CZUwsTngNxdblPW2C5yZa/JtpG5QRDW+0HDeBCwS0/79vHA bRc7I126DrGuO1F+l0TYZuhFZQTFbZkDFBLQ1cGeq+QqLaoZKG11OR+eTDQRz63h+DaW VQduORR7dmeY8LOg9exRBVtW+MXhawgEaad9zHQ6D3OEvxhmW2Fugl5NtJzpnZyGWa3f klQg== X-Gm-Message-State: AOJu0Yw3BVQD0c7NACDTvzW+kV4PbVzCZe7HGAHW6gH8xngsdSh6Pshx 2MX9aJ4edwZdN6SX90mG5oqxaKJE1eQi4y6erSopBE1W5/cquQb1lgJANw== X-Google-Smtp-Source: AGHT+IE55Pk+Clrz4QRUTUT04GZMZmR8lsTkCsIsUpxNW7b3jeQI1QXFHeC61UJ1qcN2Hm4gYFDP9A== X-Received: by 2002:a05:6808:144d:b0:3d6:2cc2:6b3c with SMTP id 5614622812f47-3d6b472718emr2744742b6e.46.1719697454408; Sat, 29 Jun 2024 14:44:14 -0700 (PDT) Received: from localhost.localdomain ([2600:4808:a053:7600::6242]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79d692797besm195031185a.29.2024.06.29.14.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Jun 2024 14:44:14 -0700 (PDT) From: aurtzy Date: Sat, 29 Jun 2024 17:37:55 -0400 Message-ID: X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/video.scm (syncplay): New variable. Change-Id: I72cdfa3db2b4b7ef6c3ef0b8585d138c272046a7 --- Hi Maxim, Just got around to looking at this package again with a new patch as things have changed since my last reply (and I didn't cc you before, oops..). In addition to addressing your initial review, notable changes from v2 include: - Update to current latest version of Syncplay (1.7.3). - Patch is no longer needed. - This patch puts syncplay in (gnu packages video) instead of the previous (gnu packages networking) since the latter seemed more concerned with system-level networking. Does this make sense? > > Is it compatible with Qt 6? To try it, replace qtwayland-5 with > > qtwayland, and specify a #:qtbase qtbase argument. > > Looks like it is! #:qtbase doesn't seem to be supported by gnu-build-system or > python-build-system (switched to the latter for this v2; elaborated further > below) and I had to make a few other adjustments to get it working, so I may > need advice if I've missed anything here. > > A patch has been added to fix a Qt 6 issue causing Syncplay to crash. > > > These should be inputs, not propagated-inputs, unless it can be used as > > a library? Also, please sort the inputs alphabetically. > > Fixed; not a library. It appears I was using an inappropriate build system for > this package - I originally made them propagated because gnu-build-system wasn't > doing whatever wrapping python-build-system does to make the inputs available, > so this v2 uses python-build-system instead now. > > Best, > > aurtzy Cheers, aurtzy gnu/packages/video.scm | 54 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) base-commit: 78b881722f08325c76096557313a0faee847c66f diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 411ad4c2bf..57a05f3eff 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -68,6 +68,7 @@ ;;; Copyright © 2023 Saku Laesvuori ;;; Copyright © 2023 Jaeme Sifat ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com> +;;; Copyright © 2024 aurtzy ;;; ;;; This file is part of GNU Guix. ;;; @@ -6349,3 +6350,56 @@ (define-public svtplay-dl broadcasters including SVT Play, Sveriges Radio, TV4 Play, along with many others.") (license license:expat))) + +(define-public syncplay + (package + (name "syncplay") + (version "1.7.3") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/Syncplay/syncplay") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "08bgndszja4n2kql2qmzl6qrzawxvcwmywsc69lq0dzjnpdk96la")))) + (build-system python-build-system) + (arguments + (list + #:imported-modules `(,@%python-build-system-modules + (guix build qt-utils) + (guix build utils)) + #:modules '((guix build python-build-system) + (guix build qt-utils) + (guix build utils)) + #:phases #~(modify-phases %standard-phases + (delete 'check) + (replace 'install + (lambda _ + (invoke "make" "install" "DESTDIR=" + (string-append "PREFIX=" + #$output)))) + (add-after 'install 'wrap-qt + (lambda* (#:key inputs #:allow-other-keys) + (wrap-qt-program "syncplay" + #:output #$output + #:inputs inputs + #:qt-major-version "6")))))) + (native-inputs (list python-pyside-6)) + (inputs (list bash-minimal + python-certifi + python-idna + python-service-identity + python-twisted + qtwayland)) + (home-page "https://syncplay.pl") + (synopsis "Client/server to synchronize media playback on many computers") + (description + "Syncplay is a solution to synchronize video playback across multiple +instances of media players over the Internet. When one person pauses/unpauses +playback or skips to a position in the video, this is replicated across all +media players connected to the same server and in the same \"room\" (viewing +session). A built-in text chat for discussing the synced media is also +included for convenience.") + (license license:asl2.0)))