diff mbox series

[bug#65413] services: mcron: Add module for %user-log-dir.

Message ID a6fdad6d07523a320eb682aa0b025573c4d66ed8.1692591833.git.hako@ultrarare.space
State New
Headers show
Series [bug#65413] services: mcron: Add module for %user-log-dir. | expand

Commit Message

Hilton Chain Aug. 21, 2023, 4:33 a.m. UTC 
* gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
(shepherd support) for home service.
---

This patch fixes the following error:
  Loading /gnu/store/...-shepherd.conf.
  herd: error: exception caught while executing 'load' on service 'root':
  Unbound variable: %user-log-dir

I wasn't fully sure to report the issue in #65119 since the error didn't occur
in a home container, sorry for my hesitation.

 gnu/services/mcron.scm | 3 +++
 1 file changed, 3 insertions(+)


base-commit: 7cad70566322262f6acdbbb965e867e34010eb55

Comments

Hilton Chain Aug. 22, 2023, 12:47 p.m. UTC | #1 
On Mon, 21 Aug 2023 12:33:22 +0800,
Hilton Chain wrote:
>
> * gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
> (shepherd support) for home service.
> ---

Pushed as 552d0703776c532f25498d5cb852c3c497cb9252.
Hilton Chain Aug. 22, 2023, 3:21 p.m. UTC | #2 
On Tue, 22 Aug 2023 20:47:51 +0800,
Hilton Chain wrote:
> 
> On Mon, 21 Aug 2023 12:33:22 +0800,
> Hilton Chain wrote:
> >
> > * gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
> > (shepherd support) for home service.
> > ---
> 
> Pushed as 552d0703776c532f25498d5cb852c3c497cb9252.

Fixup pushed as 0c4fb8f43f8aba2dcabe1bc97a8f6d8d41057704...

--8<---------------cut here---------------start------------->8---
1 file changed, 1 insertion(+), 3 deletions(-)
gnu/services/mcron.scm | 4 +---

modified   gnu/services/mcron.scm
@@ -165,9 +165,7 @@ (define (mcron-shepherd-services config)
                             (ice-9 popen) ;for the 'schedule' action
                             (ice-9 rdelim)
                             (ice-9 match)
-                            ,(if home-service?
-                                 '((shepherd support) #:select (%user-log-dir))
-                                 '())
+                            ((shepherd support) #:select (%user-log-dir))
                             ,@%default-modules))
                  (start #~(make-forkexec-constructor
                            (list #$(file-append mcron "/bin/mcron")
--8<---------------cut here---------------end--------------->8---
Ludovic Courtès Aug. 22, 2023, 4:11 p.m. UTC | #3 
Hilton Chain <hako@ultrarare.space> skribis:

> * gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
> (shepherd support) for home service.
> ---
>
> This patch fixes the following error:
>   Loading /gnu/store/...-shepherd.conf.
>   herd: error: exception caught while executing 'load' on service 'root':
>   Unbound variable: %user-log-dir
>
> I wasn't fully sure to report the issue in #65119 since the error didn't occur
> in a home container, sorry for my hesitation.

I tested the changes in ‘guix home container’ and didn’t notice the
error; I wonder what’s going on, would be worth investigating.

Anyway, thanks for the quick fix!

Ludo’.
diff mbox series

Patch

diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm
index db8b539ff5..efb7465549 100644
--- a/gnu/services/mcron.scm
+++ b/gnu/services/mcron.scm
@@ -165,6 +165,9 @@  (define (mcron-shepherd-services config)
                             (ice-9 popen) ;for the 'schedule' action
                             (ice-9 rdelim)
                             (ice-9 match)
+                            ,(if home-service?
+                                 '(shepherd support) ;for '%user-log-dir'
+                                 '())
                             ,@%default-modules))
                  (start #~(make-forkexec-constructor
                            (list #$(file-append mcron "/bin/mcron")