diff mbox series

[bug#73260,3/3] gnu: Add libguestfs.

Message ID a69ed0f5ec65cc75a8a4364c8091cfaf49296d4d.1726348858.git.goodoldpaul@autistici.org
State New
Headers
Series [bug#73260,1/3] gnu: Add hivex. |

Commit Message

paul Sept. 14, 2024, 9:20 p.m. UTC 
* gnu/packages/virtualization.scm (libguestfs): New variable.

Change-Id: I99243550a7a6c9d787fa1a67e54acefd3deeaf1f
---
 gnu/packages/virtualization.scm | 39 +++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

Comments

Ludovic Courtès Sept. 30, 2024, 5:08 p.m. UTC | #1 
Giacomo Leidi <goodoldpaul@autistici.org> skribis:

> * gnu/packages/virtualization.scm (libguestfs): New variable.
>
> Change-Id: I99243550a7a6c9d787fa1a67e54acefd3deeaf1f

[...]

> +(define-public libguestfs
> +  (package
> +    (inherit libguestfs-minimal)

Rather:

  (package/inherit libguestfs-minimal
    …)

so that the ‘replacement’ field is inherited too, should it ever be used
in the future.

Could you send updated patches?

Thanks for the great work!

Ludo’.
paul Oct. 4, 2024, 10:31 p.m. UTC | #2 
Hi Ludo’ ,

I should have addressed your comments, I'm sending a v2 patchset.

Thank you for your help,
diff mbox series

Patch

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 8abc64527b..ce541ec8a0 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -59,6 +59,7 @@  (define-module (gnu packages virtualization)
   #:use-module (gnu packages admin)
   #:use-module (gnu packages assembly)
   #:use-module (gnu packages attr)
+  #:use-module (gnu packages apparmor)
   #:use-module (gnu packages augeas)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages backup)
@@ -79,6 +80,7 @@  (define-module (gnu packages virtualization)
   #:use-module (gnu packages cryptsetup)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages cyrus-sasl)
+  #:use-module (gnu packages dbm)
   #:use-module (gnu packages debian)
   #:use-module (gnu packages disk)
   #:use-module (gnu packages dns)
@@ -102,6 +104,7 @@  (define-module (gnu packages virtualization)
   #:use-module (gnu packages gperf)
   #:use-module (gnu packages graphviz)
   #:use-module (gnu packages gtk)
+  #:use-module (gnu packages java)
   #:use-module (gnu packages haskell)
   #:use-module (gnu packages haskell-apps)
   #:use-module (gnu packages haskell-check)
@@ -112,6 +115,7 @@  (define-module (gnu packages virtualization)
   #:use-module (gnu packages libbsd)
   #:use-module (gnu packages libusb)
   #:use-module (gnu packages linux)
+  #:use-module (gnu packages lua)
   #:use-module (gnu packages m4)
   #:use-module (gnu packages man)
   #:use-module (gnu packages multiprecision)
@@ -3148,3 +3152,38 @@  (define-public libguestfs-minimal
 guests, P2V, V2V, performing backups, cloning VMs, building VMs, formatting
 disks, resizing disks, and much more.")
     (license (list license:gpl2+ license:lgpl2.1+))))
+
+(define-public libguestfs
+  (package
+    (inherit libguestfs-minimal)
+    (name "libguestfs")
+    (arguments
+     (substitute-keyword-arguments (package-arguments libguestfs-minimal)
+       ((#:configure-flags flags)
+        #~(cons (string-append "--with-python-installdir="
+                               #$output "/lib/python"
+                               #$(version-major+minor
+                                  (package-version python))
+                               "/site-packages")
+                #$flags))))
+    (native-inputs
+     (modify-inputs (package-native-inputs libguestfs-minimal)
+       (prepend cdrtools
+                gobject-introspection
+                lua
+                `(,openjdk "jdk")
+                python
+                util-linux)))
+    (inputs
+     (modify-inputs (package-inputs libguestfs-minimal)
+       (prepend acl
+                bdb
+                gmp
+                libapparmor
+                libcap
+                libcap-ng
+                libconfig
+                libvirt
+                libxcrypt
+                numactl
+                yajl)))))