From patchwork Thu May 25 16:07:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Tournier X-Patchwork-Id: 50322 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 5C21C27BBE9; Thu, 25 May 2023 17:09:40 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 094C227BBE2 for ; Thu, 25 May 2023 17:09:39 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2DWT-0008PQ-90; Thu, 25 May 2023 12:09:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2DWR-0008MF-Dj for guix-patches@gnu.org; Thu, 25 May 2023 12:09:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2DWR-0003L9-5z for guix-patches@gnu.org; Thu, 25 May 2023 12:09:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2DWQ-00022j-RP for guix-patches@gnu.org; Thu, 25 May 2023 12:09:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63647] [PATCH v3 1/3] guix: import: go: Sort hint about available versions. References: In-Reply-To: Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 25 May 2023 16:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63647 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63647@debbugs.gnu.org Cc: Simon Tournier Received: via spool by 63647-submit@debbugs.gnu.org id=B63647.16850308937773 (code B ref 63647); Thu, 25 May 2023 16:09:02 +0000 Received: (at 63647) by debbugs.gnu.org; 25 May 2023 16:08:13 +0000 Received: from localhost ([127.0.0.1]:47931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2DVc-00021I-DG for submit@debbugs.gnu.org; Thu, 25 May 2023 12:08:12 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:38011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2DVS-00020E-54 for 63647@debbugs.gnu.org; Thu, 25 May 2023 12:08:06 -0400 Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3093bf6614dso275544f8f.0 for <63647@debbugs.gnu.org>; Thu, 25 May 2023 09:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685030876; x=1687622876; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=y244qRQORWlQPqsRz2FcEtZrdw2xPx9OOtmkOHi0wPs=; b=K56ujtPYv5xlv/OmZ8d0lNDhTYwbfwieHEbO3Mi4saVaokX6CW/nzDqXdKKl4+K48l ZHkFaMJ9TIqsleHc99j/jU4h53wg3mGpPMrN86rNjx2yOyO0Q/vy0P2mAITCVHoqaKol pn32EuN9L5FfyBR7mj7H/ndJ+vLjvEF2cdCUds+TMApDFaRHnu/QZbTQ2j3PDscRhO4n a0xjpThOtQHi3itLUY0noVmGYBXZgN9OGFYYIxXXSCBa50UDViAmcvJ/hkozEXUvsHbj 4xvOCOZmaMGrKB8G3xIBFoL4F07pTeLbOuuzHsKoiTsYblKPjNm03MkStlBiTkDoiapg H/VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685030876; x=1687622876; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y244qRQORWlQPqsRz2FcEtZrdw2xPx9OOtmkOHi0wPs=; b=CRkjZOZPgfOyumlPvu1VZqSh76cbqMbURxI6FyQCfkxPJLYRapqqeQi9W3tCxQ54z1 /M7mL0ISK1HvumfS2+tw+k/yEcMrI6szK8VF00O+PUAQh5alOKYdPVgH/xI9VNHdeqSv yA+RGf+iiM7gZdPQfB8lwbF7sZ3XqfMlvz5XK3pTWpfm550IKoWRKB3os2JTAc3TsNTt 9Kthz9aGGa86tzTqiGbKsiDUzdTHY3ghkPn1vy1HH59Jh1oEscLsHkUstm5cJd8Ei5V+ /LBUcK/XueAw1niYAmiKsFADO/IdhiB8RKMliF87HUnhmz9chVe7USgaJS8N6wV5SdPL VSDA== X-Gm-Message-State: AC+VfDz8t3Z+aZ3+vIfIyY5pkJHR8L+GwbI0tg5VKjqTyfnqD1ux1Tkv FaM3gkbbqzHTJzBzCn7FIm4BGzI9IsQ= X-Google-Smtp-Source: ACHHUZ4toX1R49hPx7WAlG5fjKAjIqk2ouHbiis2KjuMsf0/lIwVPN3ShgF1MHsxaY8buqDvOx+b6A== X-Received: by 2002:a5d:6691:0:b0:2f8:15d8:e627 with SMTP id l17-20020a5d6691000000b002f815d8e627mr4279913wru.7.1685030876290; Thu, 25 May 2023 09:07:56 -0700 (PDT) Received: from localhost.localdomain ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id y9-20020a5d4709000000b00307d58b3da9sm2261016wrq.25.2023.05.25.09.07.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 09:07:55 -0700 (PDT) From: Simon Tournier Date: Thu, 25 May 2023 18:07:47 +0200 Message-Id: X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * guix/import/go.scm (validate-version): Sort available versions. --- guix/import/go.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) base-commit: 99fc7e5dd3c9c92f9b6c2e51db9dc5b0481a56b2 diff --git a/guix/import/go.scm b/guix/import/go.scm index 0357e6a1eb..1943869162 100644 --- a/guix/import/go.scm +++ b/guix/import/go.scm @@ -34,6 +34,7 @@ (define-module (guix import go) #:use-module (guix packages) #:use-module (guix http-client) #:use-module (guix memoization) + #:use-module (guix utils) #:autoload (htmlprag) (html->sxml) ;from Guile-Lib #:autoload (guix base32) (bytevector->nix-base32-string) #:autoload (guix build utils) (mkdir-p) @@ -588,8 +589,9 @@ (define (validate-version version available-versions module-path) (condition (&fix-hint (hint (format #f (G_ "Pick one of the following \ available versions:~{ ~a~}.") - (map strip-v-prefix - available-versions))))))))) + (sort (map strip-v-prefix + available-versions) + version>?))))))))) (define* (go-module->guix-package module-path #:key (goproxy "https://proxy.golang.org")