| Message ID | a44c1913-9030-1c1b-879c-981708b6bdc1@danielschaefer.me |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#37886] gnu: Add ipcalc. | expand |
Hello Daniel, > here's my first patch to guix - please let me know whether everything's okay. > It adds the ipcalc package which can calculate IP ranges. Example: Welcome to Guix :) This first patch looks fine, I just have two remarks. > new file mode 100644 > index 0000000000..5f83389b25 > --- /dev/null > +++ b/gnu/packages/ipcalc.scm I think you can use the existing networking.scm for this tool. > + (description "ipcalc takes an IP address and netmask and calculates the > + resulting broadcast, network, Cisco wildcard mask, and host > + range. By giving a second netmask, you can design subnets and > + supernets. It is also intended to be a teaching tool and > + presents the subnetting results as easy-to-understand binary > + values.") The indentation is not correct here. You can use M-q if you are using emacs or indent.el script otherwise (see: https://guix.gnu.org/manual/en/html_node/Formatting-Code.html). Can you please send an updated patch? Thanks, Mathieu
Hello Daniel, Did you have a chance to look into the suggestions Mathieu made? See <https://issues.guix.gnu.org/issue/37886>. Thanks in advance! :-) Ludo’. Mathieu Othacehe <m.othacehe@gmail.com> skribis: > Hello Daniel, > >> here's my first patch to guix - please let me know whether everything's okay. >> It adds the ipcalc package which can calculate IP ranges. Example: > > Welcome to Guix :) This first patch looks fine, I just have two remarks. > >> new file mode 100644 >> index 0000000000..5f83389b25 >> --- /dev/null >> +++ b/gnu/packages/ipcalc.scm > > I think you can use the existing networking.scm for this tool. > >> + (description "ipcalc takes an IP address and netmask and calculates the >> + resulting broadcast, network, Cisco wildcard mask, and host >> + range. By giving a second netmask, you can design subnets and >> + supernets. It is also intended to be a teaching tool and >> + presents the subnetting results as easy-to-understand binary >> + values.") > > The indentation is not correct here. You can use M-q if you are using > emacs or indent.el script otherwise (see: > https://guix.gnu.org/manual/en/html_node/Formatting-Code.html). > > Can you please send an updated patch? > > Thanks, > > Mathieu
diff --git a/gnu/packages/ipcalc.scm b/gnu/packages/ipcalc.scm new file mode 100644 index 0000000000..5f83389b25 --- /dev/null +++ b/gnu/packages/ipcalc.scm @@ -0,0 +1,61 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright © 2019 Daniel Schaefer <git@danielschaefer.me> +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see <http://www.gnu.org/licenses/>. + +(define-module (gnu packages ipcalc) + #:use-module (gnu packages perl) + #:use-module (gnu packages) + #:use-module (guix download) + #:use-module (guix licenses) + #:use-module (guix packages) + #:use-module (guix build-system gnu)) + +(define-public ipcalc + (package + (name "ipcalc") + (version "0.41") + (source (origin + (method url-fetch) + (uri (string-append "http://jodies.de/ipcalc-archive/" + name "-" version ".tar.gz")) + (sha256 + (base32 + "12if9sm8h2ac0pgwkw835cgyqjxm6h27k4kfn2vfas9krrqwbafx")))) + (inputs `(("perl" ,perl))) + (build-system gnu-build-system) + (arguments + '(#:tests? #f ; No test suite + #:phases + (modify-phases %standard-phases + (delete 'configure) + (delete 'build) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let ((out-bin (string-append + (assoc-ref outputs "out") + "/bin"))) + (install-file "ipcalc" out-bin) + #t)))))) + (synopsis "Simple IP network calculator") + (description "ipcalc takes an IP address and netmask and calculates the + resulting broadcast, network, Cisco wildcard mask, and host + range. By giving a second netmask, you can design subnets and + supernets. It is also intended to be a teaching tool and + presents the subnetting results as easy-to-understand binary + values.") + (home-page "http://jodies.de/ipcalc") + (license gpl2+)))