From patchwork Tue Jan 29 21:44:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: swedebugia X-Patchwork-Id: 920 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 001C416B10; Tue, 29 Jan 2019 21:46:08 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 6E57216B0E for ; Tue, 29 Jan 2019 21:46:08 +0000 (GMT) Received: from localhost ([127.0.0.1]:56059 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gobCp-00005B-Lg for patchwork@mira.cbaines.net; Tue, 29 Jan 2019 16:46:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gobCm-00004s-DI for guix-patches@gnu.org; Tue, 29 Jan 2019 16:46:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gobCl-00019J-09 for guix-patches@gnu.org; Tue, 29 Jan 2019 16:46:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51618) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gobCk-000199-NF for guix-patches@gnu.org; Tue, 29 Jan 2019 16:46:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gobCk-00088G-5V for guix-patches@gnu.org; Tue, 29 Jan 2019 16:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#34217] [PATCH 11/11] gnu: Add ruby-cucumber and ruby-aruba. Resent-From: swedebugia Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Jan 2019 21:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34217 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines , 34217@debbugs.gnu.org Received: via spool by 34217-submit@debbugs.gnu.org id=B34217.154879830331185 (code B ref 34217); Tue, 29 Jan 2019 21:46:02 +0000 Received: (at 34217) by debbugs.gnu.org; 29 Jan 2019 21:45:03 +0000 Received: from localhost ([127.0.0.1]:50899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gobBm-00086t-JR for submit@debbugs.gnu.org; Tue, 29 Jan 2019 16:45:03 -0500 Received: from mx1.riseup.net ([198.252.153.129]:43086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gobBk-00086A-A0 for 34217@debbugs.gnu.org; Tue, 29 Jan 2019 16:45:01 -0500 Received: from cotinga.riseup.net (cotinga-pn.riseup.net [10.0.1.164]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.riseup.net (Postfix) with ESMTPS id 72A361A0842; Tue, 29 Jan 2019 13:44:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1548798299; bh=6ziU8vVTl1zMqxrsgL8GWwf/8zyFsq1e/+P/rZ38CVU=; h=Subject:To:References:From:Date:In-Reply-To:From; b=gFq4RwOSmuz77RqKWahDaihBcevfuc3utRbrZ11OE6V8S3WYHd5UmmO9qcA7Wwuhs XFh05dZlLpnL17646f0T6DQ9sjM7I+zf4hdfm1uyOoaL77ZNwadnVt8b2JWoETuKpV sgS/JJdhabDAGIjnxPI042/FsvdxT9hVwOY+KKzs= X-Riseup-User-ID: C2F09F0EAA8F9BECFCEDABE5DF2C9D9F495542F1D86905263225F34C9E81ADFE Received: from [127.0.0.1] (localhost [127.0.0.1]) by cotinga.riseup.net with ESMTPSA id 5D911424E2; Tue, 29 Jan 2019 13:44:57 -0800 (PST) References: <87zhrmgy0x.fsf@cbaines.net> <20190127114956.26570-1-mail@cbaines.net> <20190127114956.26570-11-mail@cbaines.net> From: swedebugia Message-ID: Date: Tue, 29 Jan 2019 22:44:55 +0100 MIME-Version: 1.0 In-Reply-To: <20190127114956.26570-11-mail@cbaines.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches On 2019-01-27 12:49, Christopher Baines wrote: > These packages are mutually dependant, so I've put them in one commit. > > * gnu/packages/ruby.scm (ruby-aruba, ruby-cucumber): New variables. > --- > gnu/packages/ruby.scm | 136 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 136 insertions(+) > > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm > index e507c816c8..59895240f8 100644 > --- a/gnu/packages/ruby.scm > +++ b/gnu/packages/ruby.scm > @@ -32,6 +32,7 @@ > #:use-module ((guix licenses) #:prefix license:) > #:use-module (gnu packages) > #:use-module (gnu packages base) > + #:use-module (gnu packages check) > #:use-module (gnu packages compression) > #:use-module (gnu packages databases) > #:use-module (gnu packages dbm) > @@ -3795,6 +3796,141 @@ It is intended be used by all Cucumber implementations to parse > (home-page "https://github.com/cucumber-attic/gherkin") > (license license:expat))) > > +(define-public ruby-aruba > + (package > + (name "ruby-aruba") > + (version "0.14.7") > + (source > + (origin > + (method url-fetch) > + (uri (rubygems-uri "aruba" version)) > + (sha256 > + (base32 > + "0x27352n15dsyf5ak246znfawbrm502q15r4msjw3cis17jlcy1l")))) > + (build-system ruby-build-system) > + (arguments > + '(;; TODO: There are a few test failures > + ;; 357 examples, 7 failures I investigated this and found: Failed examples: rspec ./spec/aruba/api_spec.rb:389 # Aruba::Api files #touch when directory when exist and the mtim\ e should be set statically rspec ./spec/aruba/api_spec.rb:388 # Aruba::Api files #touch when directory when exist and the mtim\ e should be set statically behaves like an existing directory rspec ./spec/aruba/api_spec.rb:362 # Aruba::Api files #touch when file when does not exist and the \ mtime should be set statically rspec ./spec/aruba/api_spec.rb:361 # Aruba::Api files #touch when file when does not exist and the \ mtime should be set statically behaves like an existing file rspec ./spec/aruba/matchers/command_spec.rb:165 # Command Matchers #to_have_output_on_stderr when h\ ave output hello world on stderr ave output hello world on stderr rspec ./spec/aruba/matchers/command_spec.rb:128 # Command Matchers #to_have_output_on_stdout when h\ ave output hello world on stderr rspec ./spec/aruba/matchers/command_spec.rb:91 # Command Matchers #to_have_output when have output \ hello world on stderr The offending lines are in spec/aruba/api_spec.rb beginning on line: 321, ending on 393 I tried creating a patch with diff for this file. I don't know if this is the way others here usually create patches. If not please enlighten me! :) 321,393c321,393 < describe 'files' do < describe '#touch' do < let(:name) { @file_name } < let(:path) { @file_path } < let(:options) { {} } < < before :each do < @aruba.set_environment_variable 'HOME', File.expand_path(@aruba.aruba.current_directory) < end < < context 'when file' do < before :each do < @aruba.touch(name, options) < end < < context 'when does not exist' do < context 'and should be created in existing directory' do < it { expect(File.size(path)).to eq 0 } < it_behaves_like 'an existing file' < end < < context 'and should be created in non-existing directory' do < let(:name) { 'directory/test' } < let(:path) { File.join(@aruba.aruba.current_directory, 'directory/test') } < < it_behaves_like 'an existing file' < end < < context 'and path includes ~' do < let(:string) { random_string } < let(:name) { File.join('~', string) } < let(:path) { File.join(@aruba.aruba.current_directory, string) } < < it_behaves_like 'an existing file' < end < < context 'and the mtime should be set statically' do < let(:time) { Time.parse('2014-01-01 10:00:00') } < let(:options) { { :mtime => Time.parse('2014-01-01 10:00:00') } } < < it_behaves_like 'an existing file' < it { expect(File.mtime(path)).to eq time } < end < < context 'and multiple file names are given' do < let(:name) { %w(file1 file2 file3) } < let(:path) { %w(file1 file2 file3).map { |p| File.join(@aruba.aruba.current_directory, p) } } < it_behaves_like 'an existing file' < end < end < end < < context 'when directory' do < let(:name) { %w(directory1) } < let(:path) { Array(name).map { |p| File.join(@aruba.aruba.current_directory, p) } } < < context 'when exist' do < before(:each) { Array(path).each { |p| Aruba.platform.mkdir p } } < < before :each do < @aruba.touch(name, options) < end < < context 'and the mtime should be set statically' do < let(:time) { Time.parse('2014-01-01 10:00:00') } < let(:options) { { :mtime => Time.parse('2014-01-01 10:00:00') } } < < it_behaves_like 'an existing directory' < it { Array(path).each { |p| expect(File.mtime(p)).to eq time } } < end < end < end < end --- > # describe 'files' do > # describe '#touch' do > # let(:name) { @file_name } > # let(:path) { @file_path } > # let(:options) { {} } > > # before :each do > # @aruba.set_environment_variable 'HOME', File.expand_path(@aruba.aruba.current_directory) > # end > > # context 'when file' do > # before :each do > # @aruba.touch(name, options) > # end > > # context 'when does not exist' do > # context 'and should be created in existing directory' do > # it { expect(File.size(path)).to eq 0 } > # it_behaves_like 'an existing file' > # end > > # context 'and should be created in non-existing directory' do > # let(:name) { 'directory/test' } > # let(:path) { File.join(@aruba.aruba.current_directory, 'directory/test') } > > # it_behaves_like 'an existing file' > # end > > # context 'and path includes ~' do > # let(:string) { random_string } > # let(:name) { File.join('~', string) } > # let(:path) { File.join(@aruba.aruba.current_directory, string) } > > # it_behaves_like 'an existing file' > # end > > # context 'and the mtime should be set statically' do > # let(:time) { Time.parse('2014-01-01 10:00:00') } > # let(:options) { { :mtime => Time.parse('2014-01-01 10:00:00') } } > > # it_behaves_like 'an existing file' > # it { expect(File.mtime(path)).to eq time } > # end > > # context 'and multiple file names are given' do > # let(:name) { %w(file1 file2 file3) } > # let(:path) { %w(file1 file2 file3).map { |p| File.join(@aruba.aruba.current_directory, p) } } > # it_behaves_like 'an existing file' > # end > # end > # end > > # context 'when directory' do > # let(:name) { %w(directory1) } > # let(:path) { Array(name).map { |p| File.join(@aruba.aruba.current_directory, p) } } > > # context 'when exist' do > # before(:each) { Array(path).each { |p| Aruba.platform.mkdir p } } > > # before :each do > # @aruba.touch(name, options) > # end > > # context 'and the mtime should be set statically' do > # let(:time) { Time.parse('2014-01-01 10:00:00') } > # let(:options) { { :mtime => Time.parse('2014-01-01 10:00:00') } } > > # it_behaves_like 'an existing directory' > # it { Array(path).each { |p| expect(File.mtime(p)).to eq time } } > # end > # end > # end > # end