[bug#75810,v6,11/16] linux-container: ‘unprivileged-user-namespace-supported?’ returns #f on non-Linux.
| Message ID | a2bea8f1119e7273e953337780d481d76017f209.1742230219.git.ludo@gnu.org |
|---|---|
| State | New |
| Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 1A92E27BBEA; Mon, 17 Mar 2025 17:06:04 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id C587B27BBE2 for <patchwork@mira.cbaines.net>; Mon, 17 Mar 2025 17:06:03 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1tuDu2-0005Fo-GS; Mon, 17 Mar 2025 13:05:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tuDu0-0005Ej-Lp for guix-patches@gnu.org; Mon, 17 Mar 2025 13:05:25 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tuDtz-0005jp-6U for guix-patches@gnu.org; Mon, 17 Mar 2025 13:05:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=VxUd1aOcvzD/pYxOxBWjge8/c0+rM0LNoWab4Huyg4s=; b=FESd+OB6S7xzh89smrc/yPTkMTFBDwGT3tqXlqadi2fERoDdRKJIHms6hb6RKVvrJ8S3tLrEvKzcayAJ7NDx45TmgfqBV3VTCrkkbaC/pGcWPoN1/Ob8jam8sbBxzZMEVu5paRnGR1shFsH91UBnOl6X99CtCBpe5HZk9n/mpMBa81K+MoPb5X6CmqVRmRYpU7lzCg7WRCZY1hCNvZOQ+txHWwm0fPXpLj5iO3cgwiqZUsLJjaImX/Q+j/hUgMURQUeAwlxTf1Fn7qlbbCjwldm6FvmC1Dw5LST/EemzuQwYM8Oap7WQNcbgrTDsDU7lQ9USgrzg8w/lPPwNTcD7JQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tuDty-0002v3-Es for guix-patches@gnu.org; Mon, 17 Mar 2025 13:05:22 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#75810] [PATCH v6 11/16] linux-container: =?utf-8?q?=E2=80=98un?= =?utf-8?q?privileged-user-namespace-supported=3F=E2=80=99?= returns #f on non-Linux. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 17 Mar 2025 17:05:22 +0000 Resent-Message-ID: <handler.75810.B75810.174223110710793@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75810 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 75810@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org>, Reepca Russelstein <reepca@russelstein.xyz> Received: via spool by 75810-submit@debbugs.gnu.org id=B75810.174223110710793 (code B ref 75810); Mon, 17 Mar 2025 17:05:22 +0000 Received: (at 75810) by debbugs.gnu.org; 17 Mar 2025 17:05:07 +0000 Received: from localhost ([127.0.0.1]:60683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1tuDth-0002nH-RC for submit@debbugs.gnu.org; Mon, 17 Mar 2025 13:05:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58482) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <ludo@gnu.org>) id 1tuDtY-0002je-2K for 75810@debbugs.gnu.org; Mon, 17 Mar 2025 13:04:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@gnu.org>) id 1tuDtQ-0005QN-Fc; Mon, 17 Mar 2025 13:04:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=VxUd1aOcvzD/pYxOxBWjge8/c0+rM0LNoWab4Huyg4s=; b=UEQuv85I/vuSWiKvC4CI IcavIKQ9UskkSrQ9Idf/AxP3Q/KA4LQemcLzCU+0wHtmBpYuJNWUqzyEIacy+aS8UHcFdR4lBXn6V LZcc/qKPkZe+N989CGm+9UVnKSMIdcY4nmKXnGlsGeu7nTZc61M8ELnrFN0pdSoKeYVIZrk2kILwR QNSKXfUSL+zLV8GcSqU0r4pQSXSE3hX2FuFytkbTF1kdogL+MTgl62iRTcfVgz6Hymt1cHcAlAupc FStmyNroCFhadgH9olY4ut4AmOAXeJm/Dk6mzlRyJVklnh3A3JR8NHEwoEumzZ6ZjVK8jhtUr5LGa z+tOhRfJnUZWRw==; From: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org> Date: Mon, 17 Mar 2025 18:02:54 +0100 Message-ID: <a2bea8f1119e7273e953337780d481d76017f209.1742230219.git.ludo@gnu.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <cover.1742230219.git.ludo@gnu.org> References: <cover.1742230219.git.ludo@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
| Series |
Rootless guix-daemon
|
|
Commit Message
Ludovic Courtès
March 17, 2025, 5:02 p.m. UTC
Previously this procedure would return #t on non-Linux systems. * gnu/build/linux-container.scm (unprivileged-user-namespace-supported?): When USERNS-FILE doesn’t exist, return (user-namespace-supported?). Reported-by: Reepca Russelstein <reepca@russelstein.xyz> Change-Id: I92050338b8b68bc3bd87100317eba69fcdf14a0a --- gnu/build/linux-container.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gnu/build/linux-container.scm b/gnu/build/linux-container.scm index 5c303da8c8..a5c5d8962e 100644 --- a/gnu/build/linux-container.scm +++ b/gnu/build/linux-container.scm @@ -1,6 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2015 David Thompson <davet@gnu.org> -;;; Copyright © 2017-2019, 2022, 2023 Ludovic Courtès <ludo@gnu.org> +;;; Copyright © 2017-2019, 2022-2023, 2025 Ludovic Courtès <ludo@gnu.org> ;;; ;;; This file is part of GNU Guix. ;;; @@ -44,7 +44,7 @@ (define (unprivileged-user-namespace-supported?) (let ((userns-file "/proc/sys/kernel/unprivileged_userns_clone")) (if (file-exists? userns-file) (eqv? #\1 (call-with-input-file userns-file read-char)) - #t))) + (user-namespace-supported?)))) (define (setgroups-supported?) "Return #t if the setgroups proc file, introduced in Linux-libre 3.19,