| Message ID | a27cfc2fcc86aead30a4df0ecace4374896657d0.1699049902.git.Rostislav.Svoboda@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [bug#66924] gnu: emacs-evil-anzu: Update to 0.03-0.d1e98ee. | expand |
Am Freitag, dem 03.11.2023 um 23:18 +0100 schrieb Rostislav Svoboda: > The github url redirects from syohex/emacs-evil-anzu to > emacsorphanage/evil-anzu. > > * gnu/packages/emacs-xyz.scm (emacs-evil-anzu): Update to 0.03- > 0.d1e98ee. The home-page update should be reflected in the ChangeLog rather than explained in prose. You might also want to add a comment to the file as to why we're checking out a commit. Cheers
> The home-page update should be reflected in the ChangeLog rather than explained in prose. ??? What do you exactly mean by "reflected"? I'm not trying to explain or reflect anything. I wrote this little note there so that people know that I didn't change the repo URL by mistake. I looked at the changes between 0.03 and d1e98ee - seem legit to me, no backdoors or anything of that sort. The 0.03 is almost 9 years old, the d1e98ee has been on melpa since March 2023 and it looks like the changes are really needed, 'cause some other thing (doom emacs), is throwing me an error when the 0.03 is used. > You might also want to add a comment to the file as to why we're checking out a commit. ??? There's nothing else to check out. And that wouldn't be a meaningful comment. Cheers
Am Samstag, dem 04.11.2023 um 01:14 +0100 schrieb Rostislav Svoboda: > > The home-page update should be reflected in the ChangeLog rather > > than explained in prose. > > ??? > What do you exactly mean by "reflected"? I'm not trying to explain or > reflect anything. I wrote this little note there so that people know > that I didn't change the repo URL by mistake. IOW you explained it :) > I looked at the changes between 0.03 and d1e98ee - seem legit to me, > no backdoors or anything of that sort. The 0.03 is almost 9 years > old, the d1e98ee has been on melpa since March 2023 and it looks like > the changes are really needed, 'cause some other thing (doom emacs), > is throwing me an error when the 0.03 is used. > > > You might also want to add a comment to the file as to why we're > > checking out a commit. > > ??? > There's nothing else to check out. And that wouldn't be a meaningful > comment. Look at other Emacs packages that have not had a long release. They carry a comment like ";; No release since DATE." Cheers
On Sat, Nov 04 2023, Liliana Marie Prikler wrote: > Am Samstag, dem 04.11.2023 um 01:14 +0100 schrieb Rostislav Svoboda: >> > The home-page update should be reflected in the ChangeLog rather >> > than explained in prose. >> >> ??? >> What do you exactly mean by "reflected"? I'm not trying to explain or >> reflect anything. I wrote this little note there so that people know >> that I didn't change the repo URL by mistake. > IOW you explained it :) > >> I looked at the changes between 0.03 and d1e98ee - seem legit to me, >> no backdoors or anything of that sort. The 0.03 is almost 9 years >> old, the d1e98ee has been on melpa since March 2023 and it looks like >> the changes are really needed, 'cause some other thing (doom emacs), >> is throwing me an error when the 0.03 is used. >> >> > You might also want to add a comment to the file as to why we're >> > checking out a commit. >> >> ??? >> There's nothing else to check out. And that wouldn't be a meaningful >> comment. > Look at other Emacs packages that have not had a long release. They > carry a comment like ";; No release since DATE." Please, this is bikeshedding :) Even more packages don't have this comment and it's not the most useful comment anyways. --8<---------------cut here---------------start------------->8--- Spend time proportional to the stakes. Ensure the discussion focuses on important aspects of the changes; do not let it be derailed by objectively unimportant issues (This situation is often referred to as “bikeshedding”, where much time is spent discussing each one's preference for the color of the shed at the expense progress made on the project to keep bikes dry). --8<---------------cut here---------------end--------------->8--- This patch looks good.
Am Samstag, dem 04.11.2023 um 11:47 +0100 schrieb Clément Lassieur: > On Sat, Nov 04 2023, Liliana Marie Prikler wrote: > > > Am Samstag, dem 04.11.2023 um 01:14 +0100 schrieb Rostislav > > Svoboda: > > > There's nothing else to check out. And that wouldn't be a > > > meaningful comment. > > Look at other Emacs packages that have not had a long release. > > They carry a comment like ";; No release since DATE." > > Please, this is bikeshedding :) > > Even more packages don't have this comment and it's not the most > useful comment anyways. Given that the change from packaging a release to packaging a non- release and vice versa requires re-indenting the whole thing, and that non-releases don't really work well with `guix refresh', I think *a comment* as to why a non-release is chosen and what else to watch out for when updating the package is nice to have. We can discuss the form of that comment, but that would be bikeshedding :) > --8<---------------cut here---------------start------------->8--- > Spend time proportional to the stakes. […] > --8<---------------cut here---------------end--------------->8--- The stakes are low and the suggested changes small. The time it would take to amend the commit is proportional. The time to go back and forth seeking a justification as for why or why not to do so not so. Cheers
Am Freitag, dem 03.11.2023 um 23:52 +0100 schrieb Liliana Marie Prikler: > Am Freitag, dem 03.11.2023 um 23:18 +0100 schrieb Rostislav Svoboda: > > The github url redirects from syohex/emacs-evil-anzu to > > emacsorphanage/evil-anzu. > > > > * gnu/packages/emacs-xyz.scm (emacs-evil-anzu): Update to 0.03- > > 0.d1e98ee. > The home-page update should be reflected in the ChangeLog rather than > explained in prose. You might also want to add a comment to the file > as to why we're checking out a commit. > > Cheers Pushed with exactly these changes. Cheers
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 07a9d4cbe7..a8a5bbed43 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -22283,26 +22283,28 @@ (define-public emacs-psc-ide (license license:gpl3+)))) (define-public emacs-evil-anzu - (package - (name "emacs-evil-anzu") - (version "0.03") - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/syohex/emacs-evil-anzu") - (commit version))) - (file-name (git-file-name name version)) - (sha256 - (base32 "0lw7fg4gqwj30r0l6k2ni36sxqkf65zf0d0z3rxnpwbxlf8dlkrr")))) - (build-system emacs-build-system) - (propagated-inputs - (list emacs-evil emacs-anzu)) - (home-page "https://github.com/syohex/emacs-evil-anzu") - (synopsis "Anzu for evil-mode") - (description "@code{anzu} provides a minor mode that displays the current + (let ((commit "d1e98ee6976437164627542909a25c6946497899") + (revision "0")) + (package + (name "emacs-evil-anzu") + (version (git-version "0.03" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/emacsorphanage/evil-anzu") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1i8f360lq5a32knkzbwdw10ql9cxsmgfd4iiwnr7vcwacm34zq88")))) + (build-system emacs-build-system) + (propagated-inputs (list emacs-evil emacs-anzu)) + (home-page "https://github.com/emacsorphanage/evil-anzu") + (synopsis "Anzu for evil-mode") + (description + "@code{anzu} provides a minor mode that displays the current match and total match information in the mode-line in various search modes.") - (license license:gpl3+))) + (license license:gpl3+)))) (define-public emacs-pg (package