diff mbox series

[bug#65444] gnu-maintenance: Improve check for disabled host names.

Message ID a20a2de8e964dbc07cde94f7cadc2c923c6ec3b6.1692651381.git.maxim.cournoyer@gmail.com
State New
Headers show
Series [bug#65444] gnu-maintenance: Improve check for disabled host names. | expand

Commit Message

Maxim Cournoyer Aug. 21, 2023, 8:56 p.m. UTC 
Found while investigating <https://issues.guix.gnu.org/65304>.

* guix/gnu-maintenance.scm (html-updatable-package?): Tighten predicate.
---

 guix/gnu-maintenance.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)


base-commit: 4c7627dfec88350f9a1705e9527c38dd41506f8b

Comments

Ludovic Courtès Aug. 22, 2023, 4:28 p.m. UTC | #1 
Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:

> Found while investigating <https://issues.guix.gnu.org/65304>.
>
> * guix/gnu-maintenance.scm (html-updatable-package?): Tighten predicate.

LGTM!
Maxim Cournoyer Aug. 25, 2023, 2:08 p.m. UTC | #2 
Hello,

Ludovic Courtès <ludo@gnu.org> writes:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> Found while investigating <https://issues.guix.gnu.org/65304>.
>>
>> * guix/gnu-maintenance.scm (html-updatable-package?): Tighten predicate.
>
> LGTM!

This change was installed with
c655231b72ac28b5a433069fcf86a835c9c83691.  Thanks for the review!
diff mbox series

Patch

diff --git a/guix/gnu-maintenance.scm b/guix/gnu-maintenance.scm
index 32712f7218..5c16a7617d 100644
--- a/guix/gnu-maintenance.scm
+++ b/guix/gnu-maintenance.scm
@@ -846,7 +846,11 @@  (define html-updatable-package?
                           (let ((scheme (uri-scheme uri))
                                 (host   (uri-host uri)))
                             (and (memq scheme '(http https))
-                                 (not (member host hosting-sites)))))))))
+                                 ;; HOST may contain prefixes,
+                                 ;; e.g. "profanity-im.github.io", hence the
+                                 ;; suffix-based test below.
+                                 (not (any (cut string-suffix? <> host)
+                                           hosting-sites)))))))))
 
     (lambda (package)
       (or (assoc-ref (package-properties package) 'release-monitoring-url)