Message ID | a17a80cb6c49792d27f09817e484461bb190c9d3.1632883770.git.iskarian@mgsn.dev |
---|---|
State | Accepted |
Headers | show |
Series | [bug#50884] import: go: Handle extra whitespace in "go-import" meta tags. | expand |
Context | Check | Description |
---|---|---|
cbaines/applying patch | fail | View Laminar job |
cbaines/issue | success | View issue |
cbaines/applying patch | fail | View Laminar job |
cbaines/issue | success | View issue |
cbaines/applying patch | fail | View Laminar job |
cbaines/issue | success | View issue |
cbaines/applying patch | fail | View Laminar job |
cbaines/issue | success | View issue |
cbaines/applying patch | fail | View Laminar job |
cbaines/issue | success | View issue |
Sarah Morgensen <iskarian@mgsn.dev> skribis: > Some packages sites use extra whitespace in the content portion of <meta > name="go-import" ...> tags, so handle that. Example: > <https://k8s.io/api?go-get=1> > > * guix/import/go.scm (fetch-module-meta-data)[go-import->module-meta]: > Use 'string-tokenize' instead of 'string-split'. Applied, thanks! Would it make sense to have a regression test? Ludo’.
diff --git a/guix/import/go.scm b/guix/import/go.scm index 9769b557ae..ca909ab35a 100644 --- a/guix/import/go.scm +++ b/guix/import/go.scm @@ -474,7 +474,7 @@ Optionally include a VERSION string to append to the name." because goproxy servers don't currently provide all the information needed to build a package." (define (go-import->module-meta content-text) - (match (string-split content-text #\space) + (match (string-tokenize content-text char-set:graphic) ((root-path vcs repo-url) (make-module-meta root-path (string->symbol vcs) (strip-.git-suffix/maybe repo-url)))))