Message ID | Z8ZNlSc-d6XXvY6_@kernelpanicroom |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2975427BBEA; Tue, 4 Mar 2025 00:48:27 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 8C7B627BBE2 for <patchwork@mira.cbaines.net>; Tue, 4 Mar 2025 00:48:26 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1tpGS6-0005h6-1v; Mon, 03 Mar 2025 19:48:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tpGS4-0005ga-L3 for guix-patches@gnu.org; Mon, 03 Mar 2025 19:48:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tpGS2-0001O2-Vt for guix-patches@gnu.org; Mon, 03 Mar 2025 19:48:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:From:Date:To:Subject; bh=jvLMwQif00B4bH/OPKF+x3xaMNdWDbGMcNlMat6j/o0=; b=fPuDoBkpfby1O2YhPMVqjhLfXtFgqt7E2qepESDSCg4wh4Hudtp07uX8wa7wuj+L4QwaEBlw2qG3RuW0sFIesk/KG7q96Me4QDFFwYzrP7VbD4rKBN5ipss1nzpXlAl2ENo451p0iq3xXMns+zfCYaVLpqYuSBeFZWs+43R8i8JzdZnRMJi/DEruqHmdH1ekIUHXxg6BNR+UYm8/WHvpAtWeXHkftxQzLx27/sisdiVBb1gyIqunx7GWTtGKjvPjDqVj/pbe3Fkbl2iB/EKM9rHCRu1ZrH+7lyKClfqLEaEC2Ju+4LYE8fbSpEmW5a7x3l/g2er6B1JeT08VAcQp7g==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tpGS2-0000t8-Qv for guix-patches@gnu.org; Mon, 03 Mar 2025 19:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#76728] [PATCH] gnu: avogadro2: fix open babel input Resent-From: Jakob Kirsch <jakob.kirsch@web.de> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 04 Mar 2025 00:48:02 +0000 Resent-Message-ID: <handler.76728.B.17410492783395@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 76728 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 76728@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17410492783395 (code B ref -1); Tue, 04 Mar 2025 00:48:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 Mar 2025 00:47:58 +0000 Received: from localhost ([127.0.0.1]:53162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1tpGRx-0000sg-LB for submit@debbugs.gnu.org; Mon, 03 Mar 2025 19:47:57 -0500 Received: from lists.gnu.org ([2001:470:142::17]:39926) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <jakob.kirsch@web.de>) id 1tpGRu-0000sC-Bc for submit@debbugs.gnu.org; Mon, 03 Mar 2025 19:47:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <jakob.kirsch@web.de>) id 1tpGRk-0005fN-Mh for guix-patches@gnu.org; Mon, 03 Mar 2025 19:47:44 -0500 Received: from mout.web.de ([212.227.15.14]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <jakob.kirsch@web.de>) id 1tpGRf-0001BL-77 for guix-patches@gnu.org; Mon, 03 Mar 2025 19:47:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1741049238; x=1741654038; i=jakob.kirsch@web.de; bh=jvLMwQif00B4bH/OPKF+x3xaMNdWDbGMcNlMat6j/o0=; h=X-UI-Sender-Class:Date:From:To:Subject:Message-ID:MIME-Version: Content-Type:cc:content-transfer-encoding:content-type:date:from: message-id:mime-version:reply-to:subject:to; b=Ovz3ZKj9awC//ZAVuMvCIhU+yjZalkmSNfy+voqFnZ+sUnTDyYRWvZpeXXXsspM+ IMaJ6AG04zwbQFKuEnd2y6HI54IBV6U03el4NRtGmlKBo51g7rna7sNRBatPZARQ3 FSSYyYX1TLfiDuMdJPlGxcBtpbee8bR/PF46Jotgy8rCuZ/sGxtMhIPrjn7oqfo9W xsADtvnmBWh27YBzUkZ64KZAx6ymLDsOJK7jTuFqXpP/J7s8nXfT3ptFSnLVVFbA+ JFlHcdyy0WUs+Q9tRDXUfbtt2Ty9c2tXU77XAChhhvACupEWyhtLgqB8C1n03MvJC FNkB0fvE+JiKGrmszQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from kernelpanicroom ([134.19.29.228]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N2SPD-1t8BPm2kgR-017WiT for <guix-patches@gnu.org>; Tue, 04 Mar 2025 01:47:18 +0100 Date: Tue, 4 Mar 2025 01:47:17 +0100 Message-ID: <Z8ZNlSc-d6XXvY6_@kernelpanicroom> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="CvqVe5i5AIjPvPUz" Content-Disposition: inline X-Provags-ID: V03:K1:1dhnA4g3PyGbsfS2aZki9Pjn04r48f4MzAMZEVC9QhfyDCPIGaZ Zv83RSerD0Wk/MVxeR+tn8V64tR5jGGbiwXXrxlpo/L6XWKEGpqAdZeYN3O/w00RvIogaah Ga00q6kFbo6GL0MDKFfih5iRZyfdOe1Acl5csrEHa4C1sxiph1avHzjLr294h6Hym86z6V3 WwqEsTmhZbJTGB/+zWEgA== UI-OutboundReport: notjunk:1;M01:P0:EAnTLS+/5AA=;TnPNNo84fVUQPhnpZeXypcrhRio Hz3k2B0+RbC/9x/NADrdQLcHetKTgHe3WP4+tiDXobjdLD45Ec95+L1grQ55wp/OZUX6Ftgfe gMGxuAszWAmtcRuAzsc0ZpGs2//jBrDwkmKYG46Bryj3EJBRTMXEFFjdiPYmryqNlDQPauy/t i5OeAxbBW4E3gCA4X9SwDyt17pQL6NqqftPIdEkUZIjN8kDDgIVjA3XJBnWNYqJ858jRvOf9z bCW9cqGdryr/jZ6ELslcrAu/15F/KlKRtZPSgmL7pVOddJlRZQDvd143WAo75tICCa2LJeIJ1 BmEFkZ+7ECp8MEowupTExCwRCyQqIH3tS0Ic9hYRD+OIkNkqg9STBwpCosVHz81T+uq+uIfpg oHWm3xXR/CBjAlSwMxL0eenTwFpeH/EXYH3g96oEwGmhzT9Al+U1OLh2SKa3Dg/JCn4DSqxHe Q5/xSyt1VaQMsOhSu229TDV7/S2kXdZ7r6CLk09ckh3l6AulBhD0KaJpXvxR7Yax9iu8o+9jc tg5zOYhYeIKobeIAWDBxIdSDH6w0nbkSyadHPGfd6WOvPw4PjsamgyMJLM2g7b7m01rHC5ntu 7TdzlRq58LXl6hOx5bIUwyG2uO3YZ3EZeQ1GD2hyCXoNcNFSFqVpxeYEqgyXUZYl7ISWX+wXR 6eyMNOZ2DEb8ejiHAjN+nzWotU6wvLpxlGTInPdUBme74OZVwNwE9oqSBgvLniIZBCGjKyBWC Np+qwKFAJHubkwk97Sf7IsgA3u6yFRUpDt5sEQ7ogULf1lTMZbLMKVy7lZTSXzgKAurjE6x68 tyJYaWJa5zSNt2MqoIkbnobmE+nqMVsoTMCHNg8MKx1ao0Vn0Fc0YVmZD72UKjsWBYIplTBlL 02UTsYmaRwQ4TEKSobZ31JObjf4dgG6okF58BDD/wiVS5lFO2TI08BXSAGarshOiqwsT5ttKk 968Ts3EW+sE2nuc91hNwB+SemX1sZLXPr7onTQJPS1bHRSsPLrDSJRuQAPTOin8Bp3wwhLAXB +18KSDIDfeY/Dw5rhl1HdNjBRzE1skCwJMckxX4FbQuS0MOtfSALpdEsFooJ3tYRHtbol5kTQ Sr4xoSidycfZlqhTNUDHWdhlmWVjnuAoxoFQa3HPfL+H1mp1i9SLoCdhiA2A44Ti1wtmDIKpe FfZYaAA8Ze6byo3G/qFZfQZ3ofaLNiua70ib4HpykbDEdRdF5V/nv4l4eNaqmnqu9V/YYWiDq xMMAhLEuH9fjo243TpiV6UcFxSlRS88uQuoycyFLEI0na1zXpS8gJHcXQ4vNLGgldhOj+/Dwa A3Ybu6Ij9ngrwfLe/dl/YpQxSWWCjz5L9d+G5L9TBpeILPE6zIAKWkeMVoy/Hbt3ziECQL24y Ji6nlr8+L0QjnnqmcfweO9rv8/ff1z/98aITg2LutYZ8LiBCvN32yXeyTq Received-SPF: pass client-ip=212.227.15.14; envelope-from=jakob.kirsch@web.de; helo=mout.web.de X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Reply-to: Jakob Kirsch <jakob.kirsch@web.de> X-ACL-Warn: , Jakob Kirsch via Guix-patches <guix-patches@gnu.org> From: Jakob Kirsch via Guix-patches via <guix-patches@gnu.org> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#76728] gnu: avogadro2: fix open babel input
|
|
Commit Message
Jakob Kirsch
March 4, 2025, 12:47 a.m. UTC
avogadro2 needs open babel at runtime so we should add this to the propagated inputs.
From b353ae32e3b160b47ae1b34fe65e79b141caf05f Mon Sep 17 00:00:00 2001
Message-ID: <b353ae32e3b160b47ae1b34fe65e79b141caf05f.1741049088.git.jakob.kirsch@web.de>
From: Jakob Kirsch <jakob.kirsch@web.de>
Date: Tue, 4 Mar 2025 01:44:43 +0100
Subject: [PATCH v1] gnu: avogadro2: Update to 1.93.0.
* gnu/packages/chemistry.scm (avogadro2): Update to 1.93.0.
[propagated-inputs]: Add openbabel.
Change-Id: Ia7f02e66d9caced61a6a206076513806bb7b29a9
---
gnu/packages/chemistry.scm | 2 ++
1 file changed, 2 insertions(+)
base-commit: 72923a75af53a819f2be9dc4ae3c096aa3147d3f
--
2.48.1
Comments
Jakob Kirsch via Guix-patches via <guix-patches@gnu.org> writes: > avogadro2 needs open babel at runtime so we should add this to the propagated inputs. > > [2. text/plain; v1-0001-gnu-avogadro2-Update-to-1.93.0.patch]... I think wrapper might be better, if it's just an application.
This is still WIP as some things are broken like: * icons don't render * openbabel optimization is broken with DNA
Currently working on it, it's still broken for some reason.
Hi, As a user of the avogadro2 program, would you say that a regular user would use openbabel as an extra program anyway? (or be aware of it) That is, is openbabel "inside the avogadro2 black box" or "outside the avogadro2 black box as its own black box" ? For what it's worth, I've checked the avogadro2 source code, and they set the variable OBABEL_EXE to where the program "obabel" is. After that, they set BABEL_DIR relative to that, and finally they set ob_plugins to refer to some .so files within $BABEL_DIR/lib, and then: install_qt5_executable(${exe} "${plugins}" "${ob_plugins}" "${dirs}" "") So for me as not-a-user-of-avogadro2 it seems like openbabel should be inside the black box of avogadro2? What do you think?
Hello, this somehow does not pass the hurdle of being picked up by QA, so I ended up going through the patches manually. I have added openbabel as an explicit input to avogadro2; I am surprised it can be referenced without this... Danny, I do not quite get what you mean with the "blackbox" comment. I have pushed the patches as they are; please feel free to open a new issue to improve the packages or correct anything I may have broken. Thanks, Andreas
diff --git a/gnu/packages/chemistry.scm b/gnu/packages/chemistry.scm index bd27bfad7a..46728bb407 100644 --- a/gnu/packages/chemistry.scm +++ b/gnu/packages/chemistry.scm @@ -130,6 +130,8 @@ (define-public avogadro2 (list eigen pkg-config)) (inputs (list avogadrolibs hdf5 molequeue qtbase-5)) + (propagated-inputs + (list openbabel)) ;; TODO: Enable tests with "-DENABLE_TESTING" configure flag. (arguments '(#:tests? #f))