From patchwork Tue Aug 9 13:40:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: vicvbcun X-Patchwork-Id: 41431 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 03F9527BBEA; Tue, 9 Aug 2022 14:42:15 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 5C18427BBE9 for ; Tue, 9 Aug 2022 14:42:14 +0100 (BST) Received: from localhost ([::1]:41596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLPUr-0006iU-I4 for patchwork@mira.cbaines.net; Tue, 09 Aug 2022 09:42:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLPUh-0006gg-0r for guix-patches@gnu.org; Tue, 09 Aug 2022 09:42:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLPUg-0002jj-OH for guix-patches@gnu.org; Tue, 09 Aug 2022 09:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLPUg-00012z-I3 for guix-patches@gnu.org; Tue, 09 Aug 2022 09:42:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56729] [RFC PATCH 00/10] Add sagemath. Resent-From: vicvbcun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 09 Aug 2022 13:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56729 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andreas Enge Cc: Guillaume Le Vaillant , Ludovic =?utf-8?q?Court=C3=A8s?= , 56729@debbugs.gnu.org Received: via spool by 56729-submit@debbugs.gnu.org id=B56729.16600524673964 (code B ref 56729); Tue, 09 Aug 2022 13:42:02 +0000 Received: (at 56729) by debbugs.gnu.org; 9 Aug 2022 13:41:07 +0000 Received: from localhost ([127.0.0.1]:42902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLPTm-00011r-MT for submit@debbugs.gnu.org; Tue, 09 Aug 2022 09:41:07 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([85.215.255.22]:43797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLPTi-00011S-Qu for 56729@debbugs.gnu.org; Tue, 09 Aug 2022 09:41:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1660052454; s=strato-dkim-0002; d=ikherbers.com; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=0QBp95VmRhN5fBqtHlpj8XTIeoySISslLF0c4eLYhAQ=; b=FC0IjOouNY97eHR3s5YtcGzY67tg7RPxDedPAOwuAEJR23FvAIn0orZKAlIza/q9Gj IMNtCpkFa48I+CktkiqQy3PUiXI9r023c1/0Kz8YYMmzpC5rVfrpngd63JfjTXYHrgSZ dFgdWAQRPEfn0GoNE3SmWSsjoHLJ4U2yQS6x9RgrZ51qrVEM0tGANsCB9W3v/O18uZJx I9wO0IZhKA9IiHr+1ijuB6N/1fEsrOnfaALdRaQWCbQQKxvKtkEnPv8ZbQiAjpwhDgLs 95tXNU3dKwxZA+NGNnALk2JtmG2ZDAf+aj74KzIId5b8mIyQ0256mMp6QFp3YWIC/g91 Wbeg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":IUwNfkitaf3qOWm2b/jA5tveVwUUcwH3PkiYp6DPxTDDEo4xO9ymAEzKSWlvmNAhIG6s" X-RZG-CLASS-ID: mo00 Received: from lambda.localdomain by smtp.strato.de (RZmta 47.47.0 DYNA|AUTH) with ESMTPSA id 0cac6cy79DersVB (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 9 Aug 2022 15:40:53 +0200 (CEST) Date: Tue, 9 Aug 2022 15:40:53 +0200 From: vicvbcun Message-ID: Mail-Followup-To: Andreas Enge , Ludovic =?utf-8?q?Court?= =?utf-8?q?=C3=A8s?= , 56729@debbugs.gnu.org, Guillaume Le Vaillant References: <87y1w81flc.fsf@gnu.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches On 2022-08-09T12:47:27+0200, Andreas Enge wrote: > thanks for the update! I just pushed an update of maxima (and wxmaxima), but > without your addition of ecl. Is there a good reason for this? In any case, > this should be done in a separate commit, since it is not required for the > update. For the record, I also tried to compile with gcl, but this still > failed. SageMath requires the FASL library? (I only know scheme) `maxima.fas'. But it is only built when using ecl (See upstream here [0]). I don't know if we need both sbcl and ecl. Arch uses both and puts the lib/.../binary-* directories in separate packages[1], so maybe we could use different outputs? Anyway, I have attached an rebased commit that adds ecl. > > > Concerning sagemath itself, below is my very old version of an attempt at > > > packaging the library. Some things look reassuringly similar, my handling > > > of the number of cores is less nice, but I do delete the bundled packages. > > The `upstream' directory only seems to exist in the published tarball. > > So this should be no problem if we build from git. > > Ah, interesting. Which one should we do? I personally tend to prefer tarballs > (as the official distribution mechanism of the project). Recently there has > been a preference in the Guix project for git repositories when autotools > are involved, as they make it possible to recreate the configure scripts > from their source. But since this is not the case here, the argument does > not hold. The sage tarball is 1.35 GiB while the repository is only about 440 MiB. That seems quite convincing on its own. [0]: https://sourceforge.net/p/maxima/patches/80/ [1]: https://github.com/archlinux/svntogit-packages/blob/packages/maxima/trunk/PKGBUILD From cb877ee5091d801e08654ac55adaab1b5edfec91 Mon Sep 17 00:00:00 2001 Message-Id: From: vicvbcun Date: Sat, 6 Aug 2022 18:00:19 +0200 Subject: [PATCH] gnu: maxima: Build with ecl and install maxima.fas. The eventual sagemath package requires maxima.fas, which is only build with ecl. * gnu/packages/maths.scm (maxima)[inputs]: Add ecl. [configure-flags]: Build with ecl. [install]: Install maxima.fas. --- gnu/packages/maths.scm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) base-commit: 0d9eef0a06ffcb6a0f66d272ea036597b521ffb6 diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index e32a71100e..b250649a45 100644 --- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -4357,6 +4357,7 @@ (define-public maxima (build-system gnu-build-system) (inputs `(("bash" ,bash-minimal) + ("ecl" ,ecl) ("gnuplot" ,gnuplot) ;for plots ("sbcl" ,sbcl) ("sed" ,sed) @@ -4365,7 +4366,8 @@ (define-public maxima (list texinfo perl python)) (arguments `(#:configure-flags - ,#~(list "--enable-sbcl" + ,#~(list "--enable-sbcl" "--enable-ecl" + (string-append "--with-ecl=" #$ecl "/bin/ecl") (string-append "--with-sbcl=" #$sbcl "/bin/sbcl") (string-append "--with-posix-shell=" #$bash-minimal "/bin/sh") (string-append "--with-wish=" #$tk "/bin/wish" @@ -4409,6 +4411,10 @@ (define-public maxima "--lisp=sbcl " "--batch-string=\"run_testsuite();\" " "| grep -q \"No unexpected errors found\"")))) + (add-after 'install 'install-fas + (lambda* (#:key outputs #:allow-other-keys) + (install-file "src/binary-ecl/maxima.fas" + (string-append (assoc-ref outputs "out") "/lib/maxima/" ,version "/binary-ecl")))) ;; Make sure the doc and emacs files are found in the ;; standard location. Also configure maxima to find gnuplot ;; without having it on the PATH.