From patchwork Tue Jan 25 10:49:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Efraim Flashner X-Patchwork-Id: 36797 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 0919D27BBEA; Tue, 25 Jan 2022 10:56:47 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 80C0527BBE9 for ; Tue, 25 Jan 2022 10:56:46 +0000 (GMT) Received: from localhost ([::1]:40696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCJVD-0004de-Ks for patchwork@mira.cbaines.net; Tue, 25 Jan 2022 05:56:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCJQH-00087T-Hg for guix-patches@gnu.org; Tue, 25 Jan 2022 05:51:39 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nCJPh-0001Yi-Lt for guix-patches@gnu.org; Tue, 25 Jan 2022 05:51:36 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nCJPh-00045K-Ly for guix-patches@gnu.org; Tue, 25 Jan 2022 05:51:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#50663] Add Mycroft - Voice Assistant Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 25 Jan 2022 10:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50663 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 50663@debbugs.gnu.org, phodina@protonmail.com Received: via spool by 50663-submit@debbugs.gnu.org id=B50663.164310781515642 (code B ref 50663); Tue, 25 Jan 2022 10:51:01 +0000 Received: (at 50663) by debbugs.gnu.org; 25 Jan 2022 10:50:15 +0000 Received: from localhost ([127.0.0.1]:47013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCJOw-00044E-Rh for submit@debbugs.gnu.org; Tue, 25 Jan 2022 05:50:15 -0500 Received: from flashner.co.il ([178.62.234.194]:45856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nCJOu-00043t-ID for 50663@debbugs.gnu.org; Tue, 25 Jan 2022 05:50:13 -0500 Received: from localhost (unknown [31.210.177.79]) by flashner.co.il (Postfix) with ESMTPSA id 2B0AB40455; Tue, 25 Jan 2022 10:50:06 +0000 (UTC) Date: Tue, 25 Jan 2022 12:49:33 +0200 From: Efraim Flashner Message-ID: Mail-Followup-To: Efraim Flashner , Nicolas Goaziou , 50663@debbugs.gnu.org, phodina@protonmail.com References: <87r18wbvnq.fsf@nicolasgoaziou.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87r18wbvnq.fsf@nicolasgoaziou.fr> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches On Mon, Jan 24, 2022 at 11:45:13PM +0100, Nicolas Goaziou wrote: > Hello, > > phodina via Guix-patches via writes: > > > The aim of this patch set is to bring in the MyCroft - private and > > open Voice Assistant. > > Thank you. > > I fixed some descriptions, removed labels from inputs, fixed compilation > with GCC 10 (for Mimic). Then I tried to apply the patch set. Alas > Mycroft core fails to build. You may want to have a look at it. > > I'm sending back the updated patches to you, if that helps. > > Regards, > -- > Nicolas Goaziou I made some changes to python-mycroft-core but I couldn't get it to pass the sanity-check or the test suite. I've attached my changes. Also make sure you sort the inputs alphabetically, I found at least a duplicate python-pyxdg. Also some of the patches include a line or two of unrelated indentation changes in other packages. diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 1834152c3c..b9c4529cd5 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -21986,63 +21986,61 @@ (define-public python-mycroft-core "02r0vxw0hsihnvviwn4fyspwky3kwq42f9z455q1s70k0snzhb28")))) (build-system python-build-system) (arguments - `(#:phases + `(#:tests? #f ; TODO + #:phases (modify-phases %standard-phases (add-after 'unpack 'patch-requirements (lambda* (#:key inputs #:allow-other-keys) - ;; Use newer version of pkg + ;; Use newer version of packages. + (setenv "MYCROFT_LOOSE_REQUIREMENTS" "1") (substitute* "requirements/requirements.txt" - (("mycroft-messagebus-client==") "mycroft-messagebus-client>=") - (("tornado==") "tornado>=") - (("pyserial==") "pyserial>=") - (("psutil==") "psutil>=") - (("padaos==") "padaos>=") - (("precise-runner==") "precise-runner>=") - (("pocketsphinx==") "pocketsphinx>=") - (("python-dateutil==") "python-dateutil>=") - (("fasteners==") "fasteners>=") - (("requests-futures==") "requests-futures>=") - (("pillow==") "pillow>=") - (("PyYAML==5.4") "PyYAML>=5.3.1") - (("pyxdg==") "pyxdg>=") (("requests>=2.20.0,<2.26.0") "requests>=2.20.0")))) + (replace 'sanity-check + (lambda args + ;(setenv "PYTHONPATH" + ; (string-append "./build/lib:" + ; (or (getenv "PYTHONPATH") + ; ""))) + (apply (assoc-ref %standard-phases 'sanity-check) args))) (replace 'check - (lambda* (#:key tests? #:allow-other-keys) + (lambda* (#:key tests? #:allow-other-keys #:rest args) (when tests? (setenv "PYTHONPATH" (string-append "./build/lib:" (or (getenv "PYTHONPATH") - ""))))))))) + ""))) + (apply (assoc-ref %standard-phases 'check) args))))))) (inputs (list mycroft-mimic pocketsphinx)) (propagated-inputs - (list python-fasteners + (list python-adapt-parser + python-dateutil + python-fann2 + python-fasteners + python-gtts python-inflection - python-pyxdg + python-lingua-franca + python-msk + python-msm python-mycroft-messagebus-client - python-psutil - python-tornado-6 - python-petact - python-precise-runner python-padaos - python-speech-recognition python-padatious - python-msk + python-petact python-pillow - python-gtts - python-requests-futures - python-pyserial python-pocketsphinx - python-adapt-parser - python-lingua-franca - python-pyyaml - python-fasteners + python-psutil + python-pyaudio python-pyee - python-psutil - python-fann2 python-pyxdg - python-websocket-client + python-pyyaml + python-pyserial + python-precise-runner python-requests - python-requests-futures)) + python-requests-futures + python-speech-recognition + python-tornado-6 + python-websocket-client)) + (native-inputs + (list python-pytest)) (home-page "https://github.com/HelloChatterbox/HolmesIV") (synopsis "Mycroft Core, the Mycroft Artificial Intelligence platform") (description "This module provides a hackable open source voice assistant - Mycroft")