mbox

[bug#46717,0/2] r-haven: Unvendor readstat

Message ID YDT9bv1yvXluUI6Z@noor.fritz.box
Headers show

Message

Lars-Dominik Braun Feb. 23, 2021, 1:04 p.m. UTC 
I rebuilt all packages depending on r-haven and tried loading example
files using r-haven’s read_* functions. There are no apparent
modifications to the vendored source, based on a look at
https://github.com/tidyverse/haven/commits/v2.3.1/src/readstat
but it’s not quite clear which version they are using. Probably a git
snapshot.

Lars-Dominik Braun (2):
  gnu: Add readstat.
  gnu: r-haven: Unvendor readstat.

 gnu/packages/cran.scm       | 19 +++++++++++++++++--
 gnu/packages/statistics.scm | 28 ++++++++++++++++++++++++++++
 2 files changed, 45 insertions(+), 2 deletions(-)

Comments

Ludovic Courtès March 2, 2021, 7:32 p.m. UTC | #1 
Hi,

Lars-Dominik Braun <lars@6xq.net> skribis:

> I rebuilt all packages depending on r-haven and tried loading example
> files using r-haven’s read_* functions. There are no apparent
> modifications to the vendored source, based on a look at
> https://github.com/tidyverse/haven/commits/v2.3.1/src/readstat
> but it’s not quite clear which version they are using. Probably a git
> snapshot.
>
> Lars-Dominik Braun (2):
>   gnu: Add readstat.
>   gnu: r-haven: Unvendor readstat.

Applied both, thanks!

Ludo’.
Ludovic Courtès March 5, 2021, 11:57 a.m. UTC | #2 
Hi,

Lars-Dominik Braun <lars@6xq.net> skribis:

> I rebuilt all packages depending on r-haven and tried loading example
> files using r-haven’s read_* functions. There are no apparent
> modifications to the vendored source, based on a look at
> https://github.com/tidyverse/haven/commits/v2.3.1/src/readstat
> but it’s not quite clear which version they are using. Probably a git
> snapshot.
>
> Lars-Dominik Braun (2):
>   gnu: Add readstat.
>   gnu: r-haven: Unvendor readstat.

LGTM!  Pushed a couple of days ago as
2075b83b2dbd9896e2e69070e3363f3d43fbe133.

Ludo’.