From patchwork Tue Dec 27 21:15:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: phodina X-Patchwork-Id: 45604 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id C077627BBED; Tue, 27 Dec 2022 21:17:34 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id D222F27BBE9 for ; Tue, 27 Dec 2022 21:17:31 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAHJr-0008S9-Us; Tue, 27 Dec 2022 16:17:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAHJm-0008Rf-8G for guix-patches@gnu.org; Tue, 27 Dec 2022 16:17:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAHJl-00024v-V5 for guix-patches@gnu.org; Tue, 27 Dec 2022 16:17:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pAHJl-0007cv-PQ for guix-patches@gnu.org; Tue, 27 Dec 2022 16:17:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#57608] Upstreaming KDE Plasma and rest of packages Resent-From: phodina Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 27 Dec 2022 21:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57608 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Marius Bakke Cc: maxim.cournoyer@gmail.com, ludo@gnu.org, mail@brendan.scot, leo@famulari.name, marekpasnikowski@protonmail.com, h.goebel@crazy-compilers.com, 57608@debbugs.gnu.org Received: via spool by 57608-submit@debbugs.gnu.org id=B57608.167217577029200 (code B ref 57608); Tue, 27 Dec 2022 21:17:01 +0000 Received: (at 57608) by debbugs.gnu.org; 27 Dec 2022 21:16:10 +0000 Received: from localhost ([127.0.0.1]:56581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAHIw-0007au-72 for submit@debbugs.gnu.org; Tue, 27 Dec 2022 16:16:10 -0500 Received: from mail-40131.protonmail.ch ([185.70.40.131]:21529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAHIs-0007a6-Hn for 57608@debbugs.gnu.org; Tue, 27 Dec 2022 16:16:08 -0500 Date: Tue, 27 Dec 2022 21:15:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1672175760; x=1672434960; bh=uXNgkLtr+yB90tFBLB/bfpoGDobug40wkJV9cdHvOPc=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=tfQ3ZgTePASQ8EDxXw03nucBWLTwzRNPHWqLOPJ7TJwPtkWpUTqoOyLUBhOMsO2d1 pwqHBu09P8SgW0e/MVLd9ClScfCPlQtkrGsR9RI80nbQ6Stp5QFzgM2pCUY4hopCke 6yb+Gjd47skncX/Ior761KHkA3SEuSeuS4bGmusPsMi87HO4KCc/GodhFE7ALTuVoB sPpzwCASEi/YMnrXvrC6bn5++/eXb4MyQYY2+cJhNWS/QXk3pONpLS6c8Ymhn5YBoB XkrgBqrKzrl94BUk2G0jkd3KZsrV2rb+jL9qBFM6h1v9Wkpi7q+ElIoT4qtIC9df0y Qu2idR6jgfy6Q== Message-ID: In-Reply-To: <87wn7nz28p.fsf@gnu.org> References: <_9i_X2elmnmVduuEMWiqx4qwh8Jlu6wffrzRfrk0M2boZ-SINJbuBmUDidz8oMTRJhaeeNmsNGvDgNTbPRLyCy1EcDAYVk6nwNlliDDWy6M=@protonmail.com> <87zgckypvd.fsf@gnu.org> <87wn7nz28p.fsf@gnu.org> Feedback-ID: 14143818:user:proton MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: phodina X-ACL-Warn: , phodina via Guix-patches X-Patchwork-Original-From: phodina via Guix-patches via From: phodina Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi Marius, Sent with Proton Mail secure email. ------- Original Message ------- On Tuesday, November 22nd, 2022 at 11:56 AM, Marius Bakke wrote: > > Is this issue somewhere described? I've lately used more tarballs to git download on other packages. > > Is the issue connected with any Gitlab/Forge or just the KDE and the release scripts? > > > We have this problem with all the forges. There have been many-a bug > report about it, and the linter also warns about it (apparently for > GitHub only, that could be improved). Thanks for the explanation. I'll keep that in mind. > > > > * dropped the !! commits > > > * Minor tweaks to synopses and descriptions > > > > My apologies as I noticed there were few packages with wrong license or missing description. > > > Oh, I did not license audit these packages as I assumed all the KDE > stuffs were using the same license. Can you submit patches to update > the licenses? I've tried to follow the licenses as submitted by the individual packages. I'm currently in process of double checking. I found out that the kinfocenter and systemsettings were not behaving correctly - no widgets were rendered due to missing QML modules. The attached patch solves this. I have some additional patches for kwin and plasma-workspace but they are not yet enough to launch KDE desktop. Also one "small" problem. As I switched to sway to test apps running under Wayland I noticed a pretty important issue. None of the programs launched were running under Wayland - they ran in XWayland. Is this known issue? Do we need to modify the qt-build-system or cmake-build-system? Or shall we add wrap phase for each package to add the correct path for qtwayland package in env variable QT_QPA_PLATFORM_PLUGIN_PATH? ``` $ echo $XDG_SESSION_TYPE wayland $ konsole qt.qpa.plugin: Could not find the Qt platform plugin "wayland" in "" ``` ---- Petr From 063ea2790d55780943a0bd07be64421106b22d4d Mon Sep 17 00:00:00 2001 From: Petr Hodina Date: Mon, 26 Dec 2022 10:50:19 +0100 Subject: [PATCH] gnu: system-settings: Add phase 'wrap-executable and additional inputs. * gnu/packages/kde-plasma.scm (system-settings)[inputs]: Add qtquickcontrols-5. [arguments]: Add phase 'wrap-executable. [inputs]: Add kcoreaddons, kdeclarative, knewstuff, kuserfeedback, qtgraphicaleffects and qtquickcontrols2-5. diff --git a/gnu/packages/kde-plasma.scm b/gnu/packages/kde-plasma.scm index 89405bacaa..157ac3e1dd 100644 --- a/gnu/packages/kde-plasma.scm +++ b/gnu/packages/kde-plasma.scm @@ -2495,9 +2495,34 @@ (define-public system-settings (base32 "0n7mf6ygi8fgn1m6pk2fadnqj1h58mxqni3h19xbi373wfypq5fl")))) (build-system qt-build-system) + (arguments + (list #:phases #~(modify-phases %standard-phases + (add-after 'install 'wrap-executable + (lambda* (#:key inputs #:allow-other-keys) + (let ((out #$output) + (qml "/lib/qt5/qml")) + (wrap-program (string-append out + "/bin/systemsettings5") + `("QML2_IMPORT_PATH" ":" prefix + (,(string-append out qml) + ,@(map (lambda (i) + (string-append + (assoc-ref inputs i) qml)) + '("kirigami" + "kcoreaddons" + "kdeclarative" + "knewstuff" + "kuserfeedback" + "plasma-workspace" + "qtdeclarative" + "qtgraphicaleffects" + "qtquickcontrols" + "qtquickcontrols2"))))))))))) (native-inputs (list extra-cmake-modules)) (inputs (list kauth kcrash + kcoreaddons + kdeclarative kitemviews kitemmodels kcmutils @@ -2511,14 +2536,19 @@ (define-public system-settings kdbusaddons kconfig kpackage + knewstuff kactivities kactivities-stats kguiaddons kirigami knotifications krunner + kuserfeedback plasma-workspace - qtdeclarative-5)) + qtdeclarative-5 + qtgraphicaleffects + qtquickcontrols-5 + qtquickcontrols2-5)) (synopsis "Control center to configure Plasma Desktop") (description "This package provides configuration UI for Plasma Desktop.") (home-page "https://invent.kde.org/plasma/systemsettings") -- 2.38.1