From patchwork Tue Jan 4 22:24:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Kehayias X-Patchwork-Id: 35955 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 74F4827BBEA; Tue, 4 Jan 2022 22:25:16 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 3E43827BBE9 for ; Tue, 4 Jan 2022 22:25:16 +0000 (GMT) Received: from localhost ([::1]:33036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n4sF1-00089c-Ei for patchwork@mira.cbaines.net; Tue, 04 Jan 2022 17:25:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n4sEp-00088W-21 for guix-patches@gnu.org; Tue, 04 Jan 2022 17:25:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55669) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n4sEo-00024F-Nx for guix-patches@gnu.org; Tue, 04 Jan 2022 17:25:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n4sEo-000396-KK for guix-patches@gnu.org; Tue, 04 Jan 2022 17:25:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53015] [PATCH 2/4] gnu: spdlog: Build with '-fpic'. References: In-Reply-To: Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 04 Jan 2022 22:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53015 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "53015@debbugs.gnu.org" <53015@debbugs.gnu.org> Received: via spool by 53015-submit@debbugs.gnu.org id=B53015.164133508312054 (code B ref 53015); Tue, 04 Jan 2022 22:25:02 +0000 Received: (at 53015) by debbugs.gnu.org; 4 Jan 2022 22:24:43 +0000 Received: from localhost ([127.0.0.1]:38981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4sEU-00038M-OJ for submit@debbugs.gnu.org; Tue, 04 Jan 2022 17:24:43 -0500 Received: from mail-40134.protonmail.ch ([185.70.40.134]:32853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n4sES-00037x-4A for 53015@debbugs.gnu.org; Tue, 04 Jan 2022 17:24:40 -0500 Date: Tue, 04 Jan 2022 22:24:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail2; t=1641335073; bh=NlTTljiIlCDTZKKzLU2WcGd53vJDHEZbO5M0It42sp0=; h=Date:To:From:Reply-To:Subject:Message-ID:From:To:Cc; b=CEkGNdIjymomturCzmJVr7s0vbNXMMKSFmFg5/8Fz1G3jkGeF9J45RFbXin8kFGBZ 1C+Xd4C8nw5awjzfIKzVjeDu7g3g+ZR0NSJgDFJUYsm0OuZVl+spS5SmNEdmgPPGuL 4UIiZw6qIaHQRK5p0fooAQDQkQP3wupqyEtE9r+mojZquoB8MHbsf191sxLOi/eKvb aizEzrCwh+9oWVOHgqpaB+MK0C9I8iJh22E4WqdSaoBk/WsA7Sqd3iI2Fq6ZMDgZKF Be1dFMbQSv8NrT2BHmJMIUX7MBQUKLxGjCGQoIwRrO2/TMtvAHCLmbRSGiJifNo1UK kbU3mGZQwLfuQ== Message-ID: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches X-Patchwork-Original-From: John Kehayias via Guix-patches via From: John Kehayias X-getmail-retrieved-from-mailbox: Patches Empty Message From 79f30cf17e88ca50fd8444f1ad34ceb795b1d255 Mon Sep 17 00:00:00 2001 From: John Kehayias Date: Tue, 4 Jan 2022 16:41:48 -0500 Subject: [PATCH 2/4] gnu: spdlog: Build with '-fpic'. * gnu/packages/logging.scm (spdlog)[arguments]: Add "-DCMAKE_CXX_FLAGS=-fpic" to #:configure-flags. --- gnu/packages/logging.scm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm index be144e2daa..3c8f67b3ce 100644 --- a/gnu/packages/logging.scm +++ b/gnu/packages/logging.scm @@ -8,6 +8,7 @@ ;;; Copyright © 2019 Meiyo Peng ;;; Copyright © 2020 Marius Bakke ;;; Copyright © 2021 Guillaume Le Vaillant +;;; Copyright © 2022 John Kehayias ;;; ;;; This file is part of GNU Guix. ;;; @@ -207,7 +208,11 @@ (define-public spdlog ;; (gnu packages benchmark) forms a dependency cycle (arguments '(#:configure-flags - (list "-DSPDLOG_BUILD_BENCH=OFF" + ;; Typically this library is meant to be compiled statically, see + ;; https://github.com/gabime/spdlog/wiki/How-to-use-spdlog-in-DLLs + ;; So build with -fpic to allow linking in shared libraries. + (list "-DCMAKE_CXX_FLAGS=-fpic" + "-DSPDLOG_BUILD_BENCH=OFF" "-DSPDLOG_BUILD_TESTS=ON"))) (home-page "https://github.com/gabime/spdlog") (synopsis "Fast C++ logging library") -- 2.34.0