From patchwork Thu Oct 6 01:06:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "J. Sims" X-Patchwork-Id: 43171 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 61E2927BBE9; Thu, 6 Oct 2022 02:07:13 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id D6FD927BBEA for ; Thu, 6 Oct 2022 02:07:10 +0100 (BST) Received: from localhost ([::1]:35190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogFLy-0001Gx-13 for patchwork@mira.cbaines.net; Wed, 05 Oct 2022 21:07:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogFLr-0001Gp-3X for guix-patches@gnu.org; Wed, 05 Oct 2022 21:07:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogFLq-0003Zv-S8 for guix-patches@gnu.org; Wed, 05 Oct 2022 21:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ogFLq-0003W3-Ew for guix-patches@gnu.org; Wed, 05 Oct 2022 21:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58236] [PATCH] gnu: genie: Add genie. Resent-From: "J. Sims" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 Oct 2022 01:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58236 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , "58236@debbugs.gnu.org" <58236@debbugs.gnu.org> Received: via spool by 58236-submit@debbugs.gnu.org id=B58236.166501842113507 (code B ref 58236); Thu, 06 Oct 2022 01:07:02 +0000 Received: (at 58236) by debbugs.gnu.org; 6 Oct 2022 01:07:01 +0000 Received: from localhost ([127.0.0.1]:58373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogFLl-0003Vk-U7 for submit@debbugs.gnu.org; Wed, 05 Oct 2022 21:07:01 -0400 Received: from mail-4319.protonmail.ch ([185.70.43.19]:44915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogFLh-0003VT-Gr for 58236@debbugs.gnu.org; Wed, 05 Oct 2022 21:06:57 -0400 Date: Thu, 06 Oct 2022 01:06:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1665018406; x=1665277606; bh=wz/ndJjqwHAbR4PQoiBtv+eL2yuAet0IIZgOfTrX0sw=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=UZzm4TIXfJJStk1/iL33qOP53Xe7KHZbg5O2HwRhI8kbi3SJGNF0QUzbbyQr0gXK9 8dM2K7fJbbAPqBlUpf7vcEKX/UR60TD3jE6kiPHX7fDHjL86rV+IovTkiBEhixMecc ZXzGZKQGVwhMPE8jCGyQWrZ9nf8r4CFJjsvaS/Rl+nwKtqh4DitY6pGZyk9mD1v/gd eB+/QZtI/2aUEuDT4V4d6AXxuFqpyXbrrAbfgNGBN9KbKb6Ef+nDDRMoKfriXaUIIF La5A/l9EbqJ4736abCtFEDVe0Uralx8Sd20ocIGCSfF6DI3DQX4nbEzDcGMWwdjGFh FABKyVhq4pTTA== Message-ID: In-Reply-To: <77199596cf765478acdd1f7018107acc5e040d4e.camel@ist.tugraz.at> References: <4U8NHZEnxqwJYZmqbBYDduYPojljirob5Ax9z0XH0A1W-PPzFbyPbLlp1ncKs-H3CsRFZ52plHVTtoqpvrKaciBg1WkYdheAON-fY93Ui8U=@protonmail.com> <3b2b96fccc4cc1df3dc34963f2c7ce8eff04f857.camel@ist.tugraz.at> <77199596cf765478acdd1f7018107acc5e040d4e.camel@ist.tugraz.at> Feedback-ID: 12133992:user:proton MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: "J. Sims" X-ACL-Warn: , "J. Sims via Guix-patches" X-Patchwork-Original-From: "J. Sims via Guix-patches" via From: "J. Sims" X-getmail-retrieved-from-mailbox: Patches On Wednesday, October 5th, 2022 at 05:34, Liliana Marie Prikler wrote: > Am Dienstag, dem 04.10.2022 um 19:37 +0000 schrieb J. Sims: > > > (define-public genie > > + (let ((commit "b139103697bbb62db895e4cc7bfe202bcff4ff25") > > + (version "1167") > > + (revision "0")) > > Do not let-bind version. > > > + (package > > + (name "genie") > > + (version (git-version version revision commit)) > > + (home-page "https://github.com/bkaradzic/genie") > > home-page comes before synopsis and description... > > > + (source (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url home-page) > > + (commit commit))) > > Don't pull it up so that you can "save" the url argument. Type url out > explicitly. > > > + (file-name (git-file-name name version)) > > + (sha256 > > + (base32 > > + > > "16plshzkyjjzpfcxnwjskrs7i4gg0qn92h2k0rbfl4a79fgmwvwv")))) > > + (build-system gnu-build-system) > > + (arguments > > + (list #:phases #~(modify-phases %standard-phases > > + (delete 'configure) > > + (replace 'install > > + (lambda _ > > + (install-file "bin/linux/genie" > > + (string-append #$output > > "/bin"))))) > > Prefer saving horizontal space over vertical space. > > > + #:tests? #f)) ;only manual tests > > When it comes to software testing, there is no sequence of instructions > that only a human can carry out. Tests either exist or they don't and > in the case of GENie there at least formally exists a directory for > them. > > > + (synopsis "Project generator tool") > > Note that tool is superfluous here. > > > + (description > > + "GENie is project generator tool. It generates projects from > > +Lua scripts, making applying the same settings for multiple projects > > easy. It > > I'd simply write "GENie generates projects from Lua scripts, making it > easy to apply the same settings to multiple projects." > > > +supports generating projects using GNU Makefiles; JSON Compilation > > Database; > > +Visual Studio 2010, 2012, 2013, 2015, 2017, and 2019; XCode; and > > experimentally > > +supports Ninja.") > > We're not going to use proprietary software on our FSDG-compliant > system, so it's only Makefiles, JSON compilation databases and > experimental Ninja. > > > + (license license:bsd-3)))) > > > Cheers This patch should incorporate all above comments. If there are further questions about tests: https://github.com/bkaradzic/GENie/issues/545#issuecomment-1267152313 -Juli From 7a1d86dbe8b07964661160d5b86e9cd92790cf1e Mon Sep 17 00:00:00 2001 From: "J. Sims" Date: Wed, 5 Oct 2022 19:37:11 -0500 Subject: [PATCH] gnu: genie: Add genie. * gnu/packages/build-tools.scm (genie): Add genie. --- gnu/packages/build-tools.scm | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-tools.scm index 84a62d0fd6..3c8b1dd9ee 100644 --- a/gnu/packages/build-tools.scm +++ b/gnu/packages/build-tools.scm @@ -14,6 +14,7 @@ ;;; Copyright © 2020 Efraim Flashner ;;; Copyright © 2021 qblade ;;; Copyright © 2021 Maxim Cournoyer +;;; Copyright © 2022 Juliana Sims ;;; ;;; This file is part of GNU Guix. ;;; @@ -763,3 +764,35 @@ (define-public build @item Extensible language/compiler framework. @end itemize") (license license:gpl2+))) + +(define-public genie + (let ((commit "b139103697bbb62db895e4cc7bfe202bcff4ff25") + (revision "0")) + (package + (name "genie") + (version (git-version "1167" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/bkaradzic/genie") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "16plshzkyjjzpfcxnwjskrs7i4gg0qn92h2k0rbfl4a79fgmwvwv")))) + (build-system gnu-build-system) + (arguments + (list #:phases #~(modify-phases %standard-phases + (delete 'configure) + (replace 'install + (lambda _ + (install-file "bin/linux/genie" + (string-append #$output "/bin"))))) + #:tests? #f)) ;no tests + (home-page "https://github.com/bkaradzic/genie") + (synopsis "Project generator") + (description + "GENie generates projects from Lua scripts, making it easy to apply the +same settings to multiple projects. It supports generating projects using GNU +Makefiles, JSON Compilation Database, and experimentally Ninja.") + (license license:bsd-3)))) base-commit: 43b8df4bece2a207018dc0fedc44d3d188d2d0f0 -- 2.34.1