diff mbox series

[bug#55531] gnu: dumb: Fix build.

Message ID PU1PR01MB215574CCEB0D80DB82FF5D3C8DD39@PU1PR01MB2155.apcprd01.prod.exchangelabs.com
State Accepted
Headers show
Series [bug#55531] gnu: dumb: Fix build. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Foo Chuan Wei May 20, 2022, 3:55 a.m. UTC 
* gnu/packages/music.scm (dumb, dumb-allegro4): Fix failing build of "dumb"
  caused by missing allegro-4 dependency.
---
This patch fixes the failing build of the "dumb" package by removing the
need to have allegro-4. I am not sure why Guix needs both "dumb" and
"dumb-allegro4". By default, dumb requires allegro-4.


 gnu/packages/music.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


base-commit: cf17cbbc1b16dd15c8ec2e637d240de7ae5c3a44

Comments

Ludovic Courtès May 24, 2022, 2:54 p.m. UTC | #1 
Hi,

Foo Chuan Wei <chuanwei.foo@hotmail.com> skribis:

> * gnu/packages/music.scm (dumb, dumb-allegro4): Fix failing build of "dumb"
>   caused by missing allegro-4 dependency.

Applied, thanks!

Ludo’.

PS: Your MUA wrongfully sets “Mail-Followup-To: guix-patches@gnu.org”.
diff mbox series

Patch

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 210af3b166..bb456abdb1 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -705,7 +705,8 @@  background while you work.")
     (arguments
      '(#:tests? #f ; no check target
        #:configure-flags
-       (list "-DBUILD_SHARED_LIBS=ON"
+       (list "-DBUILD_ALLEGRO4=OFF"
+             "-DBUILD_SHARED_LIBS=ON"
              "-DBUILD_EXAMPLES=OFF")))
     (home-page "https://github.com/kode54/dumb")
     (synopsis "Module audio renderer library")
@@ -729,7 +730,7 @@  settings (aliasing, linear interpolation and cubic interpolation).")
     (arguments
      (substitute-keyword-arguments (package-arguments dumb)
        ((#:configure-flags flags)
-        `(cons "-DBUILD_ALLEGRO4=ON" ,flags))))
+        `(cons "-DBUILD_ALLEGRO4=ON" ,(delete "-DBUILD_ALLEGRO4=OFF" flags)))))
     (inputs
      (list allegro-4))))