From patchwork Sat Jun 29 12:15:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Sergio_Pastor_P=C3=A9rez?= X-Patchwork-Id: 65749 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 37C9627BBE9; Sat, 29 Jun 2024 13:27:28 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id DEFB927BBE2 for ; Sat, 29 Jun 2024 13:27:26 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNXAX-0005gP-6I; Sat, 29 Jun 2024 08:27:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNXAV-0005fu-0k for guix-patches@gnu.org; Sat, 29 Jun 2024 08:27:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNXAU-0008Rd-OP for guix-patches@gnu.org; Sat, 29 Jun 2024 08:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sNXAU-0006Wj-6q; Sat, 29 Jun 2024 08:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#67755] [PATCH v2] gnu: Add imhex. References: In-Reply-To: Resent-From: Sergio Pastor =?utf-8?b?UMOpcmV6?= Original-Sender: "Debbugs-submit" Resent-CC: sergio.pastorperez@outlook.es, guix-patches@gnu.org Resent-Date: Sat, 29 Jun 2024 12:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67755 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67755@debbugs.gnu.org Cc: Sergio Pastor =?utf-8?b?UMOpcmV6?= , Sergio Pastor =?utf-8?b?UMOpcmV6?= X-Debbugs-Original-Xcc: Sergio Pastor =?utf-8?b?UMOpcmV6?= Received: via spool by 67755-submit@debbugs.gnu.org id=B67755.171966398225036 (code B ref 67755); Sat, 29 Jun 2024 12:27:02 +0000 Received: (at 67755) by debbugs.gnu.org; 29 Jun 2024 12:26:22 +0000 Received: from localhost ([127.0.0.1]:37338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNX9q-0006Vk-6J for submit@debbugs.gnu.org; Sat, 29 Jun 2024 08:26:22 -0400 Received: from mail-vi1eur03olkn2043.outbound.protection.outlook.com ([40.92.57.43]:55162 helo=EUR03-VI1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNX9n-0006VT-RY for 67755@debbugs.gnu.org; Sat, 29 Jun 2024 08:26:20 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D611YHKRhAI8IYU8Q+SXcvIrnvpd7IH4OCjBvFlV4iUhRgBZwrnkmyGzhXIl+itIhbbiUpehS2N+LdNv4enVeNdaY/fY5FQvDDBiiiYnvcCt+tl6H0jJRaNbpteBA7Qmy7wI7ouPqmMoDHUVKPrh7qI0NbBL7f8P8N5FZGkO0Ffl/bGo7/EepGmIjgC0eTB712iEeNXrxkM2GLc39o7YYBZxfPYHKkzBh9FQXWCGVqJ5oNjeULOJ73RyRza3Q+WUBiqtlNeUtuh1POgWXYnPvmjv55ISBKNTaLOfHRVbu7mDdkdT+gRMgfgW1IgbMNnbJ84oQqGL6BvQEFjZc1fvHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K8Bjm1NB4DaLEK3z7ETGjw+Wm92P7cb664fkPREc3Lg=; b=byxxbU6JNR+GAA8mkNxkGGprsEfDNgac5ne4K2UB3zxt5Jz4FQ44xOaPyvB4T1iBC5yc7Jd0qUa5kUgfLug5p/PzTH+Fd+cCMB5ab6VnbVNNZh8ZfdwtixJW7RbC05F5mFS6kPw3mupV30rZe0sKvocOJgEU16lkC8mhu/+nGy9n19CGqT/9G0pgA8om6dnwJpfihhx2yWhg+SX/6JastmGzoUbUoDHgLc36wDrdxtN6RKxGzshaHWak655Q4eX9wnRhvD8w492oeWYzkD+hAoGauYDOKi352QPmR9eqg9KoHfb79vLl4D0hjLUMrC5Y/F4hF4vmPYcED5/WW7ClxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=OUTLOOK.ES; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K8Bjm1NB4DaLEK3z7ETGjw+Wm92P7cb664fkPREc3Lg=; b=lnketWFKox3Xv3CAx91X5EukV/oOTHoAUM0TtTArcaJqmDMMx4ZD+HJLWmONiL5ivncGX5BFQggqr25fIxMMjhd8BHAkZxP9gFUk8uehp5GIYjwbiBg8AxFmI+6Arf2jO5kNCJJqV+6v3DoXlqcUFPOdX5IcwsItraw+z4MCVWyrtBwNRhQQtWy+lxXpIy4NPB5t4Xes9UIJgOkAZTDLU2VUaNhErTeAhJid1rRiuamESYNAhWy/QdL/b1OWSVjjZbLB2Jk96Q8/RooPErMCmZsUKN9XlyhCi6wcRn77AH+4X4qBzpsO2g4ezyQXJXUreUkaNdhx0E1ZunuBwVDGbw== Received: from PAXP251MB0348.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:20b::10) by GV1P251MB0859.EURP251.PROD.OUTLOOK.COM (2603:10a6:150:8d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.26; Sat, 29 Jun 2024 12:26:12 +0000 Received: from PAXP251MB0348.EURP251.PROD.OUTLOOK.COM ([fe80::1f4f:1f6b:1817:f03f]) by PAXP251MB0348.EURP251.PROD.OUTLOOK.COM ([fe80::1f4f:1f6b:1817:f03f%7]) with mapi id 15.20.7719.028; Sat, 29 Jun 2024 12:26:12 +0000 From: Sergio Pastor =?utf-8?b?UMOpcmV6?= Date: Sat, 29 Jun 2024 14:15:39 +0200 Message-ID: X-Mailer: git-send-email 2.45.1 X-TMN: [gNe1spCZwF5RD/ULiWmnCUGygJmZavmZ] X-ClientProxiedBy: MA2P292CA0004.ESPP292.PROD.OUTLOOK.COM (2603:10a6:250:1::16) To PAXP251MB0348.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:20b::10) X-Microsoft-Original-Message-ID: <3c5235f1145aef08153440433a66c78c6d4c6302.1719663338.git.sergio.pastorperez@outlook.es> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXP251MB0348:EE_|GV1P251MB0859:EE_ X-MS-Office365-Filtering-Correlation-Id: 56233f61-866e-4067-a38a-08dc9836a952 X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|461199028|3412199025|4302099013|440099028|1602099012|1710799026; X-Microsoft-Antispam-Message-Info: +WumRlTFBf2z51E4KfFy2Kai8qOWdFJF6RUZPexOgqY0XbJfDr2Y0wJaBVejaGps8n8WcxZJpQ/5QK+vJFRsvtlDLh4q4il25YOrTb8WgP1sy/pbmXTBByl1PBiDUcbQCkpwKq74Aip9FiL3glNb15H9oUyqbKvLVE0KazSgonMvJO1N0pUEoQcWWk5nEnlJerJY7zSwe0XKBIuwualB9bJCmjkd0GLYc6fQf8AlQvH06KbtiPvkAHS9MClhrl8WBzDohuvs4z/SzkZPCf5pojjIoo+L55pBbplzjRSUuXMN7HQetg+vm7hYudvfkxCR8X2ju3vvO8JTwCkhDgpg05axm4jda8yvZbaXBUC773pwNIk8EBmt1bY2jSRX4OEN+QOM5mLQAiKhyXiCqRp4FLQ1kz+P7K/GYN5FJqFGsiOM5o6ql2RPb6GlExxFS2dcu/YTqViona8GsFGQ/DGvnMHAZMXh55G7geeAy5yO9bzgI7gnrpt0z+B53Q//KE+ZNr9QSTmY2Jqbo6nzkTX/zEjhjpr8yQwXJ7I6u38DexYdz2Iy0z4j7C7pN5Xh67WEs8qltvVpzS/srX3RP0qZx7lVwsi/P22kWKdwOY39D5Z2kW252oJXQlOg0P0bajbLOiV8jxqAfPJjhwzdvl5eYT+c6IlQaBMh/aZKem6QQEUd+EmxLIB7U9UGai39Jwmu/uc0qz+E/oXr4xkjZ27XXJ0BtZVYc2F7KNBxqqJVed37iiZPLzREPw/UPRyPblPA X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bueQS+eanfG2WFciLS/sayCD7aw5mKMuzf8Iw7FxClqmXAfbU6Cy/JzA6aGgPvHIiAjuZPAn55ji5fK+Rew/ESVCnUDPXWNyeUPgqXT3ugw2ESLYDgR4Ui59atEySlnwmBvdHUmkTMgOd8g4BU2bZfPw/3P2U8wFkRey1fWkUOl82K41kGKT3IrbGWPEeL2LlJgSG7kaBiCBWpMh/z9eDuTofQZ8Ep6zVp6ty+LOM77ma7vkOwYjjux/VKsbjy9X5qbsN7tWF3uah8O451zCx8mzSehBgTB3+if1+uoeJJxFmmlj8zl5FsGlnNaDxJKse6cTsrkRmzzOPMB7n/teOE5JBkYs4tsTLYGZSKtPrUWfPxhm92Gnr0fujpI4cVzO6kpYjxJgiAZiqlytce84CCUC+yiewK+ithoSnyyJA0w2AIMyBCPD8vwAjZsbRrINcID4N9z9OasTKtIqz0IEMHHm/gTbeTNx8ULsF4O2YmkjhC6QHH7zukUWoBUAfbgmlvpzEexYGiQgqAPR3WKEMK02zqha877MH9Sl3oUWHEQ4MNuTvOm9KwX48wN5GaJzB8uLy7Rdn5sHJoly9w1qzRscOkrlSfuZ0VubrrbL7j/6/XDCp7tmBggLnDUl6/ZGJFOrh5TPvnlTmsaUZJqL4/V+oZu3FU01qVrQe8xc0aOl+XILnmM4i0dqUkGE7XQFdAUEZduJWuGlIRuUd3Hsoeo1ggjMdqU+DI4XYJDGVK/4QQ2oRKMWqSe07IMNjSDWS9xJxVwWr3AYGOH2tykF4pneWdsSuuCtOqbNK4DXAJXv9l0NpcnffJWtBdbcEYwZNqtztX017DPTM1FvFaYRLbHC1wkeHNKrsZpzw61mfzCOwGgW22JcHKPYx+kppnJLfE7qaZv38EPR0izJSzYJ432PoMt+xG7shPMw5OOKpxrSc5YypSzao93tPgobdxTE0RQ2UvLhlAuwIlHhHhMxV2oK/yySiEFjuLOjlS0KiuZTwPVV8A+WDrybWoXN9xWfI1bPNofDWN0/dZq3qOGqFGUW+1pZzFdbz8UGxqjcXOHH34Cid1NpX31yisIPOkV9kZHxhsHn5c/eS02oMlacv1fgyIU9jEloKMQ+Vn+IEnQr6pnKbBpB+mNZ9gjI3j3MG1umvVm65nmo+CAWNPXjE3vzNwiqn297rBZSvaJnnzA9m3mp9QIc8ibefT0/9Ma5M8CWbY6mghvHkJ1Xw9OIsnfy30JvgjrNiD9BOuDZ1pN1Ifv7IW1TB0eXPEhOhHvG X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-00b75.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 56233f61-866e-4067-a38a-08dc9836a952 X-MS-Exchange-CrossTenant-AuthSource: PAXP251MB0348.EURP251.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2024 12:26:11.9452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1P251MB0859 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/hexedit.scm (imhex): New variable. Change-Id: Iac50937ceecf617ebadf4b81d3321a262e28090b --- Hello! I'm updating this patch since ImHex has been updated a few times since. You will notice that the ImHex repository contains a few submodules, many of the submodules are libraries which do not include a cmake 'Findxxx.cmake'. For some libraries, the build system provides the appropriate file, but not for all. We decided not to un-bundle the libraries for now, the maintainers will consider adding the appropriate files in the future. Once that's done, we can update the package and un-bundle the libraries. gnu/packages/hexedit.scm | 98 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 98 insertions(+) base-commit: d601e953a463669a775ce17138e2b0f0c2e73ad9 diff --git a/gnu/packages/hexedit.scm b/gnu/packages/hexedit.scm index 668699a28c..e730d160a6 100644 --- a/gnu/packages/hexedit.scm +++ b/gnu/packages/hexedit.scm @@ -22,14 +22,30 @@ (define-module (gnu packages hexedit) #:use-module ((guix licenses) #:prefix license:) + #:use-module (guix gexp) #:use-module (guix packages) #:use-module (gnu packages) #:use-module (gnu packages autotools) #:use-module (gnu packages compression) #:use-module (gnu packages man) #:use-module (gnu packages ncurses) + #:use-module (gnu packages gl) + #:use-module (gnu packages tls) + #:use-module (gnu packages gcc) + #:use-module (gnu packages cpp) + #:use-module (gnu packages llvm) + #:use-module (gnu packages glib) + #:use-module (gnu packages curl) + #:use-module (gnu packages ruby) + #:use-module (gnu packages python) + #:use-module (gnu packages backup) + #:use-module (gnu packages fontutils) + #:use-module (gnu packages pkg-config) + #:use-module (gnu packages engineering) + #:use-module (gnu packages pretty-print) #:use-module (guix download) #:use-module (guix git-download) + #:use-module (guix build-system cmake) #:use-module (guix build-system gnu)) (define-public hexedit @@ -94,6 +110,88 @@ (define-public ht (home-page "https://hte.sourceforge.net/") (license license:gpl2))) +(define-public imhex + (package + (name "imhex") + (version "1.35.1") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/WerWolv/ImHex") + (commit (string-append "v" version)) + (recursive? #t))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1789hkqh78sg4cic09yq46bsy2vpk5y56b8g4q0r60si5y2vc9lh")))) + (build-system cmake-build-system) + (arguments + (list + ;; NOTE: there is an issue with the way the test library is linked with + ;; the output binaries. Tests are intrusive and should not be shipped + ;; with the release, when the issue is fixed we could add a phase which + ;; builds the package with the tests and runs the testsuite and a second + ;; build phase which prepares the output binary. + #:configure-flags ''("-DIMHEX_OFFLINE_BUILD=ON" + "-DIMHEX_ENABLE_UNIT_TESTS=ON" + ;; NOTE: required for the `validate-runpath' phase. + ;; If OFF the pluggings won't be able to find + ;; `libimhex.so' + "-DIMHEX_PLUGIN_ADD_INSTALL_PREFIX_TO_RPATH=ON" + + ;; TODO: remove unneeded submodules. + "-DUSE_SYSTEM_NLOHMANN_JSON=ON" + "-DUSE_SYSTEM_CAPSTONE=ON" + "-DUSE_SYSTEM_CLI11=ON" + "-DUSE_SYSTEM_LLVM=ON" + "-DUSE_SYSTEM_FMT=ON" + + ;; TODO: package them. + "-DUSE_SYSTEM_MINIAUDIO=OFF" + "-DUSE_SYSTEM_LUNASVG=OFF" + "-DUSE_SYSTEM_JTHREAD=OFF" + "-DUSE_SYSTEM_BOOST=OFF" + "-DUSE_SYSTEM_EDLIB=OFF" + "-DUSE_SYSTEM_YARA=OFF" + "-DUSE_SYSTEM_NFD=OFF") + #:phases #~(modify-phases %standard-phases + (add-after 'unpack 'fix-gsettings + (lambda* (#:key inputs #:allow-other-keys) + (substitute* "main/gui/source/window/linux_window.cpp" + (("dbus-send") + (search-input-file inputs "/bin/dbus-send"))))) + (add-before 'check 'build-tests + (lambda _ + (invoke "make" "unit_tests")))))) + (native-inputs (list gcc-13 + pkg-config + python + python-wrapper + ruby + mbedtls-apache + + ;; Third party submodules + nlohmann-json + capstone + llvm-17 + cli11 + fmt)) + (inputs (list freetype + libarchive + mesa + dbus + curl + glfw + dbus)) + (home-page "https://github.com/WerWolv/ImHex") + (synopsis "Hex Editor to display, decode and analyze binary data") + (description "Hex editor with many advanced features that can often only +be found in paid applications. Such features are a completely custom binary +template and pattern language to decode and highlight structures in the data, +a graphical node-based data processor to pre-process values before they're +displayed, a disassembler, diffing support, bookmarks and much much more.") + (license license:gpl2))) + (define-public bvi (package (name "bvi")