From patchwork Sat Apr 10 10:35:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?5a6L5paH5q2m?= X-Patchwork-Id: 28442 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A298927BC6F; Sat, 10 Apr 2021 11:34:09 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 576D627BC6E for ; Sat, 10 Apr 2021 11:34:01 +0100 (BST) Received: from localhost ([::1]:36670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVAwC-0005EH-Ak for patchwork@mira.cbaines.net; Sat, 10 Apr 2021 06:34:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53600) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVAvI-0004m0-6s for guix-patches@gnu.org; Sat, 10 Apr 2021 06:33:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39904) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVAvG-0008IF-Bn for guix-patches@gnu.org; Sat, 10 Apr 2021 06:33:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lVAvG-0008RA-9C for guix-patches@gnu.org; Sat, 10 Apr 2021 06:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47643] WIP-GNOME: gst-plugins-base Resent-From: =?utf-8?b?5a6L5paH5q2m?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 10 Apr 2021 10:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47643 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: rg@raghavgururajan.name Cc: Leo Prikler , leo@famulari.name, 47643@debbugs.gnu.org Received: via spool by 47643-submit@debbugs.gnu.org id=B47643.161805074632387 (code B ref 47643); Sat, 10 Apr 2021 10:33:02 +0000 Received: (at 47643) by debbugs.gnu.org; 10 Apr 2021 10:32:26 +0000 Received: from localhost ([127.0.0.1]:51450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVAuf-0008QJ-Vb for submit@debbugs.gnu.org; Sat, 10 Apr 2021 06:32:26 -0400 Received: from mail-oln040092255024.outbound.protection.outlook.com ([40.92.255.24]:7789 helo=APC01-HK2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lVAud-0008Q2-L8 for 47643@debbugs.gnu.org; Sat, 10 Apr 2021 06:32:25 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LEZdp67xHdDMnmWwlkSI7zGE57ebPAzDk1zTrbOjL99u617eW/+VUBfuQIwFi5L7ZIHR/iwpE2j28+LPAUT0zR9lnU6Nmaxq+qmMuOHGOyVdgueWZe7s9W/4jcFyFYNHpdZpcGbU3HUwOJl8sr205suOKTsxIT7a2AGumkl8QyEi+5jIU2Wg18oWI+WjcmGKCpBsibYnpsQYy9QI1AkNVhMe1L4V0litgrv/tSeyw9HKXnRgw5HM8f/BrQpNWWgSBFD53ts1EdC/xdQxA1sUuJUkdQKwi4IxXi53i292H04Av1JgnglfI4Xfq2Yrox7kTL4J4sBzqv5yiVdkR0KhOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=38VsDJlszmk7RSDM2v08kNqF2WmuQPGOCHg29w1SPiA=; b=PuvqcZ0V23Y2mC//dVoa6ibpbpRL/PYIhQIltfMlJuI/GBzRiiLbkMOyGWIsDFjGo2xH4WKqGqkj08rrqrq9I56sABltQmOhxHQ63z0++a6kL6LwNir0KFBKs7Y7dvjroNFr8lXkLX22DXGQMcO/vwLiZHJ8e6VZ1gGnQ/311bSRXOMS835rGoC3DEN+/XxtIfWCBGuKlecBQcNzeke1pd4knoHwHW5adQU8bxLlWy4MusjL7+O2GAwLR5UkJ2Z3Zo/veyynHfP2IhIGsEUEDN/CoR1c2Uzlzmy/5r/lbEgr0nNjlQhUTLkkmLvzKTucmxoKE/bUoZeTA5oQhEw9ZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=38VsDJlszmk7RSDM2v08kNqF2WmuQPGOCHg29w1SPiA=; b=pvRQ58RlBofBgUVx7nQvFMefpe1PlQbRRVhFRGofCpGlTdhm+B4gqNFb8AAV3MSZFEpzRnSSl8WMANBKPpdyHWgcUb53D5mmQ1BrD9wIHYQAlhM8FWxvBVfSicSvXcc9W2jUHCXs4/NWnyoaHSb0ToVRWagrIIvvR0Z7EjSRaygJEPVY1J+Hi4CA1OaLj+JCKZlSKt5VzLszjz8OU2q1/qoyhyLUE84Lkm9xJsAI7Avca25ifKTTTnjRwwPtqk8rdaMCHehsmCDGTHZ+DCEliyP+lP4gbgz9BhrcGaMjVjpkanpvZVmL6SJRfnkwc/Ho1bVBLD2HwPJzjxJ5E9nKjQ== Received: from HK2APC01FT010.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::48) by HK2APC01HT030.eop-APC01.prod.protection.outlook.com (2a01:111:e400:7ebc::246) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Sat, 10 Apr 2021 10:32:09 +0000 Received: from OSZP286MB0664.JPNP286.PROD.OUTLOOK.COM (10.152.248.53) by HK2APC01FT010.mail.protection.outlook.com (10.152.248.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Sat, 10 Apr 2021 10:32:09 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:5B96819DD94BCCE90F3CB3AA7F1A774C035BDD4F8CAAFEF059E6399A3A6362AB; UpperCasedChecksum:34F490DC8A16E671BB941703825F78A0ADA38AEF24897D3AB58BD6BCC0C8283B; SizeAsReceived:7671; Count:46 Received: from OSZP286MB0664.JPNP286.PROD.OUTLOOK.COM ([fe80::3077:ff28:1097:42cd]) by OSZP286MB0664.JPNP286.PROD.OUTLOOK.COM ([fe80::3077:ff28:1097:42cd%6]) with mapi id 15.20.4020.022; Sat, 10 Apr 2021 10:32:09 +0000 From: =?utf-8?b?5a6L5paH5q2m?= References: <20210409183900.24175-1-leo.prikler@student.tugraz.at> <20210409183900.24175-3-leo.prikler@student.tugraz.at> Date: Sat, 10 Apr 2021 18:35:02 +0800 In-Reply-To: <20210409183900.24175-3-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Fri, 9 Apr 2021 20:38:51 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) X-TMN: [fMAXOF4sqf4i5JEb8KqToPekylzStWml4uMYchEYpKdudFcBbwM/0ZF0lhBRBDQl] X-ClientProxiedBy: HK2PR0401CA0013.apcprd04.prod.outlook.com (2603:1096:202:2::23) To OSZP286MB0664.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:ec::11) X-Microsoft-Original-Message-ID: <87im4upgvd.fsf_-_@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (2409:8a62:372:44c0:2f1:f5ff:fe18:6bb) by HK2PR0401CA0013.apcprd04.prod.outlook.com (2603:1096:202:2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.16 via Frontend Transport; Sat, 10 Apr 2021 10:32:08 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 46 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 355c5d3f-81e3-4d4f-2bd5-08d8fc0be4d4 X-MS-TrafficTypeDiagnostic: HK2APC01HT030: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r9sAX+b064BsHLCEnRpcetOmT3LHBiwEufPF7eIMYOWrZZ29scqptQpMtADp8MDgcOHwMLqyv5WN2Fg/H+MNQDlY70NOYZKYlY0ckFYUUv4bgnbHqeMTGG05WbDQCh3pCZOjrPNMRK1DrK5cib3PSizq6+kOW9voQlRYMiXXRPFsR2xBGiLqthB2+0WjYN76XyqZd1Vt5Xb1yyshNtcjIVqZ3xZ6eL2hvWPbkRnw3Y2F7d5xyk4Z7euoIylEMr7dciYE1o4dveg7wVE7NF+5bKTrPvPZ1P+fY5wXKha6ODRrTb79R1/YPim3gYnEJOx8hwCfP6sIN/vtHf16BwGim5jcyTJRelGzS9yRiqdeW9hQLLjid5kX/11Yukkm7b8w6rTVbNw4zllUFebBY1aDQg== X-MS-Exchange-AntiSpam-MessageData: mb2lKEpE89dsptaqjrUji+3jA+ppm2evg1aDbI2Wj36N5V7r00fIm+E2Z3ek4nz6NG2kzR1vEBdeL4OCWsZBeuheKP7ufX+FV2x60kPVT8Lav+xOcK4RAVoNhZSRN5rPf0VNBbEzFCE71Ub91Z+2hyXH2RzyhXSMecr8IqqF8jwCae37bH6+RvfXX4YF25rA6beAzqiA68Uph3fkehlryw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 355c5d3f-81e3-4d4f-2bd5-08d8fc0be4d4 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2021 10:32:09.0459 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: HK2APC01FT010.eop-APC01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT030 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Leo Prikler writes: > From: Raghav Gururajan > > * gnu/packages/gstreamer.scm (gst-plugins-base)[version]: Update to 1.18.4. > [arguments](glib-or-gtk): New argument. > [configure-flags](gl): Remove flag. > [phases](pre-check): New phase. > [native-inputs]: Add gettext-minimal, gsettings-desktop-schemas, perl > and xorg-server-for-tests. > [propagated-inputs]: Add glib-networking. > [synopsis]: Fix indentation. Hello, what 'glib-or-gtk? #t', glib-networking, gsettings-desktop-schemas and perl are useful for? Also I think it's better split this into 2 patches, one for update, one for adding inputs. eg: (I also add some more inputs) What do you think, thanks! From 022de6b475411c1ab52fd63c4c12c4327cf2f4eb Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Sat, 10 Apr 2021 18:17:01 +0800 Subject: [PATCH 2/2] gnu: gst-plugins-base: Enable more features. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * gnu/packages/gstreamer.scm (gst-plugins-base) [inputs]: Add graphene, iso-codes, libgudev, libjpeg-turbo, libpng, libvisual, mesa, wayland-protocols, wayland. [native-inputs]: Add gettext-minimal and xorg-server-for-test. [arguments]: Remove '-Dgl=disabled' from configure flags. Add pre-check phase. Signed-off-by: Leo Prikler Co-authored-by: 宋文武 --- gnu/packages/gstreamer.scm | 37 ++++++++++++++++++++++++++++++------- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm index 1e9f5444a7..0b5f14342e 100644 --- a/gnu/packages/gstreamer.scm +++ b/gnu/packages/gstreamer.scm @@ -559,6 +559,7 @@ This package provides the core library and elements.") '() `(("orc" ,orc))))) ;required by gstreamer-audio-1.0.pc (inputs + ;; TODO: Add libvorbisidec `(("cdparanoia" ,cdparanoia) ("pango" ,pango) ("libogg" ,libogg) @@ -569,21 +570,43 @@ This package provides the core library and elements.") ("libXext" ,libxext) ("libxv" ,libxv) ("alsa-lib" ,alsa-lib) - ("opus" ,opus))) + ("opus" ,opus) + ("graphene" ,graphene) + ("iso-codes" ,iso-codes) + ("libgudev" ,libgudev) + ("libjpeg" ,libjpeg-turbo) + ("libpng" ,libpng) + ("libvisual" ,libvisual) + ("mesa" ,mesa) + ("wayland-protocols" ,wayland-protocols) + ("wayland" ,wayland))) (native-inputs - `(("pkg-config" ,pkg-config) - ("glib:bin" ,glib "bin") - ("gobject-introspection" ,gobject-introspection) - ("python-wrapper" ,python-wrapper))) + `(("pkg-config" ,pkg-config) + ("glib:bin" ,glib "bin") + ("gobject-introspection" ,gobject-introspection) + ("python-wrapper" ,python-wrapper) + ("gettext" ,gettext-minimal) + ("xorg-server" ,xorg-server-for-tests))) (arguments - `(#:configure-flags '("-Dgl=disabled") - #:phases + `(#:phases (modify-phases %standard-phases ,@%common-gstreamer-phases (add-before 'configure 'patch (lambda _ (substitute* "tests/check/libs/pbutils.c" (("/bin/sh") (which "sh"))) + #t)) + (add-before 'check 'pre-check + (lambda _ + ;; Tests require a running X server. + (system "Xvfb :1 +extension GLX &") + (setenv "DISPLAY" ":1") + ;; Tests write to $HOME. + (setenv "HOME" (getcwd)) + ;; Tests look for $XDG_RUNTIME_DIR. + (setenv "XDG_RUNTIME_DIR" (getcwd)) + ;; For missing '/etc/machine-id'. + (setenv "DBUS_FATAL_WARNINGS" "0") #t))))) (home-page "https://gstreamer.freedesktop.org/") (synopsis -- 2.30.0