diff mbox series

[bug#53040] gnu: bubblewrap: Update to 0.5.0.

Message ID MsgRpG_--3-2@tutanota.com
State Accepted
Headers show
Series [bug#53040] gnu: bubblewrap: Update to 0.5.0. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Deslauriers, Douglas via Guix-patches" via Jan. 5, 2022, 10:54 p.m. UTC
Unfortunately some tests fail because of missing locales, I've attached the test log. Help is appreciated.

Comments

Ludovic Courtès Jan. 9, 2022, 9:50 p.m. UTC | #1
Hi,

kiasoc5@tutanota.com skribis:

> ERROR: tests/test-specifying-pidns.sh
> =====================================
>
> +++ dirname ./tests/test-specifying-pidns.sh
> ++ cd ./tests
> ++ pwd
> + srcd=/tmp/guix-build-bubblewrap-0.5.0.drv-0/bubblewrap-0.5.0/tests
> + . /tmp/guix-build-bubblewrap-0.5.0.drv-0/bubblewrap-0.5.0/tests/libtest.sh
> ++ set -e
> ++ '[' -n /tmp/guix-build-bubblewrap-0.5.0.drv-0/bubblewrap-0.5.0 ']'
> ++ test_srcdir=/tmp/guix-build-bubblewrap-0.5.0.drv-0/bubblewrap-0.5.0/tests
> ++ '[' -n /tmp/guix-build-bubblewrap-0.5.0.drv-0/bubblewrap-0.5.0 ']'
> ++ test_builddir=/tmp/guix-build-bubblewrap-0.5.0.drv-0/bubblewrap-0.5.0/tests
> ++ . /tmp/guix-build-bubblewrap-0.5.0.drv-0/bubblewrap-0.5.0/tests/libtest-core.sh
> +++ type -p locale
> ++++ locale -a
> ++++ grep -iEe '^(C|en_US)\.(UTF-8|utf8)$'

The ‘en_US.utf8’ locale is available; however, the ‘locale -a’ command
won’t list it, for obscure reasons.

I suggest patching libtest-core.sh so that it unconditionally uses
en_US.utf8 instead of running ‘locale -a’.

HTH!

Ludo’.
Josselin Poiret Jan. 12, 2022, 4:42 p.m. UTC | #2
Hello Ludovic and kiasoc5, 

Ludovic Courtès <ludo@gnu.org> writes:
> The ‘en_US.utf8’ locale is available; however, the ‘locale -a’ command
> won’t list it, for obscure reasons.
>
> I suggest patching libtest-core.sh so that it unconditionally uses
> en_US.utf8 instead of running ‘locale -a’.

I am a bit late to the party, but the official locale name is
en_US.UTF-8.  utf8 is not a registered IANA name.  UTF-8 is converted to
utf8 by glibc internally, but I remember having issues when I had
mistakenly set LC_ALL to en_US.utf8 in the past, so better be safe than
sorry.
diff mbox series

Patch

From 83cd691bc4875373e84a1b4b77ffa25cf85e9136 Mon Sep 17 00:00:00 2001
From: kiasoc5 <kiasoc5@tutanota.com>
Date: Wed, 5 Jan 2022 02:18:15 -0500
Subject: [PATCH] gnu: bubblewrap: Update to 0.5.0.

* gnu/packages/virtualization.scm (bubblewrap): Update to 0.5.0.
---
 gnu/packages/virtualization.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index 6a40955dbb..71c7178c6d 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -1927,7 +1927,7 @@  (define-public python-vagrant
 (define-public bubblewrap
   (package
     (name "bubblewrap")
-    (version "0.4.1")
+    (version "0.5.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "https://github.com/containers/bubblewrap/"
@@ -1935,7 +1935,7 @@  (define-public bubblewrap
                                   version ".tar.xz"))
               (sha256
                (base32
-                "00ycgi6q2yngh06bnz50wkvar6r2jnjf3j158grhi9k13jdrpimr"))))
+                "0608l2sjwhnb1c0mslah1h6yjvqr17wk60by6i710qwxg4rszz8n"))))
     (build-system gnu-build-system)
     (arguments
      `(#:phases

base-commit: 8860e9db560c5d9e74277b608071fbb93579db4f
-- 
2.34.1