diff mbox series

[bug#44512] gnu: Add python-telethon.

Message ID MLb7Nqb--3-2@tuta.io
State Accepted
Headers show
Series [bug#44512] gnu: Add python-telethon. | expand

Checks

Context Check Description
cbaines/submitting builds success
cbaines/issue success View issue
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job

Commit Message

Adam Kandur Nov. 8, 2020, 9:13 a.m. UTC

Comments

Efraim Flashner Nov. 18, 2020, 8:48 p.m. UTC | #1 
I made a couple of changes before pushing the patch

On Sun, Nov 08, 2020 at 10:13:16AM +0100, Adam Kandur via Guix-patches via wrote:
> 
> 

> From 40a037719317f943e4d311e6c03b1398feaffe7b Mon Sep 17 00:00:00 2001
> From: Adam <rndd@tuta.io>
> Date: Sun, 8 Nov 2020 12:10:32 +0300
> Subject: [PATCH] gnu: Add python-telethon.
> 
> * gnu/packages/python-xyz.scm (python-telethon): New variable.
> ---
>  gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 5bbd547..d7dfaf2 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -22560,6 +22560,29 @@ a Python library to convert RELAX NG schemata in Compact syntax (rnc) to
>  equivalent schemata in the XML-based default RELAX NG syntax.")
>      (license license:expat)))
>  
> +(define-public python-telethon
> +  (package
> +    (name "python-telethon")

We normally put this after the source, so I moved it there.

> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-rsa" ,python-rsa)
> +       ("python-pyaes" ,python-pyaes)
> +       ("python-pytest" ,python-pytest)))

pytest should be a native-input. I also added python-pytest-asyncio and
python-pytest-trio to native-inputs.

> +    (version "v1.17.5")

the 'v' isn't part of the version string. Instead the 'commit' as part
of the source becomes '(commit (string-apend "v" version))'

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +	     (url "https://github.com/LonamiWebs/Telethon")
> +	     (commit version)))

I see you noticed the pypi release didn't come with tests :)

> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "0l9fhdrq576vllgi9aam45xzw5xi6jhgdv5zz8i4ygssdp7cm8jl"))))

I replaced the 'check phase with a phase which runs
(invoke "py.test" "-v")

> +    (home-page "https://docs.telethon.dev")
> +    (synopsis "Telethon is an asyncio Python 3 MTProto library to interact with Telegram's API as a user or through a bot account (bot API alternative).")
> +    (description "Telegram is a popular messaging application. This library is meant to make it easy for you to write Python programs that can interact with Telegram. Think of it as a wrapper that has already done the heavy job for you, so you can focus on developing an application.")
> +    (license license:expat)))

I wasn't a fan of the synopsis or description, so I took the synopsis
which came from 'guix import pypi pypi telethon' and I shortened the
description to mostly just include that it interacts with Telegram.

> +
>  (define-public python-citeproc-py
>    (package
>      (name "python-citeproc-py")
> -- 
> 2.28.0
> 

Thanks for the patch! Pushed.
diff mbox series

Patch

From 40a037719317f943e4d311e6c03b1398feaffe7b Mon Sep 17 00:00:00 2001
From: Adam <rndd@tuta.io>
Date: Sun, 8 Nov 2020 12:10:32 +0300
Subject: [PATCH] gnu: Add python-telethon.

* gnu/packages/python-xyz.scm (python-telethon): New variable.
---
 gnu/packages/python-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 5bbd547..d7dfaf2 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -22560,6 +22560,29 @@  a Python library to convert RELAX NG schemata in Compact syntax (rnc) to
 equivalent schemata in the XML-based default RELAX NG syntax.")
     (license license:expat)))
 
+(define-public python-telethon
+  (package
+    (name "python-telethon")
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-rsa" ,python-rsa)
+       ("python-pyaes" ,python-pyaes)
+       ("python-pytest" ,python-pytest)))
+    (version "v1.17.5")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+	     (url "https://github.com/LonamiWebs/Telethon")
+	     (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0l9fhdrq576vllgi9aam45xzw5xi6jhgdv5zz8i4ygssdp7cm8jl"))))
+    (home-page "https://docs.telethon.dev")
+    (synopsis "Telethon is an asyncio Python 3 MTProto library to interact with Telegram's API as a user or through a bot account (bot API alternative).")
+    (description "Telegram is a popular messaging application. This library is meant to make it easy for you to write Python programs that can interact with Telegram. Think of it as a wrapper that has already done the heavy job for you, so you can focus on developing an application.")
+    (license license:expat)))
+
 (define-public python-citeproc-py
   (package
     (name "python-citeproc-py")
-- 
2.28.0