diff mbox series

[bug#50563] Re: [bug#50563] [PATCH 2/2] gnu: gdm: Add Wayland session wrapper script.

Message ID K0eT0ERo5Yl3ByH2Lo7fUVUq7NVpV36zL-KnQ440i6N0XafiijFod-id3xUnSo7MBO1Md8XCpciPCyfwpyslhFiwg3ZdMicD6VTntddRt4o=@jpoiret.xyz
State Accepted
Headers show
Series [bug#50563] Re: [bug#50563] [PATCH 2/2] gnu: gdm: Add Wayland session wrapper script. | expand

Checks

Context Check Description
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Josselin Poiret Sept. 14, 2021, 9:45 p.m. UTC 
Maxime: I agree that this was a very confusing wording. Here is a reformulation that I hope clears up any misunderstanding.
PS: `gdm-wayland-session-wrapper` does in fact set environment variables, only that it indirectly uses `/etc/profile` to do so. Otherwise, the default profile wouldn't be active in the wayland session.

---
 doc/guix.texi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

--
2.33.0

Jack: Great news! I've been using it on my daily driver as well, without any problem so far.

Comments

M Sept. 15, 2021, 9:47 a.m. UTC | #1 
Josselin Poiret schreef op di 14-09-2021 om 21:45 [+0000]:
> Maxime: I agree that this was a very confusing wording. Here is a reformulation that I hope clears up any misunderstanding.
> PS: `gdm-wayland-session-wrapper` does in fact set environment variables, only that it indirectly uses `/etc/profile` to do so. Otherwise, the default profile wouldn't be active in the wayland session.
> 
> [...]
> 
> -In addition, @file{~/.xsession} files are honored.  When available,
> -@file{~/.xsession} must be an executable that starts a window manager
> -and/or other X clients.
> +In addition, @file{~/.xsession} files are honored when launching X11 sessions.
> +When available, @file{~/.xsession} must be an executable that starts a window
> +manager and/or other X clients.
>  @end defvr
> 
>  @deftp {Data Type} gdm-configuration
> @@ -18100,8 +18100,8 @@ The GDM package to use.
>  When true, enables Wayland in GDM, necessary to use Wayland sessions.
> 
>  @item @code{wayland-session} (default: @code{gdm-wayland-session-wrapper})
> -The Wayland session wrapper to use, needed to setup the
> -environment.
> +The Wayland session wrapper to use, analogous to @code{xsession}. The default
> +wrapper simply launches the session in a login shell.
>  @end table
>  @end deftp

This is clear to me, thanks!

Greetings,
Maxime.
diff mbox series

Patch

diff --git a/doc/guix.texi b/doc/guix.texi
index 3e6157c8ab..8a0eba16e1 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -18064,9 +18064,9 @@  Packages such as @code{gnome}, @code{xfce}, @code{i3} and @code{sway} provide
 @file{.desktop} files; adding them to the system-wide set of packages
 automatically makes them available at the log-in screen.

-In addition, @file{~/.xsession} files are honored.  When available,
-@file{~/.xsession} must be an executable that starts a window manager
-and/or other X clients.
+In addition, @file{~/.xsession} files are honored when launching X11 sessions.
+When available, @file{~/.xsession} must be an executable that starts a window
+manager and/or other X clients.
 @end defvr

 @deftp {Data Type} gdm-configuration
@@ -18100,8 +18100,8 @@  The GDM package to use.
 When true, enables Wayland in GDM, necessary to use Wayland sessions.

 @item @code{wayland-session} (default: @code{gdm-wayland-session-wrapper})
-The Wayland session wrapper to use, needed to setup the
-environment.
+The Wayland session wrapper to use, analogous to @code{xsession}. The default
+wrapper simply launches the session in a login shell.
 @end table
 @end deftp