diff mbox series

[bug#56377] gnu: pipe-viewer: Add dependency.

Message ID JX7o9aDg6NRVU3_Z9QSsXV8x4QgGPr89XVjfAsKgj8u9HXc_AweueLyZOTmznirJym_D79LVi8Di1V3OO5yCD6mKt-Vxvu5kRlpPEEPXyck=@proton.me
State Accepted
Headers show
Series [bug#56377] gnu: pipe-viewer: Add dependency. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Sughosha July 4, 2022, 2:08 a.m. UTC 
Without mpv this application gives the following error:
sh: line 1: mpv: command not found.

Comments

Sughosha July 4, 2022, 2:33 a.m. UTC | #1 
Sorry, again, as using the app I understood that mpv is not hardcoded, in the settings I can use any video player. So it doesn't make sense to add mpv as a dependency. I would request to ignore this issue and close it.
M July 29, 2022, 4:38 p.m. UTC | #2 
On 04-07-2022 04:33, Sughosha via Guix-patches via wrote:

> Sorry, again, as using the app I understood that mpv is not hardcoded, 
> in the settings I can use any video player. So it doesn't make sense 
> to add mpv as a dependency. I would request to ignore this issue and 
> close it.

Assuming that mpv isn't overly large, I think it would be nice if 
pipe-viewer can always find its default player -- the user can still 
override what player to use when desired.

Looking at "guix size mpv pipe-viewer" and "guix size pipe-viewer", mpv 
adds 20.1 MiB; I don't know if that's worth it (I'm leaning towards 
'not' but I'm undecided).

Greetings,
Maxime.
diff mbox series

Patch

From 0b0e66ba091ed2b4871f855e6ef271cda276aaf0 Mon Sep 17 00:00:00 2001
From: Sughosha <sughosha@proton.me>
Date: Mon, 4 Jul 2022 04:01:12 +0200
Subject: [PATCH] gnu: pipe-viewer: Add dependency.

* gnu/packages/video.scm (pipe-viewer): Add dependency.

  This application calls mpv to play audios or videos, so mpv as dependency is required.
---
 gnu/packages/video.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 40c31cdaec..07f9e94d34 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1183,7 +1183,8 @@  (define-public pipe-viewer
            wget
            xdg-utils
            youtube-dl
-           yt-dlp))
+           yt-dlp
+           mpv))
     (propagated-inputs
      (list dconf))
     (home-page "https://github.com/trizen/pipe-viewer")
-- 
2.36.1