From patchwork Tue Sep 20 09:12:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sughosha X-Patchwork-Id: 42771 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 82D0D27BBEA; Tue, 20 Sep 2022 11:19:34 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id D118027BBE9 for ; Tue, 20 Sep 2022 11:19:33 +0100 (BST) Received: from localhost ([::1]:53596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaaLk-00010p-TI for patchwork@mira.cbaines.net; Tue, 20 Sep 2022 06:19:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaZJO-0005VQ-Mp for guix-patches@gnu.org; Tue, 20 Sep 2022 05:13:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56984) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaZJN-0007mI-Vh for guix-patches@gnu.org; Tue, 20 Sep 2022 05:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oaZJN-0002ig-P5 for guix-patches@gnu.org; Tue, 20 Sep 2022 05:13:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57944] [PATCH 1/2] gnu: Add gnome-text-editor Resent-From: Sughosha Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Sep 2022 09:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57944 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 57944@debbugs.gnu.org Received: via spool by 57944-submit@debbugs.gnu.org id=B57944.166366517210440 (code B ref 57944); Tue, 20 Sep 2022 09:13:01 +0000 Received: (at 57944) by debbugs.gnu.org; 20 Sep 2022 09:12:52 +0000 Received: from localhost ([127.0.0.1]:56062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaZJB-0002iG-GO for submit@debbugs.gnu.org; Tue, 20 Sep 2022 05:12:52 -0400 Received: from mail-4027.protonmail.ch ([185.70.40.27]:62947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaZJ4-0002hy-UL for 57944@debbugs.gnu.org; Tue, 20 Sep 2022 05:12:48 -0400 Date: Tue, 20 Sep 2022 09:12:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1663665156; x=1663924356; bh=0DyWOsJ6Y0XxC0Ix/X5h5oQeL7PcCVt+2jcSOsvYNOI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=HMVx5L76MRdceOwMSr8E4LhIbUm2rBdvhGpKm24F16AqDJ3oU8gYa8Uqr5eeh1Nel uuJKKSrjA0h7l9xGTM/t9MxKLziCPuUoIDG8l932Rs4SVQTajDB3tKgPbtlVbJY7V0 wfAA5LrsfL1704jUqhe2UCRTJ7D9OpiZgEdif3P2RFnOhEJULhOlZ0uFL3ndvTouBC A8nxQETjq/c0RFZph4PlHhFZ0SgCiZv7hFPh6pHpJtZeiY+pTSEBHD0L41iWYBX5M2 0+TXWGou9u2h6XSXyxYOh2f14cF8+eZMKmpKeXfGA8ZcAl8mxG2EicRkVLL1vpAE0V x/ShJQiEZolmA== Message-ID: In-Reply-To: References: Feedback-ID: 45211691:user:proton MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: Sughosha X-ACL-Warn: , Sughosha via Guix-patches X-Patchwork-Original-From: Sughosha via Guix-patches via From: Sughosha X-getmail-retrieved-from-mailbox: Patches Thanks for reviewing. I made the changes with the corrections. Here are new patches with the fixes. But one thing I am not sure why gpl3+ was suggested, while in the GitLab repository it is mentioned as GNU GPLv3. ------- Original Message ------- Liliana Marie Prikler schrieb am Dienstag, 20. September 2022 um 07:14: > Hi, > > Am Dienstag, dem 20.09.2022 um 04:13 +0000 schrieb Sughosha: > > > + (uri (string-append "mirror://gnome/sources/gnome- > > text-editor/" > > + (version-major version) > > + "/" > > + "gnome-text-editor-" > > + version > > + ".tar.xz")) > > The format provided by the pretty-printer is, like, a suggestion. > > > + (build-system meson-build-system) > > + (native-inputs (list pkg-config > > You're missing arguments here. At the very least #:glib-or-gtk? #t > > > + "Text Editor is a simple text editor that focuses on session > > management. > > +It works hard to keep track of changes and state even if you quit > > the > > +application. You can come back to your work even if you've never > > saved it to a > > +file." > > You should probably call it GNOME Text Editor. The description is > fairly light on advertisments as far as copypasta descriptions go, so I > won't fault you for that here. > > > + (license license:gpl3))) > > Should probably be gpl3+. > > > + (synopsis "Simple user-friendly terminal emulator for the GNOME > > desktop") > > + (description > > + "Console is supposed to be a simple terminal emulator for the > > average user > > +to carry out simple cli tasks and aims to be a ‘core’ app for > > GNOME/Phosh") > > Ehhhhhh... I do want you to cut down on the ads here. > > > + (build-system meson-build-system) > > + (native-inputs (list desktop-file-utils > > Missing arguments. > > > + (home-page "https://gitlab.gnome.org/GNOME/gnome-console") > > Dead link is dead. > > > + (license license:gpl3))) > > Also probably gpl3+. > > Cheers From 8142d2bc994e1b7cc61ad379f9ce13ee7e274ec0 Mon Sep 17 00:00:00 2001 From: Sughosha Date: Tue, 20 Sep 2022 06:08:05 +0200 Subject: [PATCH 2/2] gnu: Add gnome-console * gnu/packages/gnome.scm (gnome-console): New variable. --- gnu/packages/gnome.scm | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index c76b25d968..14e9c36fc6 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -5411,6 +5411,38 @@ (define-public gnome-sudoku more fun.") (license license:gpl2+))) +(define-public gnome-console + (package + (name "gnome-console") + (version "42.2") + (source (origin + (method url-fetch) + (uri (string-append "mirror://gnome/sources/gnome-console/" + (version-major version) "/" + "gnome-console-" version ".tar.xz")) + (sha256 + (base32 + "0jbh8g3hmc35fy5fbscqf0831xpg1kv66ci9hykpbia4hz0yc9kx")))) + (build-system meson-build-system) + (arguments + `(#:glib-or-gtk? #t + #:configure-flags + `("-Dtests=true"))) + (native-inputs (list `(,glib "bin") + gettext-minimal + sassc + pkg-config + `(,gtk+ "bin") + desktop-file-utils)) + (inputs (list gtk+ + libhandy + vte + libgtop + gsettings-desktop-schemas)) + (home-page "https://gitlab.gnome.org/GNOME/console") + (synopsis "GNOME terminal emulator") + (description + "Console is a simple terminal emulator for GNOME desktop") + (license license:gpl3+))) + (define-public gnome-terminal (package (name "gnome-terminal") -- 2.37.3