| Message ID | DM5PR1001MB2105D585E38C8C158A3490E6C5680@DM5PR1001MB2105.namprd10.prod.outlook.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#42216] gnu: Add emacs-flycheck-ledger. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
Hello, Morgan.J.Smith@outlook.com writes: > * gnu/packages/emacs-xyz.scm (emacs-flycheck-ledger): New variable. Thank you. Some comments follow. > +(define-public emacs-flycheck-ledger > + (package > + (name "emacs-flycheck-ledger") > + (version "20200304.2204") There's a stable "0.5" release. We should use it instead. > + (source (origin > + (method url-fetch) > + (uri (string-append "https://melpa.org/packages/flycheck-ledger-" > + version ".el")) We don't use source files from MELPA, as they are somewhat modified in-place. Use git-fetch instead. Also, could you move `origin' behind `source'? > + (sha256 > + (base32 > + "036xn52xjxbbvag9slqi4xqlvzg9p2q544hhxhqqi7jz1kap0yx8")))) > + (inputs `(("ledger" ,ledger))) I think this is not sufficient, because Emacs Flycheck Ledger will not find the Ledger executable. You need to tweak `flycheck-ledger-executable', using `emacs-substitute-variables'. Could you send an updated patch? Regards,
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index a67fe06610..486c93dce3 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -179,6 +179,7 @@ #:use-module (gnu packages wordnet) #:use-module (gnu packages photo) #:use-module (gnu packages uml) + #:use-module (gnu packages finance) #:use-module (guix utils) #:use-module (srfi srfi-1) #:use-module (ice-9 match)) @@ -4074,6 +4075,28 @@ repetitions for example).") compile}.") (license license:gpl3+))) +(define-public emacs-flycheck-ledger + (package + (name "emacs-flycheck-ledger") + (version "20200304.2204") + (source (origin + (method url-fetch) + (uri (string-append "https://melpa.org/packages/flycheck-ledger-" + version ".el")) + (sha256 + (base32 + "036xn52xjxbbvag9slqi4xqlvzg9p2q544hhxhqqi7jz1kap0yx8")))) + (inputs `(("ledger" ,ledger))) + (propagated-inputs + `(("emacs-flycheck" ,emacs-flycheck))) + (build-system emacs-build-system) + (home-page "https://github.com/purcell/flycheck-ledger") + (synopsis "Ledger support for Flycheck") + (description "This flychecker uses the output of @code{ledger balance} on +the current file to find errors such as unbalanced transactions and syntax +errors.") + (license license:gpl3+))) + (define-public emacs-flycheck-rust (package (name "emacs-flycheck-rust")
From: Morgan Smith <Morgan.J.Smith@outlook.com> * gnu/packages/emacs-xyz.scm (emacs-flycheck-ledger): New variable. --- gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+)