From patchwork Mon Mar 3 00:29:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Morgan Smith X-Patchwork-Id: 39628 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 8606A27BBE9; Mon, 3 Mar 2025 00:30:18 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 344B527BBE2 for ; Mon, 3 Mar 2025 00:30:16 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1toth7-0005kG-Fu; Sun, 02 Mar 2025 19:30:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1toth5-0005h4-0l for guix-patches@gnu.org; Sun, 02 Mar 2025 19:30:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1toth4-0004nr-Gt for guix-patches@gnu.org; Sun, 02 Mar 2025 19:30:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=5aFGFmrG+C/3l9T9vFHkaX3S/RC684RqOg9vYOhE+W8=; b=Uu4zNr5yC1dIxuMGi84yLRbiFpcOMRC2KSwU/SH5mi0xWWTKrOtgUcQC5xDyngevnyAmC7maV1QB1j2ikfi0j9YCFinx16/xDEIGEEDIohkVkxIaOtUT8wn7NinvfKsDQFtGW82Mom4mg2TNEc/Opkc5ZV2mBjCbOJud8rTSM5OqRh6InrRS36e2F7U/kA5navWiaZsorjBiSTrXoJmdlHhSqi94vT1I/QnLRVH0aPotfCwMscPxzF09/oTa6hjy1Ch+bhA6AMVP8QoGiFaGZ/tAXP1Y15xf9qiEJ2lbBmrsAKAHKMOqvnrm5mJ5iiMXtjYY1NtFkFgC6Y5+GjUjeA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1toth4-0008Ry-5D for guix-patches@gnu.org; Sun, 02 Mar 2025 19:30:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#76686] [PATCH emacs-team 00/45] Test emacs packages by default Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 03 Mar 2025 00:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 76686 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 76686@debbugs.gnu.org, ian@retrospec.tv, cox.katherine.e+guix@gmail.com, liliana.prikler@gmail.com, andrew@trop.in, divya@subvertising.org Received: via spool by 76686-submit@debbugs.gnu.org id=B76686.174096177732306 (code B ref 76686); Mon, 03 Mar 2025 00:30:02 +0000 Received: (at 76686) by debbugs.gnu.org; 3 Mar 2025 00:29:37 +0000 Received: from localhost ([127.0.0.1]:39516 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1totge-0008Oy-S7 for submit@debbugs.gnu.org; Sun, 02 Mar 2025 19:29:37 -0500 Received: from mail-dm6nam04olkn20815.outbound.protection.outlook.com ([2a01:111:f403:2c09::815]:23489 helo=NAM04-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1totgc-0008OW-Ie for 76686@debbugs.gnu.org; Sun, 02 Mar 2025 19:29:35 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IaUfC56mroYUUgdNwtCtRRjN/CVoAS3yBUAepw6VgSYlIM78waVUETXU8ptkqQ8trH6kiSSwRMumhz5q4KaeQfNyt1NzDbVK0ggPZQKzFr94fEYKW8wPDcEq5T4bzw204JVR4ya7WOBHj3B6m99VlhzB1KpjHeOjeaWtBUJQ6YY07kIKL96IpLxqoFzE0EESFshxIsPQeSR8UmCa4k203UPpbcOHjM2hSHy1UhpaUjb6MSUEsIi+J63JKR0Ru8o/KSyJeDVc07NhOA1YFAgrbcMMl1MiGoHclcBQkpaxEYqG3hxtaLMfbOeDN0dhdboU3iMSapfpFntf9yDCYnfX0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5aFGFmrG+C/3l9T9vFHkaX3S/RC684RqOg9vYOhE+W8=; b=wozlLwZPrP5j6zwG21oV9cvsCcr+w40Ou9BUFgm/PyMBZGzk2Hw31BvoZsVqXvyD3kxjGrnRyrZNvsA7DDVH7Uj+WdFTJQRBikOEdqKHImw2s8jlbavtWbO5dns38p6W8KsGf8ms5spguuA4Bi/oNOBb76FCgXZUSH3Ir2RGBYRWNfvPwwFUMml7owP8pL7Xl58C/1jqvdPk8GsCxVpjJVXqkbRKcihZ6S8VhxyMCezkfZsW/EfnhgE6XysDEijezeNViKJQNKvTJPhjpGx5R+g1Mc21iqnALVp9aoxNG5CEejyufbJGXdLNUR130CrMfVKOyVThno1jJ6YKJ9TIkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5aFGFmrG+C/3l9T9vFHkaX3S/RC684RqOg9vYOhE+W8=; b=b5rtAL5muhsZqSfssB3hBNeA/grqyqiPHGlFW1gxb1ywAuKeGjNgSoJV2pczhods/8PIiSrGyF8CeMRRZX1u6f6lsvUDS50Kj27BwZ5sqvbwrxLeYHfpNDSIwq+QEgO6yrxsiQrSbs3MFCDfkRUOZq4SY1Xti/e0VeO5gmEKpArjSyBHOYpLSxBIuPrzbrCYRUYnlxnBAw5FYSGX18kf3/0ig2uOt9rSYutO8RzRb4BpHQhyJ8ORE5Ds0kTFIL+u5+VRe43mmOTdfvs1zN3GZLV7gB5Mu+yIpNSYG8QStnQdTx2yrv68tLexorlEY6xDYsgStPvMa828ub+QnPQbiA== Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) by MW4PR84MB2258.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1b5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.28; Mon, 3 Mar 2025 00:29:17 +0000 Received: from CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef]) by CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM ([fe80::5c77:7a58:48ed:9aef%4]) with mapi id 15.20.8489.025; Mon, 3 Mar 2025 00:29:17 +0000 From: Morgan Smith In-Reply-To: References: Date: Sun, 02 Mar 2025 19:29:12 -0500 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) X-ClientProxiedBy: YT1PR01CA0040.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2e::9) To CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1c4::17) X-Microsoft-Original-Message-ID: <87frjvnehz.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR84MB3424:EE_|MW4PR84MB2258:EE_ X-MS-Office365-Filtering-Correlation-Id: 0668c8d6-2274-421a-b10d-08dd59ea6d9a X-Microsoft-Antispam: BCL:0; ARA:14566002|5072599009|8060799006|15080799006|6092099012|19110799003|12121999004|7092599003|461199028|13095399003|13041999003|440099028|3412199025; X-Microsoft-Antispam-Message-Info: lrRyEQZI4ixZRjKru+GBQ+BfIKvJggGWj6pVR2WrIY95D/uAHfwnqD0qrAem63G6EGQADtq+01BVowJaLicioxp/mvgSzx2AhmMxsv4zDtHdmoc/DUFY8SUGVxyZLw6n3Vq/0J6TDsldaYp6i00UT4gfEH024sSghVMklPYQ3/QVcoX1DMXaj9nPI7ZkPrJqxeaZkcpB28gybFfq9S9hOSTAlADPUpBZiz9wDtadF2Q5H/XF0dk5Tu8jLSzOgw2s8bVJQAVi6Eg8NBkdAYFvbqCVav8oBfQD1e0ULS57n8aDtGZ4iaEtuFNBCLpUCyzjoa6ddY4tTMnG7dVa/b+Zata/WbHIUZvxiMXRBWwKQg/IvUePkFdqqMokPF732ppc9LAuXvSaey4aqvufg7wKdvKCIsXkbrq1DpWb5wupgAxZWuFD0vGPiJQZtBiF//Jf6EDbW0/eaGdrVIPjB76R+Do8ArMZd1TQdJUUx+QS4ZAar9fBf5CGX4shTpPIyV8OHwgWESoThiOjpQvF3bMTSu7qgmYaiNyAo397tF/bE3BnVTGjX6AFhfdFQrwPx37S71ec/fydLgoi4609pbgPZHHi/fwCNTGkde6qFINkGJinLu1WQrtIvJpgtSQaYroSuSIR3huASnOXzcMtcH5rY1RhGVKEYrPj47NLxfxvyE6WbQD6B6JGyW4bQbvMD/AYwGDAZELugfdzzYkq4gQ3AeOreP5LomuXV19s4d/mLEM2ZB5fLSgg7M4RVfMdMMVUcX6HQCGRmUPJGXdFe/0J2Ja8YeBQL5JkoZU/k3vLmfQp8bwEgpGSpEqHoBZjzcJb0Ue99cEt/ADTZWI5Zst8tyahHOaQu064k6qagMkp38RRhtely2KrqJh1S81WsMoCcanhGyXmYP1LGCIP5dpCsoSl9crm9tCKTzE280f4RVmqpcBZwsaeg3vBA0gsVDDkV02qHGBAGgF1KxxNVie9zKvRetfe6XelV/SxaNV7kWhJHvb68AkeoHMFo/6mPaFX2gtUDTyrFKmRiVnTPyDwgjXWgnsoK1TbFavh0k+bli8WjN2GYPnbqQNkXwv8k0Y7SPH6l7LeZ+1oHez+evwdVacMpG1rH284BfT8dkuZTlLsIbHk3+dDtwQcMoKZ/Dv8x7ixTcprny2ujEjxeoqxvrbFj4Kb1sM4cQyD42oR/wsiowmWkErZkMidHvTuzS3kzezQy9io8nkejsGwvxG+qQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ayfuA6RyQhOX2alG0EvGd75qqRvYttr9exFYPGsxwe8+ON7TOKKYJYjzHMEtyHn+//lvBX2IHxMLY5/qlhFLW7OB6CKI/KsSf2mzKhoC609oJBlH+WJxuwOsqz1Iu/wj2SRnzI9dHT6MMNbTj1bCdbwL37hVQD5p2cLcFWMWPsZZrj7lca44lhEpi5saDL3BG4dc1H5Kiim0VCdbNAxKi8CRpTzyuJgnzbDGr3RaHmcTfkd5q9MaC/tOKlzwpXLZ0dElOl0XsVg4Bgz2FwVbyJc5hnhcOpOFJvDBqlLAawgqBNuqhXx9L+WethRxXDjf0MNSBqFRnAHNWYxHXBy2HmXvF8/DCD5dE4p7PKDVtTQ2in4V/lCK7R2spBwkll8yj8DiRR70gTRKMiFte9TsxXyUj/mr0H03sCUCielaOY1BGqrz/AyIYrpeEtAEkrBlkqyllahqb5ZTLWLXgFN82hC6vT5Hta9+vO+6t6J2V087yb/CYOGgJAzr1QkZGngmdUzwc0ULXc1rfzHYJPxjNRPKgRae0Hui1/CQai9/MeF99VJPtP7b8sy7AooDLOXCA2p8rl1G3lf1G3Ag6hRc1U9RXlEyjrrCL8ZLODlw119UUb1rFjiZZArMUmr75NYaH6/v0jEvEMoYeJSNqmWAF7/cLyEsWTP4U3VBXMeTfyiBz7TM3cZwsBoRievbr0zYQY6WjWQZxZKj26j1ysow9GGUy0R/gc8aLxam1BTpuw0AsR71Jsx4HZ2JAR9tLImIta8WFWX6GUSg75TH2nDV3N/dvM4LTN45Ywz4MGj31dHqlPBqFDmMQC7u88z51WUFC+iPfnd1ljKw8V6/NbU6l4ijZSfg0/iAbVf8CpEaCzP21/i37JJWSN8cyTaoxX7tcOLTXyc793ZsF95RNorudQjwe2qze5qV3+YFVczQZvd8tcAgCZvZJP+BbrUOTElG0CIuu5UbsUtyVMT2mu2IyIiSZfOwz7dHOjiIwp5idLU0HEIwJ+4AD4fjGMLdaaDVsvaCRs/I7I/K6dyuG4Ia+Hv47eqvlkeV3Coz5gPGHA/zF4u/66EWQpNMOJ8UhQCXoOwbZM9bUI4U5Zi187JAtyjkW38UYQQNJecbn3HaUxPSx54ZZHNaTJfMUoV43LyD373DFb05Yacgs0gB6mPThtG6TEfXqMhrCGe65ZIPDexmsrRqLOQgXrrLySXCNTCnpa6yWL5lW2zEqny5Gv2k1xGOZLHkkuw1B9+l/bhEvgwKZWDHBGIKwVMIUNSfoyNu X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0668c8d6-2274-421a-b10d-08dd59ea6d9a X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3424.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2025 00:29:15.7688 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB2258 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Liliana Marie Prikler writes: > Hi folks, > > this patch adds code – similar to what we have in other ecosystems – to > make an educated guess on what test framework is used and use it. Newly > packaged Emacs libraries should thus expect to be tested with tests > needing to be explicitly disabled otherwise; just like in the rest of > Guix. > > Cheers Looks good to me just reading through them. Some of the test commands looks a little complicated though with a lot of boiler plate (like emacs-list-utils). Any thoughts on perhaps using a helper function like the (untested) attached patch? From 631833f951e52047a4b8ea3a5598ec0b377a67d4 Mon Sep 17 00:00:00 2001 Message-ID: <631833f951e52047a4b8ea3a5598ec0b377a67d4.1740961610.git.Morgan.J.Smith@outlook.com> From: Morgan Smith Date: Sun, 2 Mar 2025 19:18:44 -0500 Subject: [PATCH] guix: emacs-utils: Add new function 'emacs-batch-eval-command'. * guix/build/emacs-utils.scm(emacs-batch-eval-command): New function. (emacs-batch-eval): Define in terms of 'emacs-batch-eval-command'. Change-Id: I27c10bc7a93be02385ad47cadd124379bcaaad52 --- guix/build/emacs-utils.scm | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/guix/build/emacs-utils.scm b/guix/build/emacs-utils.scm index aeb364133a..dea062897e 100644 --- a/guix/build/emacs-utils.scm +++ b/guix/build/emacs-utils.scm @@ -63,12 +63,22 @@ (define (expr->string expr) expr (format #f "~s" expr))) +(define* (emacs-batch-eval-command expr #:key (load-directories '()) + (load-files '()) dynamic?) + "Return a command to run Emacs in batch mode, and execute the Elisp code +EXPR. If LOAD-DIRECTORIES is a list of directories, add them to the load path +before running EXPR. If LOAD-FILES is a list of files, load them before +running EXPR. DYNAMIC? is true, evaluate using dynamic scoping." + `("emacs" "--quick" "--batch" + ,@(map (lambda file) (string-append "--directory=" file) load-files) + ,@(map (lambda file) (string-append "--load=" file) load-files) + (format #f "--eval=(eval '~a ~:[t~;nil~])" + (expr->string expr) dynamic?))) + (define* (emacs-batch-eval expr #:key dynamic?) "Run Emacs in batch mode, and execute the Elisp code EXPR. If DYNAMIC? is true, evaluate using dynamic scoping." - (invoke (%emacs) "--quick" "--batch" - (format #f "--eval=(eval '~a ~:[t~;nil~])" - (expr->string expr) dynamic?))) + (invoke (%emacs) (cdr (emacs-batch-eval-command expr #:dynamic dynamic)))) (define (emacs-batch-edit-file file expr) "Load FILE in Emacs using batch mode, and execute the elisp code EXPR." -- 2.48.1