diff mbox series

[bug#77592] gnu: emacs-sv-kalender-namnsdagar: Skip tests.

Message ID CH3PR02MB97467F2B09A5B01F5B94496490AA2@CH3PR02MB9746.namprd02.prod.outlook.com
State New
Headers
Series [bug#77592] gnu: emacs-sv-kalender-namnsdagar: Skip tests. |

Commit Message

yelninei--- via Guix-patches via April 7, 2025, 1:28 a.m. UTC

Comments

Christopher Baines April 11, 2025, 11:06 a.m. UTC | #1 
"King, Spencer via Guix-patches" via <guix-patches@gnu.org> writes:

> [2. 0001-gnu-emacs-sv-kalender-namnsdagar-Skip-tests.patch --- text/x-patch; 0001-gnu-emacs-sv-kalender-namnsdagar-Skip-tests.patch]...

This patch seems redundant, according to QA it doesn't change any
derivations and the package seems to build for me without this change.

What is your motivation for adding #:tests? #f to the arguments?
Liliana Marie Prikler April 11, 2025, 4:51 p.m. UTC | #2 
Am Freitag, dem 11.04.2025 um 12:06 +0100 schrieb Christopher Baines:
> "King, Spencer via Guix-patches" via <guix-patches@gnu.org> writes:
> 
> > [2. 0001-gnu-emacs-sv-kalender-namnsdagar-Skip-tests.patch ---
> > text/x-patch; 0001-gnu-emacs-sv-kalender-namnsdagar-Skip-
> > tests.patch]...
> 
> This patch seems redundant, according to QA it doesn't change any
> derivations and the package seems to build for me without this
> change.
> 
> What is your motivation for adding #:tests? #f to the arguments?
We won't be skipping tests once emacs-team is merged.

It looks like the patch-prefix is wrong here.

Cheers
diff mbox series

Patch

From 58b92c4d1e35e01c228ba3a768ee830fa7c2601d Mon Sep 17 00:00:00 2001
From: Spencer King <spencer.king@wustl.edu>
Date: Sun, 6 Apr 2025 19:52:33 -0500
Subject: [PATCH] gnu: emacs-sv-kalender-namnsdagar: Skip tests.

* gnu/packages/emacs-xyz.scm (emacs-sv-kalender-namnsdagar)[arguments]: Add #:tests? #f.

Change-Id: I5f4fb3130d4ca7f6ac686d4fe30af6e6725719e4
---
 gnu/packages/emacs-xyz.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 7ff2296cf6..2cdd0e95b8 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -40413,7 +40413,7 @@  (define-public emacs-uml-mode
       (license license:gpl3+))))
 
 (define-public emacs-sv-kalender-namnsdagar
-  (let ((commit "31ef6ac82e448de3db1cf0c37df54581eb9b00f6")) ;versiom bump
+  (let ((commit "31ef6ac82e448de3db1cf0c37df54581eb9b00f6")) ; version bump
     (package
       (name "emacs-sv-kalender-namnsdagar")
       (version "1.0")
@@ -40427,6 +40427,7 @@  (define-public emacs-sv-kalender-namnsdagar
          (sha256
           (base32 "1sv5p2f0i4zhfrh8pv39p5aaa9wnbzxkb58p9qslw7qli1wax2l0"))))
       (build-system emacs-build-system)
+      (arguments (list #:tests? #f)) ; no tests 
       (home-page "https://github.com/matsl/sv-kalender-namnsdagar")
       (synopsis "Swedish name day calendar")
       (description

base-commit: f795209d51e39ce56f0e1947cd2c02d0b357a01c
-- 
2.41.0