Message ID | CAO0k7008t9g14PM_9iLJ+VYHFF2c7EQLofCriaXCNky006s5ZQ@mail.gmail.com |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 9787227BBEB; Fri, 20 Jan 2023 12:45:39 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 05E4F27BBE9 for <patchwork@mira.cbaines.net>; Fri, 20 Jan 2023 12:45:37 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1pIqlX-0008P8-3Y; Fri, 20 Jan 2023 07:45:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1pIqlU-0008Ol-Hf for guix-patches@gnu.org; Fri, 20 Jan 2023 07:45:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1pIqlT-0003E7-Eu for guix-patches@gnu.org; Fri, 20 Jan 2023 07:45:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1pIqlS-0007EC-RR for guix-patches@gnu.org; Fri, 20 Jan 2023 07:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60640] Gnu: Add gdcm Resent-From: =?utf-8?q?Tor-bj=C3=B6rn?= Claesson <tclaesson@gmail.com> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 20 Jan 2023 12:45:02 +0000 Resent-Message-ID: <handler.60640.B60640.167421866227713@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60640 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org> Cc: 60640@debbugs.gnu.org Received: via spool by 60640-submit@debbugs.gnu.org id=B60640.167421866227713 (code B ref 60640); Fri, 20 Jan 2023 12:45:02 +0000 Received: (at 60640) by debbugs.gnu.org; 20 Jan 2023 12:44:22 +0000 Received: from localhost ([127.0.0.1]:45799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1pIqko-0007Cu-D0 for submit@debbugs.gnu.org; Fri, 20 Jan 2023 07:44:22 -0500 Received: from mail-ed1-f51.google.com ([209.85.208.51]:43965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <tclaesson@gmail.com>) id 1pIqkm-0007Cg-K5 for 60640@debbugs.gnu.org; Fri, 20 Jan 2023 07:44:21 -0500 Received: by mail-ed1-f51.google.com with SMTP id x10so6598132edd.10 for <60640@debbugs.gnu.org>; Fri, 20 Jan 2023 04:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YgEp3a4QAH84hNWysu4sA/YbCTCsqUhH9zMyaJUxh58=; b=hPf71scYCcDk3qQ4gm4GB3/YKYxbpVeSAj4RDF7QJvBGsByKA2E79LaTXF79XGA6wQ G60z23uX0qzkqIVDWCU3ZSYEmjBOXGrTLzLFpF/xk0X98Tp6QHlU5Jx17Obk+PhY628z dg1IKXNJi1gvyUgH97uQBudR0wnOc3PssJFbIBE7sx4hSWxYMYhAswxpV0JUcOtdSvBN PGbbCCK04Ij3HcRq40CQi5QwlxAVRZxa5A5RfcIwqSfSh8z8/dYd7n1e0lT+ABbPL81L S1boFuZm0tiz4BfTyOwmwmpCb62gZikIPRr29gWOUKdgciV78rAuSnhmjeBtllnKlr2Q CPWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YgEp3a4QAH84hNWysu4sA/YbCTCsqUhH9zMyaJUxh58=; b=1qMtmtEcJhXETc5p1ihT4bVOJJjA40rHOwiLs2cPhT59yBnrCHwyqBS/AXkWUXrgCJ loaUbLYDUFG1Mgrejtqd0BTrudDuRtS/n/czVSiD3LSZ7jqecJBBNMwkLGteLPhgZYUz nFrucKQmfVqshyW58YlARef9o9UWhXLa9nxfxwUEbK4VfH4LkWdkv3ea78XPcgUFUwzg Os/EkelBrx6zUGPxTAreaDIKB60jkQ90Zvpqp0nvxziSoLd6jn+aQDxN80K10n83w0pS gFMbhhcokLEr1QztQlC6/Bw1v2Zlc+41pUHTAfboS/BdJT9WKwYkqMJPSjeonxvZdE9p Wbrg== X-Gm-Message-State: AFqh2kpRg4R4f1ex3uptDsCWV3rT9zVOguhZ2DIvco9HVq8TD5VqTq4g Xu9rXj2UN1sfLEOnovBPsrzVfUVqdS7k7hSBhOY= X-Google-Smtp-Source: AMrXdXtYHP+vd+gjEU1QGqLSuLWvM0JO+S9/P6xL6Fl/Pk/x0uGaLUKGaKYWTNLkSi70Cca3+XB1Xm9YREr+o0tQPzM= X-Received: by 2002:a05:6402:22f7:b0:49b:651d:7930 with SMTP id dn23-20020a05640222f700b0049b651d7930mr1691084edb.79.1674218654291; Fri, 20 Jan 2023 04:44:14 -0800 (PST) MIME-Version: 1.0 References: <877cxyp1wf.fsf@gmail.com> <handler.60640.B.167314095112989.ack@debbugs.gnu.org> <87y1qdo3qq.fsf@gmail.com> <87wn5rfldh.fsf_-_@gnu.org> <875ydau2vf.fsf@gmail.com> <87wn5q9epc.fsf@gnu.org> <87bkn1m4dj.fsf@gmail.com> <875yd5i5v8.fsf@gnu.org> <CAO0k701MZkkzQ9=qA-BRsYjUEZT57Qo6qcOmGAebZ==5fYgEsw@mail.gmail.com> In-Reply-To: <CAO0k701MZkkzQ9=qA-BRsYjUEZT57Qo6qcOmGAebZ==5fYgEsw@mail.gmail.com> From: =?utf-8?q?Tor-bj=C3=B6rn?= Claesson <tclaesson@gmail.com> Date: Fri, 20 Jan 2023 14:44:02 +0200 Message-ID: <CAO0k7008t9g14PM_9iLJ+VYHFF2c7EQLofCriaXCNky006s5ZQ@mail.gmail.com> Content-Type: multipart/mixed; boundary="0000000000002a86f105f2b16820" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#60640] Gnu: Add gdcm
|
|
Commit Message
Tor-björn Claesson
Jan. 20, 2023, 12:44 p.m. UTC
Also, I can't build gdcm from the main guix repo although it builds perfectly fine in my local checkout. The cause is three failing tests. Attached is a patch to ignore them. I'm really sorry about this. Is there something else I could have done to catch this before submitting? Tor-björn Claesson Den fre 20 jan. 2023 kl 13:30 skrev Tor-björn Claesson <tclaesson@gmail.com >: > Hi, > > Den tis 17 jan. 2023 kl 16:38 skrev Ludovic Courtès <ludo@gnu.org>: > >> >> In general, we don’t install documentation as PDF/PS, unless there’s no >> other choice (preferred formats are Info, man pages, and HTML). >> >> Is there such an option? >> > The new version of the patch builds HTML documentation, but not man-pages > (because of a xsl-requirement and including libxslt as a native input > causes the build to fail.) > > I wrote the previous answer in a rush, and failed to properly address this > question. For this I apologize, it was not meant to be disrespectful. > > Tor-björn >
Comments
Hi, Tor-björn Claesson <tclaesson@gmail.com> skribis: > From e1e8d18c4db9de4c8f46354ba3fc912f23ebe9d0 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Tor-bj=C3=B6rn=20Claesson?= <tclaesson@gmail.com> > Date: Fri, 20 Jan 2023 14:38:39 +0200 > Subject: [PATCH] gnu: gdcm: Ignore 3 failing tests. > > --- > gnu/packages/bioinformatics.scm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm > index e60dffc21e..c23f731687 100644 > --- a/gnu/packages/bioinformatics.scm > +++ b/gnu/packages/bioinformatics.scm > @@ -17861,6 +17861,9 @@ (define-public gdcm > "'TestFileMetaInformation" > "|TestElement2" > "|TestSCUValidation" > + "|TestWriter" > + "|TestAnonymizer4" > + "|TestPrinter1" > "|TestEcho" Applied, thanks! It would be nice if you could investigate the test failures: they might reveal that something’s wrong with our packaging. Ludo’.
Tor-björn Claesson <tclaesson@gmail.com> skribis: > From e1e8d18c4db9de4c8f46354ba3fc912f23ebe9d0 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Tor-bj=C3=B6rn=20Claesson?= <tclaesson@gmail.com> > Date: Fri, 20 Jan 2023 14:38:39 +0200 > Subject: [PATCH] gnu: gdcm: Ignore 3 failing tests. Actually I’m seeing more test failures in a -c24 build: --8<---------------cut here---------------start------------->8--- 195/217 Test #195: TestStrictScanner1 .....................***Failed 0.01 sec No such directory: /tmp/guix-build-gdcm-3.0.20.drv-0/build/Testing/Temporary/TestWriter Start 196: TestStrictScanner2_1 196/217 Test #196: TestStrictScanner2_1 ...................***Failed 0.01 sec No such directory: /tmp/guix-build-gdcm-3.0.20.drv-0/build/Testing/Temporary/TestWriter Start 197: TestStrictScanner2 197/217 Test #197: TestStrictScanner2 .....................***Failed 0.02 sec No such directory: /tmp/guix-build-gdcm-3.0.20.drv-0/build/Testing/Temporary/TestWriter Start 198: TestStrictScanner2_2 198/217 Test #198: TestStrictScanner2_2 ...................***Failed 0.02 sec No such directory: /tmp/guix-build-gdcm-3.0.20.drv-0/build/Testing/Temporary/TestWriter […] 98% tests passed, 4 tests failed out of 217 Total Test time (real) = 596.45 sec The following tests FAILED: 195 - TestStrictScanner1 (Failed) 196 - TestStrictScanner2_1 (Failed) 197 - TestStrictScanner2 (Failed) 198 - TestStrictScanner2_2 (Failed) Errors while running CTest --8<---------------cut here---------------end--------------->8--- Passing #:parallel-tests? #f doesn’t help. Could you take a look? TIA, Ludo’.
Hi again! Ludovic Courtès <ludo@gnu.org> writes: > It would be nice if you could investigate the test failures: they might > reveal that something’s wrong with our packaging. Maybe the following is of any help, I was confused by the TestWriter etc. passing in my local checkout, but not when I later tried to build gdcm from the real guix repository. This can be reproduced as follows: 1. Check out and build the original commit to add gdcm 2.8.9 (15caeb745c) 2. Check out and build the "upgrade to 3.0.20" commit (2bdbd962e3) Now the tests suddenly pass. What does the build of 2.8.9 leave behind? I'm still really confused by this!
From e1e8d18c4db9de4c8f46354ba3fc912f23ebe9d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor-bj=C3=B6rn=20Claesson?= <tclaesson@gmail.com> Date: Fri, 20 Jan 2023 14:38:39 +0200 Subject: [PATCH] gnu: gdcm: Ignore 3 failing tests. --- gnu/packages/bioinformatics.scm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm index e60dffc21e..c23f731687 100644 --- a/gnu/packages/bioinformatics.scm +++ b/gnu/packages/bioinformatics.scm @@ -17861,6 +17861,9 @@ (define-public gdcm "'TestFileMetaInformation" "|TestElement2" "|TestSCUValidation" + "|TestWriter" + "|TestAnonymizer4" + "|TestPrinter1" "|TestEcho" "|TestFind'")))) (home-page "https://gdcm.sourceforge.net/wiki/index.php/Main_Page") -- 2.38.1