diff mbox series

[bug#46237] Add new jplephem

Message ID CAO+9K5q5XQJTEVsX5j+tgV96b1SptpS0vrm2HSLpCN5GWPZ5AA@mail.gmail.com
State Accepted
Headers show
Series [bug#46237] Add new jplephem | expand

Checks

Context Check Description
cbaines/submitting builds success
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Sharlatan Hellseher Feb. 1, 2021, 3:01 p.m. UTC 
Hi Guix team!

I continue adding astronomy packages.
Is it better to put Python packages to python-science or it's ok to
keep them in astronomy?

Comments

Nicolas Goaziou Feb. 7, 2021, 9:24 a.m. UTC | #1 
Hello,

Sharlatan Hellseher <sharlatanus@gmail.com> writes:

> Is it better to put Python packages to python-science or it's ok to
> keep them in astronomy?

I think "astronomy.scm" is fine.

> Subject: [PATCH] gnu: Add jplephem
>
> * gnu/packages/astronomy.scm (python-jplephem): New variable

Applied. Thank you!

> +;;; Python based packages completely related to Astronomy

I removed this comment since I think it might add burden to packagers.
IMO, alphabetical or random (!) sorting are fine, but sub-categories in
a module is a bit too much for package definitions.

> +    (description
> +     "Use a JPL ephemeris to predict planet positions.")

I expounded the description a bit, following README from repository.

Regards,
diff mbox series

Patch

From be78bcfd45dd5ac76da8882344198235b5952c71 Mon Sep 17 00:00:00 2001
From: Sharlatan Hellseher <sharlatanus@gmail.com>
Date: Mon, 1 Feb 2021 14:56:41 +0000
Subject: [PATCH] gnu: Add jplephem

* gnu/packages/astronomy.scm (python-jplephem): New variable
---
 gnu/packages/astronomy.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm
index 9777b0008f..6748d2dff1 100644
--- a/gnu/packages/astronomy.scm
+++ b/gnu/packages/astronomy.scm
@@ -48,12 +48,14 @@ 
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages pretty-print)
+  #:use-module (gnu packages python-xyz)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages version-control)
   #:use-module (gnu packages xiph)
   #:use-module (gnu packages xorg)
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system python)
   #:use-module (ice-9 match)
   #:use-module (srfi srfi-1))
 
@@ -692,3 +694,36 @@  more.")
                    license:gpl2+
                    license:lgpl2.0+
                    license:lgpl2.1+))))
+
+;;; Python based packages completely related to Astronomy
+
+(define-public python-jplephem
+  (package
+    (name "python-jplephem")
+    (version "2.15")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "jplephem" version))
+       (sha256
+        (base32 "1ca3dswsslij79qg6dcijjz4l0fj6nzmxld8z93v45ahlkhps0g0"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (setenv "PYTHONPATH"
+                       (string-append "./build/lib:"
+                                      (getenv "PYTHONPATH")))
+               (setenv "PATH" (string-append out "/bin:"
+                                             (getenv "PATH")))
+               (invoke "python" "-m" "unittest" "discover" "-s" "test")))))))
+    (inputs
+     `(("python-numpy" ,python-numpy)))
+    (home-page "https://github.com/brandon-rhodes/python-jplephem")
+    (synopsis "Python version of NASA DE4xx ephemerides")
+    (description
+     "Use a JPL ephemeris to predict planet positions.")
+    (license license:expat)))
-- 
2.30.0