From patchwork Sat Nov 13 10:01:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sharlatan Hellseher X-Patchwork-Id: 34423 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 6382D27BBE3; Sat, 13 Nov 2021 10:03:26 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id BF84D27BBE1 for ; Sat, 13 Nov 2021 10:03:25 +0000 (GMT) Received: from localhost ([::1]:54824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlpsa-00069X-VF for patchwork@mira.cbaines.net; Sat, 13 Nov 2021 05:03:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlpsE-0005ph-Py for guix-patches@gnu.org; Sat, 13 Nov 2021 05:03:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35021) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlpsE-0002yE-HS for guix-patches@gnu.org; Sat, 13 Nov 2021 05:03:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mlpsE-00019f-ED for guix-patches@gnu.org; Sat, 13 Nov 2021 05:03:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51795] [PATCH] gnu: Add imppg Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 13 Nov 2021 10:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51795 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51795@debbugs.gnu.org Cc: Vinicius Monego Received: via spool by 51795-submit@debbugs.gnu.org id=B51795.16367977254346 (code B ref 51795); Sat, 13 Nov 2021 10:03:02 +0000 Received: (at 51795) by debbugs.gnu.org; 13 Nov 2021 10:02:05 +0000 Received: from localhost ([127.0.0.1]:46564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlprI-000181-Jr for submit@debbugs.gnu.org; Sat, 13 Nov 2021 05:02:05 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:56243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlprF-00017M-MU for 51795@debbugs.gnu.org; Sat, 13 Nov 2021 05:02:02 -0500 Received: by mail-wm1-f44.google.com with SMTP id p18so368941wmq.5 for <51795@debbugs.gnu.org>; Sat, 13 Nov 2021 02:02:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YaMMxA5PSXecnpLjD3lJXcvzSp9dcjmcT3NaOcowm9w=; b=g/Hgg5gRe9/07ka+PcpwwTXQHaRPMvGCekwn9PlbOxHZBmja4Rf/ylWzDPEu9E8cLF vqxL5M/T5DZU2WGvxPY8wO2XspSOz0h2fWXmHZltu81wEvw/fKP6pojLa8oDlNrbQDM5 Qih/VoDcDONILTW7dKeBu5sM8nOpo9vMA2tB6Do51ly5VovV29fM7yEcLMeTovXkp/SE NlxstUMDJ3riJTXZGKW6vRSdAu3JpUl1Jt18pA/NSLMEHWOuxK9+QLn+BHN3/LtkdQA1 tNcCgpwREm6+wb+vc+Dvkdaa1P6z+sDr2B46tRhrnyLaolQAdhI6IF/GbafBbHgCB0QA koZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YaMMxA5PSXecnpLjD3lJXcvzSp9dcjmcT3NaOcowm9w=; b=Qb+AQIz3maeWK9NoBdZvTRT1A5fCzP+0/c2/cIQm6qd2NqdNAb0fJO4H+fDkNe5Chv 1Uc1MUrU4bLaIfHyGiXHX3ELuc2RJR4X2/HvdPr6XuE6oBkLIts3RSy3hXFaGnS+kAEQ li3/fRY2kVmqH8Ao2IX+U1NgZeDaP5sQfiCgryGGNouLHMlpxp5gQbMhRAFGRdDym6TP /yTZHfRGWpi7a58ODFPpIseJusKW6ROhbEWvOsbyhhO5FARnCYen7K+rJiHklbzJA6dj IC3DmWoPUOV4xGrutn+ZxKapIOKf33iJQypmCcMKxhoD+VmubSpPFHx5BAEAU2N3b3It BMtw== X-Gm-Message-State: AOAM5305giIzrjOSzIO1xW+1EeqvA4uplzsO7+y0DtOi3K1EqXfvOg2v rEtBzDpa5mGEt+yK8UczU8T98d9XFrYZ2N08TwUgSzpbh/U= X-Google-Smtp-Source: ABdhPJx+x9vk3S2Nhu9i8AhhDcTfLO0SE3mjeDQhxCfXcNn6C6RSndy5A+Zc/YAhG5FTEVOJPXWfNmgvEBtcgFIMVmg= X-Received: by 2002:a7b:ce01:: with SMTP id m1mr29734885wmc.187.1636797715620; Sat, 13 Nov 2021 02:01:55 -0800 (PST) MIME-Version: 1.0 References: <787ad36ea96bc67fae2a016ffbb3e0d5670a1c14.camel@posteo.net> In-Reply-To: <787ad36ea96bc67fae2a016ffbb3e0d5670a1c14.camel@posteo.net> From: Sharlatan Hellseher Date: Sat, 13 Nov 2021 10:01:44 +0000 Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Vinicius, Thank you for your fead back, I've updated patch with your suggestions. successfully built /gnu/store/43jw7kaqriz7vb2vslkqjv3sn21gwdpf-imppg-0.6.4.drv On Sat, 13 Nov 2021 at 01:49, Vinicius Monego wrote: > > Hi Sharlatan, > > Em sex, 2021-11-12 às 21:21 +0000, Sharlatan Hellseher escreveu: > > * gnu/packages/astronomy.scm: (imppg): New variable. > > --- > > gnu/packages/astronomy.scm | 53 > > ++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > > > diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm > > index fc8959faad..57f62dc24d 100644 > > --- a/gnu/packages/astronomy.scm > > +++ b/gnu/packages/astronomy.scm > > @@ -32,6 +32,7 @@ (define-module (gnu packages astronomy) > > #:use-module (gnu packages) > > #:use-module (gnu packages algebra) > > #:use-module (gnu packages autotools) > > + #:use-module (gnu packages boost) > > #:use-module (gnu packages check) > > #:use-module (gnu packages compression) > > #:use-module (gnu packages curl) > > @@ -56,6 +57,7 @@ (define-module (gnu packages astronomy) > > #:use-module (gnu packages qt) > > #:use-module (gnu packages version-control) > > #:use-module (gnu packages video) > > + #:use-module (gnu packages wxwidgets) > > #:use-module (gnu packages xiph) > > #:use-module (gnu packages xml) > > #:use-module (gnu packages xorg) > > @@ -986,6 +988,57 @@ (define-public sgp4 > > It can be used to calculate the trajectory of satellites.") > > (license license:asl2.0)))) > > > > +(define-public imppg > > + (package > > + (name "imppg") > > + (version "0.6.4") > > + (source > > + (origin > > + (method git-fetch) > > + (uri (git-reference > > + (url (string-append > > "https://github.com/GreatAttractor/" name)) > > AFAIK we don't use 'name' in the url anymore, it should be hardcoded. > > > + (commit (string-append "v" version)))) > > + (file-name (git-file-name name version)) > > + (sha256 > > + (base32 > > "04synbmyz0hkipl1cdc26nr42r57v494yjw8pi4jx0jrxrawgj9h")))) > > + (build-system cmake-build-system) > > + (arguments > > + `(#:tests? #f ; No test provided > > + #:phases > > + (modify-phases %standard-phases > > + (replace 'configure > > + (lambda* (#:key outputs #:allow-other-keys) > > + (mkdir-p "build") > > + (chdir "build") > > + (invoke > > + "cmake" > > + "-G" "Unix Makefiles" > > + "-DCMAKE_BUILD_TYPE=Release" > > + (string-append "-DCMAKE_INSTALL_PREFIX=" (assoc-ref > > outputs "out")) > > + "..")))))) > > This is unusual. Why are we overriding the configure phase? I could > build the package just fine with the standard phase. > > CMAKE_BUILD_TYPE can be set to Release using '#:build-type "Release"'. > Other CMake variables can be changed in #:configure-flags. > > AFAIK Guix also avoids setting CMAKE_BUILD_TYPE to "Release" without a > good reason, such as debug symbols being too large. > > > + (native-inputs > > + `(("boost" ,boost) > > + ("pkg-config" ,pkg-config))) > > + (inputs > > + `(("cfitsio" ,cfitsio) > > + ("freeimage" ,freeimage) > > + ("glew" ,glew) > > + ("wxwidgets" ,wxwidgets))) > > + (home-page "https://github.com/GreatAttractor/imppg") > > + (synopsis "Astronomical Image Post-Proccessor (ImPPG)") > > + (description > > + "ImPPG performs Lucy-Richardson deconvolution, unsharp masking, > > brightness > > +normalization and tone curve adjustment. It can also apply > > previously specified > > +processing settings to multiple images. All operations are > > performed using > > +32-bit floating-point arithmetic. > > + > > +Supported input formats: FITS, BMP, JPEG, PNG, TIFF (most of bit > > depths and > > +compression methods), TGA and more. Images are processed in > > grayscale and can be > > +saved as: BMP 8-bit; PNG 8-bit; TIFF 8-bit, 16-bit, 32-bit floating- > > point (no > > +compression, LZW- or ZIP-compressed), FITS 8-bit, 16-bit, 32-bit > > +floating-point.") > > Description exceeded 78 columns in 3 lines. > > > + (license license:gpl3+))) > > + > > (define-public indi > > (package > > (name "indi") > > LGTM otherwise! > From 2d6b1d7984b899965d588328b7b792c6f6f21160 Mon Sep 17 00:00:00 2001 From: Sharlatan Hellseher Date: Sat, 13 Nov 2021 09:59:32 +0000 Subject: [PATCH] gnu: Add imppg * gnu/packages/astronomy.scm: (imppg): New variable. --- gnu/packages/astronomy.scm | 45 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm index fc8959faad..41f7a929dc 100644 --- a/gnu/packages/astronomy.scm +++ b/gnu/packages/astronomy.scm @@ -32,6 +32,7 @@ (define-module (gnu packages astronomy) #:use-module (gnu packages) #:use-module (gnu packages algebra) #:use-module (gnu packages autotools) + #:use-module (gnu packages boost) #:use-module (gnu packages check) #:use-module (gnu packages compression) #:use-module (gnu packages curl) @@ -56,6 +57,7 @@ (define-module (gnu packages astronomy) #:use-module (gnu packages qt) #:use-module (gnu packages version-control) #:use-module (gnu packages video) + #:use-module (gnu packages wxwidgets) #:use-module (gnu packages xiph) #:use-module (gnu packages xml) #:use-module (gnu packages xorg) @@ -986,6 +988,49 @@ (define-public sgp4 It can be used to calculate the trajectory of satellites.") (license license:asl2.0)))) +(define-public imppg + (package + (name "imppg") + (version "0.6.4") + (source + (origin + (method git-fetch) + (uri (git-reference + (url (string-append "https://github.com/GreatAttractor/imppg")) + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 "04synbmyz0hkipl1cdc26nr42r57v494yjw8pi4jx0jrxrawgj9h")))) + (build-system cmake-build-system) + (arguments + `(#:tests? #f ; No test provided + #:configure-flags + (list + (string-append + "-DCMAKE_INSTALL_PREFIX=" (assoc-ref %outputs "out"))))) + (native-inputs + `(("boost" ,boost) + ("pkg-config" ,pkg-config))) + (inputs + `(("cfitsio" ,cfitsio) + ("freeimage" ,freeimage) + ("glew" ,glew) + ("wxwidgets" ,wxwidgets))) + (home-page "https://github.com/GreatAttractor/imppg") + (synopsis "Astronomical Image Post-Proccessor (ImPPG)") + (description + "ImPPG performs Lucy-Richardson deconvolution, unsharp masking, +brightness normalization and tone curve adjustment. It can also apply +previously specified processing settings to multiple images. All operations +are performed using 32-bit floating-point arithmetic. + +Supported input formats: FITS, BMP, JPEG, PNG, TIFF (most of bit depths and +compression methods), TGA and more. Images are processed in grayscale and can +be saved as: BMP 8-bit; PNG 8-bit; TIFF 8-bit, 16-bit, 32-bit +floating-point (no compression, LZW- or ZIP-compressed), FITS 8-bit, 16-bit, +32-bit floating-point.") + (license license:gpl3+))) + (define-public indi (package (name "indi") -- 2.33.1