diff mbox series

[bug#46187] Refactor cl-online-leraning

Message ID CAO+9K5oBbhYTXnWVCcWibzEoDS99mx+JXGotCLfvWLKJEZO5qQ@mail.gmail.com
State Accepted
Headers show
Series [bug#46187] Refactor cl-online-leraning | expand

Checks

Context Check Description
cbaines/submitting builds success
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Sharlatan Hellseher Jan. 30, 2021, 11:15 a.m. UTC

Comments

Guillaume Le Vaillant Jan. 31, 2021, 9:30 a.m. UTC | #1 
Patch pushed as e11055f0125a902fe091394480dd4206c687a98c.
Thanks.
diff mbox series

Patch

From e2ef0372b788fc6a6f363ae23de6c62a00540b45 Mon Sep 17 00:00:00 2001
From: Sharlatan Hellseher <sharlatanus@gmail.com>
Date: Sat, 30 Jan 2021 11:08:26 +0000
Subject: [PATCH] gnu: Refactor cl-online-learning
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* gnu/packages/lisp-xyz.scm (sbcl-cl-online-learning)
  Revision 1
  Bumped to the latest commit and fix test passing

  (ecl-cl-online-learning) - it needs some proper attention, it throws a
  long warning output during build:

...
;;;;;;;;;;;;;;;; Dence, Binary ;;;;;;;;;;;;;;;;;
;;; Read libsvm dataset
  × Raised an error #<closed input stream /gnu/store/zqvp2ky4zl4rdimkjnkqqq0nrr88q2vf-ecl-cl-online-learning-0.5-1.87fbef8/share/common-lisp/ecl/cl-online-learning/t/dataset/a1a 0x7ffff47b6b40> is not a character stream
...
---
 gnu/packages/lisp-xyz.scm | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index bc959502be..286639bef2 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -10423,8 +10423,8 @@  format.")
   (sbcl-package->ecl-package sbcl-cl-libsvm-format))
 
 (define-public sbcl-cl-online-learning
-  (let ((commit "fc7a34f4f161cd1c7dd747d2ed8f698947781423")
-        (revision "0"))
+  (let ((commit "87fbef8a340219e853adb3a5bf44a0470da76964")
+        (revision "1"))
     (package
       (name "sbcl-cl-online-learning")
       (version (git-version "0.5" revision commit))
@@ -10437,7 +10437,7 @@  format.")
          (file-name (git-file-name name version))
          (sha256
           (base32
-           "14x95rlg80ay5hv645ki57pqvy12v28hz4k1w0f6bsfi2rmpxchq"))))
+           "1lfq04lnxivx59nq5dd02glyqsqzf3vdn4s9b8wnaln5fs8g2ph9"))))
       (build-system asdf-build-system/sbcl)
       (native-inputs
        `(("prove" ,sbcl-prove)))
@@ -10445,13 +10445,16 @@  format.")
        `(("cl-libsvm-format" ,sbcl-cl-libsvm-format)
          ("cl-store" ,sbcl-cl-store)))
       (arguments
-       `(;; FIXME: Tests pass but then the check phase crashes
-         #:tests? #f))
+       `(#:test-asd-file "cl-online-learning-test.asd"
+         #:asd-systems
+         (list
+          "cl-online-learning-test"
+          "cl-online-learning")))
+      (home-page "https://github.com/masatoi/cl-online-learning")
       (synopsis "Online Machine Learning for Common Lisp")
       (description
        "This library contains a collection of machine learning algorithms for
 online linear classification written in Common Lisp.")
-      (home-page "https://github.com/masatoi/cl-online-learning")
       (license license:expat))))
 
 (define-public cl-online-learning
-- 
2.30.0