From patchwork Mon Dec 2 12:08:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Tournier X-Patchwork-Id: 16341 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 80A14177B7; Mon, 2 Dec 2019 12:09:13 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id C4662177AC for ; Mon, 2 Dec 2019 12:09:12 +0000 (GMT) Received: from localhost ([::1]:34774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibkVs-0005qI-6C for patchwork@mira.cbaines.net; Mon, 02 Dec 2019 07:09:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48433) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibkVn-0005q9-C1 for guix-patches@gnu.org; Mon, 02 Dec 2019 07:09:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibkVi-0003Kl-HO for guix-patches@gnu.org; Mon, 02 Dec 2019 07:09:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59442) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibkVi-0003Kd-Cu for guix-patches@gnu.org; Mon, 02 Dec 2019 07:09:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ibkVh-0000Iq-Vf for guix-patches@gnu.org; Mon, 02 Dec 2019 07:09:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#38455] [PATCH] doc: Mention how to test against make / guix pull breakage. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Dec 2019 12:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38455 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Pierre Neidhardt Cc: 38455@debbugs.gnu.org Received: via spool by 38455-submit@debbugs.gnu.org id=B38455.15752885061108 (code B ref 38455); Mon, 02 Dec 2019 12:09:01 +0000 Received: (at 38455) by debbugs.gnu.org; 2 Dec 2019 12:08:26 +0000 Received: from localhost ([127.0.0.1]:37182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibkV8-0000Hn-2B for submit@debbugs.gnu.org; Mon, 02 Dec 2019 07:08:26 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:38909) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibkV6-0000Hb-Ct for 38455@debbugs.gnu.org; Mon, 02 Dec 2019 07:08:25 -0500 Received: by mail-qt1-f194.google.com with SMTP id 14so41118739qtf.5 for <38455@debbugs.gnu.org>; Mon, 02 Dec 2019 04:08:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Tzx/1NC2tCeEUutP1p7CniQTdX0PkqdCHkmHkGdkrns=; b=s+QZRkOld+r9AekAj8sWKA7r/CU47wX2UCZS9xxg43MmBiquDSJBikc+FAKR2znafD nxs1KQnhh/+L7b3XN7epluSY3h0jhw8hD6TZKUVjvH3wXDnX9TPltNU3imFffTSTNhdz vq8Ni2/ri/KT3AmsZr5vf0k+H3xsFU2Kz2lFaqmKHcjwCuH0O5BXlD8uWwZEXZTGpzMv EgGIepzat2V4uWct5A/pQ6nkJED4SRYNkMWOi+XyWxkryuzj7e2bQ4auZ8yg/ltEQvex 40dk0dkA73it/mBlTZSWBQvaaWVRXnR2PbrhHNYWBafubJYMSK3ndkhO31akLStxHuwC WpPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Tzx/1NC2tCeEUutP1p7CniQTdX0PkqdCHkmHkGdkrns=; b=SBTboFHccjquhJPk8cgPO14Cb+nBRytaynM8Nlahh1ikMTHndu/jP0+30joi/YDFxt q4JSkzWdLdQJFcVwDnvAO3RFHLcuBfDXYS7eYZhi2P/r9Lvkq0cO+0pvq7aFYckIwPLy KMkGwJ2jGx566+u0/aKUt+MqcL4A8fEQXuNPv/apjWzmPXyDUVFLvwqHnzclppHkHCSh doIyj6jtcnQ2HclJpgY7PEJOQ0jIqdGReM5OGT1tyPL/Pwyp6kFAfIMrWGlD8UfHEt2p iKjO2x/lP73fwqGM5XlpfozlHKZ9BmHNA8TmPGpTSxqzM/+OBciDXvq9ml4WDvd5NUhi 50Yw== X-Gm-Message-State: APjAAAXuK1wPXgpbIGNhNeb9LJ+pczRTfh8we3oOu9SBSXx7U4j9Vwmc MILJkzbp/S7Dq5NwuL82zMb/I0YF5WNVwkHEhth+mnOs X-Google-Smtp-Source: APXvYqwA6o06XuyFQpqMzsyUw4652KqLmBSz6hKea28+iGCus8v+IVEsI0HHRjILF6KZP3yvMWyqRsK7lP7zy0Rz//Q= X-Received: by 2002:ac8:7957:: with SMTP id r23mr64299074qtt.211.1575288498895; Mon, 02 Dec 2019 04:08:18 -0800 (PST) MIME-Version: 1.0 References: <20191202091550.15132-1-mail@ambrevar.xyz> In-Reply-To: <20191202091550.15132-1-mail@ambrevar.xyz> From: zimoun Date: Mon, 2 Dec 2019 13:08:07 +0100 Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Pierre, On Mon, 2 Dec 2019 at 10:16, Pierre Neidhardt wrote: > * doc/contributing.texi (Submitting Patches): Mention commands in the check > list. Nice! I propose instead this wording. Because, I am not sure that building Guix from source is really necessary to run/check "guix pull". --8<---------------cut here---------------start------------->8--- When posting a patch to the mailing list, use @samp{[PATCH] @dots{}} as --8<---------------cut here---------------end--------------->8--- Hope that helps. Cheers, simon diff --git a/doc/contributing.texi b/doc/contributing.texi index ee72b2f94d..8001b0aef1 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -961,6 +961,15 @@ often better to clone the repository. Don't use the @command{name} field in the URL: it is not very useful and if the name changes, the URL will probably be wrong. +@item +Make sure your changes do not break @command{guix pull}: + +@example +guix pull --dry-run --url=/path/to/your/checkout +@end example + +(see @pxref{Invoking guix pull}). + @end enumerate