From patchwork Thu Jun 2 12:09:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Lechner X-Patchwork-Id: 2779 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 4B6D927BBE9; Thu, 2 Jun 2022 14:48:53 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 5EC4627BBEA for ; Thu, 2 Jun 2022 14:48:49 +0100 (BST) Received: from localhost ([::1]:39084 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwlBw-0004vW-II for patchwork@mira.cbaines.net; Thu, 02 Jun 2022 09:48:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwjeM-0002v4-Kt for guix-patches@gnu.org; Thu, 02 Jun 2022 08:10:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwjeM-0004tb-8B for guix-patches@gnu.org; Thu, 02 Jun 2022 08:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nwjeM-0006x1-3Q for guix-patches@gnu.org; Thu, 02 Jun 2022 08:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55762] [PATCH] Upgrade linux-pam to 1.5.2 Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Jun 2022 12:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 55762 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55762@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165417179826701 (code B ref -1); Thu, 02 Jun 2022 12:10:01 +0000 Received: (at submit) by debbugs.gnu.org; 2 Jun 2022 12:09:58 +0000 Received: from localhost ([127.0.0.1]:52986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwjeE-0006wX-9V for submit@debbugs.gnu.org; Thu, 02 Jun 2022 08:09:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:51560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwje9-0006wN-BV for submit@debbugs.gnu.org; Thu, 02 Jun 2022 08:09:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49434) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwje9-0002aw-59 for guix-patches@gnu.org; Thu, 02 Jun 2022 08:09:49 -0400 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:35574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwje7-0004Qi-1b for guix-patches@gnu.org; Thu, 02 Jun 2022 08:09:48 -0400 Received: by mail-lf1-x130.google.com with SMTP id a2so7494227lfc.2 for ; Thu, 02 Jun 2022 05:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=v2L1CHaNalV4SZ/pNLgf6i2F2oBuIXoRQMZfSe/dhIA=; b=HycnquhB2FIUM74ovHCcR4aDl+sR+NoxYcipzmqCXcY9vIY8uAXLKFbaCZrB7oPC3F BMr1Yvn79EKUkG7kM8SNCiR4ehjUkDH6BA4awELrJQY7X8+odWFjmIU1A5GVTWrBf+iG pgXx5URm3HXAyqKfZflB4k/S6s+jmmjSsvnhJRXU5pszz4thj83hy6JIQXTbvw85tlH8 drTFpjTO8E8dIibbdeK8NKBR/W0El7P5F0QTyOtK1iw4K0MjCw/+DHr14pncsWDkbB8v 7vTKOOtZlVaHY1+ttkyOYXjH39gQRgEMmXSM78prfERsySt6I+c1UhPK3aNwSEu+fgTh 4QKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=v2L1CHaNalV4SZ/pNLgf6i2F2oBuIXoRQMZfSe/dhIA=; b=ZT3/hLzGC/+lVY1AxSN0OizXmVogY76Ox5cCpIHNFoopiAvp9lSfhxFmgTMA1I1Lys rQJixDDS96hUeiIkvl4/R4+2x05JmjLDBtP0ixuK+dfgRORr2YDtl6rcIjdEjDca0i2Y aY96WEyCsTBLFqDYr8j6LebSSilNqc1usuB5OL9iZFxh52AMOaR33VtSbKATiqvEKFZE Z4eUqJUNnNjxA6TvQa2DEoxrXaJ1xIQz47m5gs2wrtl6krDR9zSUN2TzilD4OsdMjkpx n+8tQzG9HHshwEUV9hXsw3Xh2iARl80N860oMC3GdN9Qs/jGZaGmyeR8CWWM5+yfdqK1 UpQw== X-Gm-Message-State: AOAM533182Uyup9CdXc0SDRobQSqXzz8dNEaYGUYhMtMzipgYr8cRCJW JB+8SQk2r2nfm/7Fa7BbN5B7B5K+fHbfvRHUAyfcLRxQmOk= X-Google-Smtp-Source: ABdhPJwiIZDyzNxpi2hQJlHNrMp7jS0Ajga6eYcc1hrySI6AyB0nKY44wCaSP840y4pU+MyVfoy3BSreuKqjq6DHwks= X-Received: by 2002:a05:6512:696:b0:478:5a76:d2e with SMTP id t22-20020a056512069600b004785a760d2emr3334460lfe.224.1654171783590; Thu, 02 Jun 2022 05:09:43 -0700 (PDT) MIME-Version: 1.0 From: Felix Lechner Date: Thu, 2 Jun 2022 05:09:07 -0700 Message-ID: Received-SPF: pass client-ip=2a00:1450:4864:20::130; envelope-from=felix.lechner@gmail.com; helo=mail-lf1-x130.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Thu, 02 Jun 2022 09:48:23 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Control: tags -1 + patch Hi, For my work in making PAM configurable in Guile, I rely on the foreign function interface (FFI). The automatic generation of that interface requires Pkgconfig files. Those files are not available in Guix. Linux-PAM started shipping them in the release after the one we have. The attached patch upgrades linux-pam to version 1.5.2. The changes are further documented in the commit message. I am new to Guix and already use the new version of linux-pam locally (via Guix System) but I was unable to test the patch according to the requirements and recommendations listed for this submission. [1] This email was sent to -devel in lieu of -mentors, which does not exist. Any guidance is much appreciated. Thanks for taking a look! KInd regards Felix Lechner [1] https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html From 592d8156014090fefe8b9b1da8cada6aa2fa120a Mon Sep 17 00:00:00 2001 From: Felix Lechner Date: Tue, 31 May 2022 11:40:04 -0700 Subject: [PATCH] Update linux-pam to 1.5.2. This version ships three Pkgconfig files for Linux-PAM that make it possible to generate automatic FFI bindings via 'nyacc compile-ffi'. The current PAM version in Guix offers no Pkgconfig files at all. Upstream started shipping them in version 1.5.2. The extra argument to ./configure is needed to sidestep an issue upstream. [1] [1] https://github.com/linux-pam/linux-pam/issues/466 --- gnu/packages/linux.scm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 2af32fc88f..8a08a56bb4 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -1579,7 +1579,7 @@ (define-public xpadneo (define-public linux-pam (package (name "linux-pam") - (version "1.5.1") + (version "1.5.2") (source (origin (method url-fetch) @@ -1588,7 +1588,7 @@ (define-public linux-pam version "/Linux-PAM-" version ".tar.xz")) (sha256 (base32 - "1z4jayf69qyyxln1gl6ch4qxfd66ib1g42garnrv2d8i1drl0790")) + "0kgrsj2scv5mx6w925h9hxf11jnqqs9z8s22aw94b90xm4qp3v74")) (patches (search-patches "linux-pam-no-setfsuid.patch")))) (build-system gnu-build-system) @@ -1604,6 +1604,9 @@ (define-public linux-pam #:configure-flags (list (string-append "--includedir=" (assoc-ref %outputs "out") "/include/security") + (string-append "--libdir=" + (assoc-ref %outputs "out") + "/lib") ;; XXX: is missing from glibc when ;; cross-compiling, so we have to disable NIS base-commit: 20432b839b6bc9e30c156d412597b734a726940d -- 2.36.1