diff mbox series

[bug#40559] gnu: cryptsetup: Update to 2.3.1.

Message ID CAEwRq=rGgXCDNhbxZZkgQVCxnjxMdedVCTPBUojdA-ZR1jQMiw@mail.gmail.com
State Accepted
Headers show
Series [bug#40559] gnu: cryptsetup: Update to 2.3.1. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job

Commit Message

Vincent Legoll April 11, 2020, 5:14 p.m. UTC 
Untested

Comments

Ludovic Courtès April 16, 2020, 4:22 p.m. UTC | #1 
Hi,

Vincent Legoll <vincent.legoll@gmail.com> skribis:

> Untested

Could you test it with “make check-system TESTS=encrypted-root-os”?
It takes time and disk space, but that’s a good way to make sure
cryptsetup is still able to decrypt our LUKS partitions.

TIA!
Ludo’.
Vincent Legoll April 16, 2020, 9:36 p.m. UTC | #2 
On 16/04/2020 18:22, Ludovic Courtès wrote:
> Hi,
> 
> Vincent Legoll <vincent.legoll@gmail.com> skribis:
> 
>> Untested
> 
> Could you test it with “make check-system TESTS=encrypted-root-os”?
> It takes time and disk space, but that’s a good way to make sure
> cryptsetup is still able to decrypt our LUKS partitions.

OK, I'm trying it, but seems stuck.

Almost two hours passed since one of the tests has begun, and it
looks like it does not make any progress.

output is here:

--------------------------------8<-----------------------------------
SeaBIOS (version rel-1.12.0-59-gc9ba5276e321-prebuilt.qemu.org)


iPXE (http://ipxe.org) 00:03.0 CA00 PCI2.10 PnP PMM+0FF90830+0FEF0830 CA00
 



Booting from Hard Disk...
GRUB loading..
Welcome to GRUB!

Attempting to decrypt master key...
Enter passphrase for hd0,gpt2 (12345678123412341234123456789abc):
Slot 0 opened
--------------------------------8<-----------------------------------

guixbui+ 14560  0.7  1.6 682316 275948 ?       Sl   21:47   0:45 
  \_ 
/gnu/store/pzqfxg3kihc6zqdg581ww7mgnwhbh7bh-qemu-minimal-4.2.0/bin/qemu-system-x86_64 
-no-reboot -m 256 -drive file=disk.img,if=virtio -nographic -monitor 
unix:/tmp/monitor -chardev socket,id=repl,path=/tmp/repl -device 
virtio-serial -device virtserialport,chardev=repl,name=org.gnu.guix.port.0

started at 21:47, it's now 23:30

It's running in a VM with lots of ram & cores, virtual disk on a nvme,
my patch rebased on guix/master at:
90ec7085793700552359d9d409287528437f0280

Anything more I can do ?
Ludovic Courtès April 18, 2020, 4:34 p.m. UTC | #3 
Hi Vincent,

Vincent Legoll <vincent.legoll@gmail.com> skribis:

> Almost two hours passed since one of the tests has begun, and it
> looks like it does not make any progress.
>
> output is here:
>
> SeaBIOS (version rel-1.12.0-59-gc9ba5276e321-prebuilt.qemu.org)
>
>
> iPXE (http://ipxe.org) 00:03.0 CA00 PCI2.10 PnP PMM+0FF90830+0FEF0830 CA00
>  
>
>
>
> Booting from Hard Disk...
> GRUB loading..
> Welcome to GRUB!
>
> Attempting to decrypt master key...
> Enter passphrase for hd0,gpt2 (12345678123412341234123456789abc):
> Slot 0 opened

Hmm looks like your reached GRUB of the installed system, which is
rather good.  I don’t see why it would hang here.

If you interrupt it and re-run “make check-system …”, does that get any
further?

Is there space left on /gnu and /tmp?

Thanks,
Ludo’.
Vincent Legoll April 19, 2020, 6:27 p.m. UTC | #4 
Hello,

On 18/04/2020 18:34, Ludovic Courtès wrote:
> Hmm looks like your reached GRUB of the installed system, which is
> rather good.  I don’t see why it would hang here.
> 
> If you interrupt it and re-run “make check-system …”, does that get any
> further?

redid the same as the other day, but now on fresh VM based on 1.1.0.
Same problem, it makes no progress...

> Is there space left on /gnu and /tmp?

Yes

BTW, this is qemu in qemu, maybe that's the problem.
Maja Kądziołka July 4, 2020, 11:24 p.m. UTC | #5 
On Thu, Apr 16, 2020 at 11:36:54PM +0200, Vincent Legoll wrote:
> On 16/04/2020 18:22, Ludovic Courtès wrote:
> > Hi,
> > 
> > Vincent Legoll <vincent.legoll@gmail.com> skribis:
> > 
> > > Untested
> > 
> > Could you test it with “make check-system TESTS=encrypted-root-os”?
> > It takes time and disk space, but that’s a good way to make sure
> > cryptsetup is still able to decrypt our LUKS partitions.
> 
> OK, I'm trying it, but seems stuck.
> 
> Almost two hours passed since one of the tests has begun, and it
> looks like it does not make any progress.

Hi,

I ran the tests on bayfront and they complete successfully with the
updated cryptsetup, so I pushed your commit as
fe743ebb41f0936b378a185beb7c00adc4172d8c. Thanks!

Regards,
Jakub Kądziołka
diff mbox series

Patch

From 0a971f755222a98f301d9bce7c93ee46d03f4aac Mon Sep 17 00:00:00 2001
From: Vincent Legoll <vincent.legoll@gmail.com>
Date: Sat, 11 Apr 2020 19:11:26 +0200
Subject: [PATCH] gnu: cryptsetup: Update to 2.3.1.

* gnu/packages/cryptsetup.scm (cryptsetup): Update to 2.3.1.
---
 gnu/packages/cryptsetup.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/cryptsetup.scm b/gnu/packages/cryptsetup.scm
index 2a824d416e..79bd62c3cd 100644
--- a/gnu/packages/cryptsetup.scm
+++ b/gnu/packages/cryptsetup.scm
@@ -35,7 +35,7 @@ 
 (define-public cryptsetup
   (package
    (name "cryptsetup")
-   (version "2.2.2")
+   (version "2.3.1")
    (source (origin
             (method url-fetch)
             (uri (string-append "mirror://kernel.org/linux/utils/cryptsetup/v"
@@ -43,7 +43,7 @@ 
                                 "/cryptsetup-" version ".tar.xz"))
             (sha256
              (base32
-              "0ija889kfhg4n2fshpq9yh2b1jl2ipvd7sfafh08g75ba6ayrw1a"))))
+              "1lp7kwakm3ssp8ww1y33plvfmpas5krf14pdz91p1kx2b7as9awj"))))
    (build-system gnu-build-system)
    (arguments
     `(#:configure-flags
-- 
2.26.0