diff mbox series

[bug#40331] gnu: genimage: Update to 11.

Message ID CAEwRq=rDU9xoL4mRmnoTcAZVBXCa9ddO_P9dWG-BYxTnnaFGYQ@mail.gmail.com
State Accepted
Headers show
Series [bug#40331] gnu: genimage: Update to 11. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job

Commit Message

Vincent Legoll March 30, 2020, 6:34 p.m. UTC 
Hello,

here is an update to version 11 for genimage,
this is not the latest, as there is a test suite
failure for version 12 that I cannot understand.

The output for this test failure is in the attached
log file.

It looks like the created image uses 2 filesystem
block more than the expected, and so the bitmap
checksum changes, etc.

Danny, you close the issue:
https://github.com/pengutronix/genimage/issues/36
what was the outcome ?

I want to have your word on this before creating an
issue upstream, if we can solve it on our side.

So, until this test suite failure is solved we can still
get the version 11 in...

Comments

Danny Milosavljevic March 30, 2020, 8:47 p.m. UTC | #1 
On Mon, 30 Mar 2020 20:34:42 +0200
Vincent Legoll <vincent.legoll@gmail.com> wrote:

> Danny, you close the issue:
> https://github.com/pengutronix/genimage/issues/36
> what was the outcome ?
> 
> I want to have your word on this before creating an
> issue upstream, if we can solve it on our side.

I can't remember.  I *think* it was because one of our tools had xattr support
and another one of our tools had no xattr support, so the xattrs would get lost
and that would change the image or something.
Mathieu Othacehe April 8, 2020, 9:30 a.m. UTC | #2 
Hello Vincent,

> here is an update to version 11 for genimage,
> this is not the latest, as there is a test suite
> failure for version 12 that I cannot understand.

Till we find a solution for v12 test failures, I applied your update to
v11.

Thanks for this patch,

Mathieu
Mathieu Othacehe April 8, 2020, 9:32 a.m. UTC | #3 
And closing!

Mathieu
diff mbox series

Patch

From e64a6703fa1bbe79364df14848870fdc988745c9 Mon Sep 17 00:00:00 2001
From: Vincent Legoll <vincent.legoll@gmail.com>
Date: Fri, 27 Mar 2020 22:10:06 +0100
Subject: [PATCH] gnu: genimage: Update to 11.

* gnu/packages/genimage.scm (genimage): Update to 11.
[arguments]: add a new test dump file to the patched ones
because of missing /etc/passwd in build environment.
---
 gnu/packages/genimage.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/genimage.scm b/gnu/packages/genimage.scm
index fdf686f9d7..27f55a398a 100644
--- a/gnu/packages/genimage.scm
+++ b/gnu/packages/genimage.scm
@@ -41,7 +41,7 @@ 
 (define-public genimage
   (package
     (name "genimage")
-    (version "10")
+    (version "11")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -50,7 +50,7 @@ 
               (file-name (string-append name "-" version "-checkout"))
               (sha256
                (base32
-                "0had00p2why2l1fl14mq7nbhmmfbd3na4qnnpg36akdy05g67jbn"))))
+                "15jmh17lvm3jw9c92bjarly7iwhmnfl322d91mprfv10ppb9ip54"))))
     (build-system gnu-build-system)
     (arguments
      `(#:phases
@@ -149,6 +149,7 @@ 
              (substitute* '("test/ext2test.dump"
                             "test/ext3test.dump"
                             "test/ext4test.dump"
+                            "test/ext2test-percent.dump"
                             "test/mke2fs.dump")
               (("root") "unknown"))
              #t))
-- 
2.25.2