mbox

[bug#40383,0/5] Make some inputs native.

Message ID CAEwRq=pLfCWkn9VDnm3NK=1VGt_FyFBdvzYNCoXnOkbEvb+BnA@mail.gmail.com
Headers show

Message

Vincent Legoll April 1, 2020, 11:20 p.m. UTC
This is the reworked patchset sent yesterday
to guix-devel.

I hope I did not miss any review comment.

I dropped the cgit patch, reworded the commit
messages, added perl to the native-inputs of
darktable, guix linted all (graphviz still has some
lint problems, looks like they moved to gitlab, I'll
let that for another day)

Comments

Mathieu Othacehe April 2, 2020, 9:16 a.m. UTC | #1
Hello Vincent,

> I hope I did not miss any review comment.
>
> I dropped the cgit patch, reworded the commit
> messages, added perl to the native-inputs of
> darktable, guix linted all (graphviz still has some
> lint problems, looks like they moved to gitlab, I'll
> let that for another day)

Thanks for the updated serie. Some of these patches trigger a lot of
rebuilds. If you read this page[1], point 8, you will see that there's a
limit of 300 dependencies for pushing to master.

Graphviz has 1370 dependencies, which makes it a candidate for
core-updates branch that has been frozen recently. Maybe we can start a
'core-updates-next' branch. Marius, WDYT?

Mailutils has 125 dependencies, which is under the 300 limit so I'll
push it on master.

The other patches are fine :)

Thanks,

Mathieu

[1]: https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html,
Marius Bakke April 2, 2020, 4:01 p.m. UTC | #2
Mathieu Othacehe <m.othacehe@gmail.com> writes:

> Graphviz has 1370 dependencies, which makes it a candidate for
> core-updates branch that has been frozen recently. Maybe we can start a
> 'core-updates-next' branch. Marius, WDYT?

I've been meaning to rework the rebuild limits from the manual as a lot
has changed since that was written.  In particular I want to keep "mesa"
on 'staging', but that has crept to almost 2000 rebuilds!

Perhaps we need another tier in between staging and core-updates, or
just aim for slower staging cycles (as has been de facto a while..).

Anyway for now I think this can go to 'staging'.
Mathieu Othacehe April 2, 2020, 4:18 p.m. UTC | #3
> I've been meaning to rework the rebuild limits from the manual as a lot
> has changed since that was written.  In particular I want to keep "mesa"
> on 'staging', but that has crept to almost 2000 rebuilds!

Yup, an updated documentation section would be great!

>
> Perhaps we need another tier in between staging and core-updates, or
> just aim for slower staging cycles (as has been de facto a while..).
>
> Anyway for now I think this can go to 'staging'.

Ok, pushed on staging, thanks for your help.

Mathieu
Mathieu Othacehe April 2, 2020, 4:20 p.m. UTC | #4
I pushed the graphviz patch on the staging branch and the other ones on
master.

Thanks,

Mathieu
Vincent Legoll April 2, 2020, 5:44 p.m. UTC | #5
Mathieu,

I knew about the rebuild limit, and
told about it in the other thread:

> The graphviz patch may not be for master
> as it may force 2918 packages to be rebuilt.
> The other ones should be OK.

But it has been a long thread.

I should have restated it here, in the repost...

Thanks