| Message ID | CAEwRq=pKhf5YhFc6pG8=0o28HTMJ7f_uss4UHc11YkTKQtUc2A@mail.gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#40032] gnu: Add nvme-cli | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | fail | View Laminar job |
On Sun, Mar 15, 2020 at 06:36:54PM +0100, Vincent Legoll wrote: > From 4f794f64ca5438773fc9980bbf0cf5739144dc87 Mon Sep 17 00:00:00 2001 > From: Vincent Legoll <vincent.legoll@gmail.com> > Date: Thu, 12 Mar 2020 01:51:12 +0100 > Subject: [PATCH] gnu: Add nvme-cli > > * gnu/packages/linux.scm (nvme-cli): New variable. Thanks! Pushed as 323841bda4e5b8f9b30626ab768aaf711ee6aabf with the following changes that I somehow forgot to mention. There was no need to make you revise the patch again... > + #:phases (modify-phases %standard-phases > + (delete 'configure) I added a comment about why the phase is deleted. > + (replace 'install > + (lambda _ > + (zero? (system* "make" "install-spec" "PREFIX=" > + (string-append "DESTDIR=" %output)))))) I replaced (zero? (system* ...)) with (invoke ...), which raises exceptions on failure rather than returning a boolean #f. This is "the Guix way" for a while now: https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00278.html > + (description "Utility to provide standards compliant tooling for NVM-Express > +drives. It was made specifically for Linux as it relies on the IOCTLs defined And I made this first sentence into a complete sentence.
Thanks for all the fixes, I'll try to get better at doing that myself... On Sun, Mar 15, 2020 at 6:57 PM Leo Famulari <leo@famulari.name> wrote: > > On Sun, Mar 15, 2020 at 06:36:54PM +0100, Vincent Legoll wrote: > > From 4f794f64ca5438773fc9980bbf0cf5739144dc87 Mon Sep 17 00:00:00 2001 > > From: Vincent Legoll <vincent.legoll@gmail.com> > > Date: Thu, 12 Mar 2020 01:51:12 +0100 > > Subject: [PATCH] gnu: Add nvme-cli > > > > * gnu/packages/linux.scm (nvme-cli): New variable. > > Thanks! Pushed as 323841bda4e5b8f9b30626ab768aaf711ee6aabf with the > following changes that I somehow forgot to mention. There was no need to > make you revise the patch again... > > > + #:phases (modify-phases %standard-phases > > + (delete 'configure) > > I added a comment about why the phase is deleted. > > > + (replace 'install > > + (lambda _ > > + (zero? (system* "make" "install-spec" "PREFIX=" > > + (string-append "DESTDIR=" %output)))))) > > I replaced (zero? (system* ...)) with (invoke ...), which raises > exceptions on failure rather than returning a boolean #f. This is "the > Guix way" for a while now: > > https://lists.gnu.org/archive/html/guix-devel/2017-12/msg00278.html > > > + (description "Utility to provide standards compliant tooling for NVM-Express > > +drives. It was made specifically for Linux as it relies on the IOCTLs defined > > And I made this first sentence into a complete sentence.
On Sun, Mar 15, 2020 at 07:10:18PM +0100, Vincent Legoll wrote:
> Thanks for all the fixes, I'll try to get better at doing that myself...
No worries! We're glad to have your patches :)
From 4f794f64ca5438773fc9980bbf0cf5739144dc87 Mon Sep 17 00:00:00 2001 From: Vincent Legoll <vincent.legoll@gmail.com> Date: Thu, 12 Mar 2020 01:51:12 +0100 Subject: [PATCH] gnu: Add nvme-cli * gnu/packages/linux.scm (nvme-cli): New variable. --- gnu/packages/linux.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 688d9eefaf..e8cc01d288 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -3577,6 +3577,36 @@ IDE driver subsystem. Many external USB drive enclosures with SCSI-ATA Command Translation (@dfn{SAT}) are also supported.") (license (license:non-copyleft "file://LICENSE.TXT")))) +(define-public nvme-cli + (package + (name "nvme-cli") + (version "1.10.1") + (home-page "https://github.com/linux-nvme/nvme-cli") + (source (origin + (method git-fetch) + (uri (git-reference + (url home-page) + (commit (string-append "v" version)))) + (sha256 + (base32 "12wp2wxmsw2v8m9bhvwvdbhdgx1md8iilhbl19sfzz2araiwi2x8")) + (file-name (git-file-name name version)))) + (build-system gnu-build-system) + (arguments + `(#:make-flags (list "CC=gcc") + #:phases (modify-phases %standard-phases + (delete 'configure) + (replace 'install + (lambda _ + (zero? (system* "make" "install-spec" "PREFIX=" + (string-append "DESTDIR=" %output)))))) + #:tests? #f)) ; The tests require sysfs, which is not accessible from + ; the build environment + (synopsis "NVM-Express user space tooling for Linux") + (description "Utility to provide standards compliant tooling for NVM-Express +drives. It was made specifically for Linux as it relies on the IOCTLs defined +by the mainline kernel driver.") + (license license:gpl2+))) + (define-public rfkill (package (name "rfkill") -- 2.25.1