diff mbox series

[bug#61906] Revised patch that respects changelog format

Message ID CADBZEVkJQars83HDvWpHxy4HCTipQJu+KqDckALUGJr5GkMn7Q@mail.gmail.com
State New
Headers show
Series [bug#61906] Revised patch that respects changelog format | expand

Commit Message

Sarthak Shah March 8, 2023, 6:19 p.m. UTC 
* gnu/packages/pumio.scm (pumpa): Replace pumpa origin
---
 gnu/packages/pumpio.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 7dc190f83ed29ca7e556700de13a3101e73ec745
--

Comments

Simon Tournier March 9, 2023, 10:02 a.m. UTC | #1 
Hi,

Please see v3 for nitpicking. :-)  But since it is a more than trivial
patch, the only interesting part is the nitpicking part.


1. Since the Subject line is the Commit headline, it must also respect
   the format.  When modifying a package, it is:

      gnu: packag-name: One line summarizing the change.

On Wed, 08 Mar 2023 at 23:49, Sarthak Shah <shahsarthakw@gmail.com> wrote:

> * gnu/packages/pumio.scm (pumpa): Replace pumpa origin

2. The ChangeLog format ends with a period.          --^


Cheers,
simon
Sarthak Shah March 9, 2023, 11:14 a.m. UTC | #2 
Got it, thank you for your patience.
I guess it won't be necessary as you have already sent a corrected patch,
but should I resend my commit with the required fixes?

On Thu, Mar 9, 2023 at 3:32 PM Simon Tournier <zimon.toutoune@gmail.com>
wrote:

> Hi,
>
> Please see v3 for nitpicking. :-)  But since it is a more than trivial
> patch, the only interesting part is the nitpicking part.
>
>
> 1. Since the Subject line is the Commit headline, it must also respect
>    the format.  When modifying a package, it is:
>
>       gnu: packag-name: One line summarizing the change.
>
> On Wed, 08 Mar 2023 at 23:49, Sarthak Shah <shahsarthakw@gmail.com> wrote:
>
> > * gnu/packages/pumio.scm (pumpa): Replace pumpa origin
>
> 2. The ChangeLog format ends with a period.          --^
>
>
> Cheers,
> simon
>
diff mbox series

Patch

diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index 2f4dd359d1..0c27041f5b 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -35,7 +35,7 @@  (define-public pumpa
     (source (origin
               (method git-fetch) ; no source tarballs
               (uri (git-reference
-                    (url "git://pumpa.branchable.com/")
+                    (url "https://source.pumpa.branchable.com/")
                     (commit (string-append "v" version))))
               (sha256
                (base32