diff mbox series

[bug#37125] Add emacs-ample-regexps.

Message ID CAAc=MEzbft-4hW4_8JNafv+9+2oQMDSqvehXyOyR2g85Z_QadQ@mail.gmail.com
State Accepted
Headers show
Series [bug#37125] Add emacs-ample-regexps. | expand

Commit Message

Brian Leung Aug. 20, 2019, 10:16 p.m. UTC 
See attached.

Comments

Oleg Pykhalov Aug. 21, 2019, 5:56 a.m. UTC | #1 
Hello Brian,

Brian Leung <bkleung89@gmail.com> writes:

> See attached.
> From ec5fae25629ae80cb929c231d71e772dc7ddda20 Mon Sep 17 00:00:00 2001
> From: Brian Leung <bkleung89@gmail.com>
> Date: Wed, 21 Aug 2019 00:15:18 +0200
> Subject: [PATCH] gnu: Add emacs-ample-regexps.
>
> * gnu/packages/emacs-xyz.scm (emacs-ample-regexps): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 40 ++++++++++++++++++++++++++++++--------
>  1 file changed, 32 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index a51545c3b3..a0f1a57371 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm

[…]

Could you take a look on running a test suite, please?

Also patch contains a redundant change of another package recipe,
which doesn't belong to current patch adding a package.

Thanks,
Oleg.
Oleg Pykhalov Aug. 23, 2019, 4:24 a.m. UTC | #2 
Hello Brian,

No worries, thank you.  Pushed to master as
d78bc23411b1351ff9495a511c22b27d17f9226f.

Please, don't forget to CC *@debbugs.gnu.org ;-)

Regards,
Oleg.
diff mbox series

Patch

From ec5fae25629ae80cb929c231d71e772dc7ddda20 Mon Sep 17 00:00:00 2001
From: Brian Leung <bkleung89@gmail.com>
Date: Wed, 21 Aug 2019 00:15:18 +0200
Subject: [PATCH] gnu: Add emacs-ample-regexps.

* gnu/packages/emacs-xyz.scm (emacs-ample-regexps): New variable.
---
 gnu/packages/emacs-xyz.scm | 40 ++++++++++++++++++++++++++++++--------
 1 file changed, 32 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a51545c3b3..a0f1a57371 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -904,20 +904,44 @@  skip set strings, which are arguments to @code{skip-chars-forward} and
 @code{skip-chars-backward}.")
     (license license:gpl3+)))
 
+(define-public emacs-ample-regexps
+  (let ((commit "cbe91e148cac1ee8e223874dc956ed4cf607f046")
+        (revision "1"))
+    (package
+      (name "emacs-ample-regexps")
+      (version (git-version "0.1" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/immerrr/ample-regexps.el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "1mm4icrwx4mscp7kbbmlc34995r164dhrfczn5ybkyxjzzf76jn1"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/immerrr/ample-regexps.el")
+      (synopsis "Compose and reuse Emacs regexps")
+      (description
+       "This package allows common parts of regexps to be easily picked out
+and reused.")
+      (license license:gpl3+))))
+
 (define-public emacs-reformatter
   (package
     (name "emacs-reformatter")
     (version "0.4")
     (source
      (origin
-      (method git-fetch)
-      (uri (git-reference
-            (url "https://github.com/purcell/reformatter.el.git")
-            (commit version)))
-      (file-name (git-file-name name version))
-      (sha256
-       (base32
-        "0hhy6x1bkwlhdlarsgm06g3am4yh02yqv8qs34szpzgy53x84qah"))))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/purcell/reformatter.el.git")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0hhy6x1bkwlhdlarsgm06g3am4yh02yqv8qs34szpzgy53x84qah"))))
     (build-system emacs-build-system)
     (home-page "https://github.com/purcell/reformatter.el")
     (synopsis "Define commands which run reformatters on the current buffer")
-- 
2.23.0