diff mbox series

[bug#36381] Add fzf.

Message ID CAAc=MEwe_567YQYoKd+isH-DtnzZTCdFHvoX_=gnURyMk6K=jA@mail.gmail.com
State Accepted
Headers show
Series [bug#36381] Add fzf. | expand

Commit Message

Brian Leung June 25, 2019, 7:01 p.m. UTC 
See attached.

Comments

Brian Leung July 12, 2019, 12:37 a.m. UTC | #1 
Friendly ping.

On Tue, Jun 25, 2019 at 9:01 PM Brian Leung <bkleung89@gmail.com> wrote:

> See attached.
>
Brian Leung July 26, 2019, 5:18 a.m. UTC | #2 
Friendly ping.

On Fri, Jul 12, 2019 at 2:37 AM Brian Leung <bkleung89@gmail.com> wrote:

> Friendly ping.
>
> On Tue, Jun 25, 2019 at 9:01 PM Brian Leung <bkleung89@gmail.com> wrote:
>
>> See attached.
>>
>
Danny Milosavljevic July 29, 2019, 2:58 p.m. UTC | #3 
Hi,

pushed to guix master, except for patches 11 and 12.
Where those intentional?
diff mbox series

Patch

From d99857f676b5ccecc807ac708f6c797fe1c8281d Mon Sep 17 00:00:00 2001
From: Brian Leung <bkleung89@gmail.com>
Date: Tue, 25 Jun 2019 20:50:54 +0200
Subject: [PATCH 12/12] gnu: python-scikit-learn: Make gzip timestamps
 writable.

* gnu/packages/machine-learning.scm (python-scikit-learn): Make gzip timestamps writable.
---
 gnu/packages/machine-learning.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm
index 2dc7dc81ef..dd5ee1e9ee 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -821,8 +821,14 @@  computing environments.")
              (setenv "HOME" "/tmp")
 
              (invoke "pytest" "sklearn" "-m" "not network")))
-         ;; FIXME: This fails with permission denied
-         (delete 'reset-gzip-timestamps))))
+         (add-before 'reset-gzip-timestamps 'make-files-writable
+           (lambda* (#:key outputs #:allow-other-keys)
+             ;; Make sure .gz files are writable so that the
+             ;; 'reset-gzip-timestamps' phase can do its work.
+             (let ((out (assoc-ref outputs "out")))
+               (for-each make-file-writable
+                         (find-files out "\\.gz$"))
+               #t))))))
     (inputs
      `(("openblas" ,openblas)))
     (native-inputs
-- 
2.22.0