From patchwork Tue Dec 29 22:54:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rovanion Luckey X-Patchwork-Id: 26110 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id C805527BC05; Tue, 29 Dec 2020 22:55:09 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 3A53427BC04 for ; Tue, 29 Dec 2020 22:55:09 +0000 (GMT) Received: from localhost ([::1]:36290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kuNtU-0006tK-ED for patchwork@mira.cbaines.net; Tue, 29 Dec 2020 17:55:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuNtO-0006t3-Dc for guix-patches@gnu.org; Tue, 29 Dec 2020 17:55:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:57168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuNtO-0001kr-6D for guix-patches@gnu.org; Tue, 29 Dec 2020 17:55:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kuNtO-0007hE-2B for guix-patches@gnu.org; Tue, 29 Dec 2020 17:55:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45542] import: pypi: Clearify docstring of parse-requires.txt Resent-From: Rovanion Luckey Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Dec 2020 22:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45542 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 45542@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160928248729551 (code B ref -1); Tue, 29 Dec 2020 22:55:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Dec 2020 22:54:47 +0000 Received: from localhost ([127.0.0.1]:40481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuNt9-0007gZ-Db for submit@debbugs.gnu.org; Tue, 29 Dec 2020 17:54:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:58672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kuNt6-0007gN-9K for submit@debbugs.gnu.org; Tue, 29 Dec 2020 17:54:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kuNt5-0006sG-UI for guix-patches@gnu.org; Tue, 29 Dec 2020 17:54:44 -0500 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]:33494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kuNt2-0001d5-2y for guix-patches@gnu.org; Tue, 29 Dec 2020 17:54:43 -0500 Received: by mail-il1-x133.google.com with SMTP id n9so13446564ili.0 for ; Tue, 29 Dec 2020 14:54:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=quj8x94DMmu0L1t/g0qYIZak8GE9YcQqlmaRsHCetRA=; b=UxSAyKZxZgNkXSWiVggBXHPw4CPADm8txj4a1J30VagEoYsvr0cYqGER3TlwNGRRGH wzR9Z2Mwy/6yVcMMK3BfijqpW0gFvCaJ0Sf8tBQgdWSp9Rz4pX+wcjFlNAxXIbkq8UiF DSINvbDl5UwpvqluhgQKhcwVpp0AybAAtL4DaFkDse3PlzwMV4mAy2yVft3lTR1zegDK KFiOJJI6IvOgtzyMhAyfTfarhRx4Lfg/lr4ys+ebqkpd+UKeqT29JSpep1QBNTPKV98X gAE6YYZFXPYZ2YbwHpKXNxujmWmQICiUkfw7wA3R68xynQWOm/2RY84uzyzhbLiea++b cBVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=quj8x94DMmu0L1t/g0qYIZak8GE9YcQqlmaRsHCetRA=; b=FGCXmUbHCLiHWejr1sQebHggYD4Swe5FqCYQp5ZeYm4+6NMPVnjxyGkc1EpTsOM0St adnll8v/o1w7weO+LUJMzRLGhFjdKQix2MiRSyuWNX2BE2qcGPiAr0pkm91JQLNs9eWm qM2mcv91Qs4be7tCS7Gr9gGodxdXSLfwi1am3UohsCAzJS/5IRDiXN/cqE1nbwXhpCAH RurwxUQQSvmOz4rh5VJd4dMqCVge1mb3GIUa85gfirat23uk4mPT7kNRCURh3TFAlGLs g8xgrJitGiosQMvuWTYDF5TNxgXq9zPLV5wnqMbpEIovOI7iLq6tLd9Ce/pHShwKBylp idzw== X-Gm-Message-State: AOAM531arpgtH4J1fvvATVYEpRwSJLQtd5zC2wCxpIIQ45WuZizLqI6S MZT9N8HqwrtCk+pQ71/eZ2M3Iu0QD9OrrQI6QPsQF3Li X-Google-Smtp-Source: ABdhPJxV8icCMUBmsV86S0zeKq8J8r+A9Zx0+ULLSijaA8Cst1+khwlZIJ0w/ZJFVsuqDol1KlrHmxmuum2SgwO7HM4= X-Received: by 2002:a92:b60a:: with SMTP id s10mr48627950ili.135.1609282477898; Tue, 29 Dec 2020 14:54:37 -0800 (PST) MIME-Version: 1.0 From: Rovanion Luckey Date: Tue, 29 Dec 2020 23:54:11 +0100 Message-ID: Received-SPF: pass client-ip=2607:f8b0:4864:20::133; envelope-from=rovanion.luckey@gmail.com; helo=mail-il1-x133.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches When mucking about the codebase trying to figure out if it would be possible to automatically import a Python project using Guix preexisting functions I found a docstring I thought could be more explicit than it was. From 338ac21c68e757d94b8375cb42345a82488f1708 Mon Sep 17 00:00:00 2001 From: Rovanion Luckey Date: Thu, 26 Nov 2020 20:59:19 +0100 Subject: [PATCH 1/2] import: pypi: Clearify docstring of parse-requires.txt --- guix/import/pypi.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm index bf4dc50138..6731d50891 100644 --- a/guix/import/pypi.scm +++ b/guix/import/pypi.scm @@ -229,8 +229,8 @@ the input field." '("test" "dev"))) (define (parse-requires.txt requires.txt) - "Given REQUIRES.TXT, a Setuptools requires.txt file, return a list of lists -of requirements. + "Given REQUIRES.TXT, a path to a Setuptools requires.txt file, return a list +of lists of requirements. The first list contains the required dependencies while the second the optional test dependencies. Note that currently, optional, non-test -- 2.29.2