From patchwork Mon Sep 12 10:06:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kristian Lein-Mathisen X-Patchwork-Id: 42520 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2456927BBEA; Mon, 12 Sep 2022 11:12:17 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 9A61127BBE9 for ; Mon, 12 Sep 2022 11:12:16 +0100 (BST) Received: from localhost ([::1]:35946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oXgQJ-0001iq-Op for patchwork@mira.cbaines.net; Mon, 12 Sep 2022 06:12:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXgLH-0004PF-AA for guix-patches@gnu.org; Mon, 12 Sep 2022 06:07:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXgLG-0004kt-Va for guix-patches@gnu.org; Mon, 12 Sep 2022 06:07:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oXgLG-0004f2-Iw for guix-patches@gnu.org; Mon, 12 Sep 2022 06:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57746] gnu: solvespace: Fix dependency Resent-From: Kristian Lein-Mathisen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 12 Sep 2022 10:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57746 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 57746@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166297720317890 (code B ref -1); Mon, 12 Sep 2022 10:07:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Sep 2022 10:06:43 +0000 Received: from localhost ([127.0.0.1]:44146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXgKw-0004eT-Jm for submit@debbugs.gnu.org; Mon, 12 Sep 2022 06:06:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:46702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXgKu-0004eL-86 for submit@debbugs.gnu.org; Mon, 12 Sep 2022 06:06:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXgKu-0003qE-0R for guix-patches@gnu.org; Mon, 12 Sep 2022 06:06:40 -0400 Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]:41805) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXgKs-0004iy-9S for guix-patches@gnu.org; Mon, 12 Sep 2022 06:06:39 -0400 Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-12803ac8113so21968095fac.8 for ; Mon, 12 Sep 2022 03:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date; bh=FUCb5hk+SeZiDS8RrCxP2RbKv03z7FovtSBqIAn5Kws=; b=CSauH3jswWeHsC1iSIFcOU7FH35AjWYiQA5QEVEtFraDUx4Jw0dTyjI+YluqBzZz49 1A9ZUAGkGQMf3l3hyP2ovCT8ZMPUOO8msqWsQPeCgbiHKL+0Oy6gd4jnlYw/uwzuSZGZ RX6rbeZ/D9v960wKbUOJWK8PipmBu36Pi5o4Bta0ZmOKveWxDApenB6TiIMjOa05RqB5 tWPHLhpJfuBehQy5IV9QS8SNqpRK1lRphzK6iCVNjHrJtLXJr//cN+/nMRT8tUPOwO1h 1mxsqIG+vrDvlNqxMcIJ79ZL2AEeWeSM+t9Mq6l0bjOb/pk07yGcb9pNIuGlW91qV+qP lLmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date; bh=FUCb5hk+SeZiDS8RrCxP2RbKv03z7FovtSBqIAn5Kws=; b=yqyyZDlICNM71dL+ne7uFFD9ywbrKgtLfCrFoyQ7N5Hz9xbwrtBbTzS7Q18NBzcKNC G/aTRm449APrYBMO7wziSZg7NL36GJclrdHxLn+qiBWEOy+A5QeuUXFOzb4Q+Oy/j5tu ujHq5HRtSWgaSBCFV07omsxzLdTGyoxed1mZSYDyQvDY3wbQL6NcYVOMYkx0ZCNXMCpv ZSWlkwzPHGrTxPivsDNFvTctUwBUvxyA7RYiBDKWPSy1E3nLb4kzU6Vp+DHqdqYBNMKB DleZoe20aSmdLXtwI0QyOQzZwuIo+mXNO3pvdkyooQknl2rUbOseeFiq4vjZYexkQblh wjVA== X-Gm-Message-State: ACgBeo2ipvWhI6VogdwF0QDTMas6dKjSMFkj/oB/Og1hok/JLD/ilYSl ixcmQEgaPBw2UiD+ryD2MspIHj9bGl9gIK6NDVcHrsR60GY= X-Google-Smtp-Source: AA6agR7RV1nk7mDsDVExTQ8UFlgxGmbBYJ0XgR2J/1aDOnBt2hlxXA3EZ579BPw6MuwpjMJNUNmmYcA+1/FdJI0AEEw= X-Received: by 2002:a05:6870:e2d1:b0:125:f220:750e with SMTP id w17-20020a056870e2d100b00125f220750emr10935790oad.74.1662977196532; Mon, 12 Sep 2022 03:06:36 -0700 (PDT) MIME-Version: 1.0 From: Kristian Lein-Mathisen Date: Mon, 12 Sep 2022 12:06:25 +0200 Message-ID: Received-SPF: pass client-ip=2001:4860:4864:20::2f; envelope-from=kristianlein@gmail.com; helo=mail-oa1-x2f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi, A bug has come up in SolveSpace where doing File=>Open makes it crash. I've traced it down to a missing "FileChooser" in GTK. I found a reference to FileChooser in other packages, like utox, in a modify-phase. Copying that removes the problem for SolveSpace. I don't fully understand what I'm doing here but I'm hoping this is still the right solution. Thank you, K. From 8ffd67f3c5244c1a1cfb888ecaf520a3bbc7d079 Mon Sep 17 00:00:00 2001 From: Kristian Lein-Mathisen Date: Mon, 12 Sep 2022 11:51:02 +0200 Subject: [PATCH] gnu: solvespace: Fix dependency. By opening File => Open in the menu, SolveSpace crashes with: (solvespace:3891): GLib-GIO-ERROR **: 11:52:37.518: Settings schema 'org.gtk.Settings.FileChooser' is not installed fish: Job 1, 'solvespace' terminated by signal SIGTRAP (Trace or breakpoint trap) This patch should fix that, showing the GTK FileChooser dialog instead. Solution was taken from gnu/packages/messaging.scm (utox). * gnu/packages/engineering.scm (solvespace): Fix dependency. --- gnu/packages/engineering.scm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm index a8b9f1e786..673ea8023b 100644 --- a/gnu/packages/engineering.scm +++ b/gnu/packages/engineering.scm @@ -2952,7 +2952,15 @@ (define-public solvespace (("message\\(STATUS \"Using in-tree mimalloc\"\\)") "message(STATUS \"Using guix packaged mimalloc\")") (("add_subdirectory\\(extlib/mimalloc EXCLUDE_FROM_ALL\\)") - "find_package(mimalloc REQUIRED)"))))))) + "find_package(mimalloc REQUIRED)")))) + (add-after 'install 'wrap-program + (lambda* (#:key inputs outputs #:allow-other-keys) + (wrap-program (string-append (assoc-ref outputs "out") + "/bin/solvespace") + ;; For GtkFileChooserDialog. + `("GSETTINGS_SCHEMA_DIR" = + (,(string-append (assoc-ref inputs "gtk+") + "/share/glib-2.0/schemas"))))))))) (inputs (list cairo eigen freetype base-commit: e3ed1d09f9d490eff6becd6e9cb85a4d36c48e85 -- 2.37.3