| Message ID | CA+TvSRigMNYAjB74v2=YnVhELzqNDFA8uojK3zZ06SRb+JWY+Q@mail.gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#41688] Add rsyslog | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/applying patch | fail | View Laminar job |
Hi, I’ve followed Ludo’s suggestions for the remaining package definitions and pushed the result to the “master” branch. Among the changes: - fixed and clarified licenses - removed per-module outputs - removed default configure flags and added a comment about enabling optional features - enabled tests - removed “dev” output - used new input style Now I guess we’ll need an rsyslog service :) Thank you, Katherine, for the patches and your patience!
Ricardo Wurmus <rekado@elephly.net> writes: > I’ve followed Ludo’s suggestions for the remaining package definitions > and pushed the result to the “master” branch. Thank you so much, Ricardo! It is my fault for letting this sit, but I think we should unbundle the outputs once more -- even if they must become separate packages. As you know, rsyslog is meant to forward (egress) and receive (ingress) syslog logs, and it does so through these plug-ins. For ingress, I don't think this package is necessarily a problem, but systems that want to forward logs may have very limited resources (e.g. I have a wifi repeater that forwards logs). I didn't want to require things like PostgreSQL and MySQL, dependencies required by ingress, on egress. A secondary concern is that a package like rsyslog becomes quite sticky since there are lots and lots of modules, and I imagine the Guix closure becomes quite big. > Among the changes: > > - fixed and clarified licenses > - removed per-module outputs > - removed default configure flags and added a comment about enabling > optional features > - enabled tests > - removed “dev” output > - used new input style > > Now I guess we’ll need an rsyslog service :) I'm working[1] on it! Although it is frustrating at how little time I have to dedicate to things like this :( > Thank you, Katherine, for the patches and your patience! Likewise, thank you for your contributions and getting this landed. Cheers! [1] - https://github.com/kat-co/guix-channels/blob/upstream-staging/upstream/services/rsyslog.scm
Katherine Cox-Buday <cox.katherine.e@gmail.com> writes: > I think we should unbundle the outputs once more -- even if they must > become separate packages. If we can build the plugins separately (and arrange for rsyslog to find them via some search path) I’d be happy to see them moved to their own packages. Having them as separate outputs would only help a little as you’d still need to have *all* the inputs ready to build the thing, even if you just want to use one of the many plugins. >> Now I guess we’ll need an rsyslog service :) > > I'm working[1] on it! Although it is frustrating at how little time I have to dedicate to things like this :( Excellent, I’m looking forward to a service! Perhaps we could also use the existing syslog service with it if that service allows us to pass a plain configuration file. It should already let us swap out the syslog package.
From 9e0c24cc6e0666581b11b45f831ab49486adbdf8 Mon Sep 17 00:00:00 2001 From: Katherine Cox-Buday <cox.katherine.e@gmail.com> Date: Tue, 2 Jun 2020 15:29:08 -0500 Subject: [PATCH 3/5] gnu: Add liblogging. * gnu/packages/c.scm (liblogging): New variable. --- gnu/packages/c.scm | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/gnu/packages/c.scm b/gnu/packages/c.scm index 307d8ca182..98c939e76f 100644 --- a/gnu/packages/c.scm +++ b/gnu/packages/c.scm @@ -42,6 +42,7 @@ #:use-module (gnu packages multiprecision) #:use-module (gnu packages pcre) #:use-module (gnu packages python) + #:use-module (gnu packages python-xyz) #:use-module (gnu packages autotools) #:use-module (gnu packages gettext) #:use-module (gnu packages pkg-config) @@ -405,3 +406,39 @@ be very fast in processing.") (license:non-copyleft "https://github.com/rsyslog/libfastjson/blob/master/COPYING" "It is a MIT license.")))) + +(define-public liblogging + (package + (name "liblogging") + (version "1.0.6") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/rsyslog/liblogging.git") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1l32m0y65svf5vxsgw935jnqs6842rcqr56dmzwqvr00yfrjhjkp")))) + (build-system gnu-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + ;; autogen.sh calls configure at the end of the script. + (replace 'bootstrap + (lambda _ (invoke "autoreconf" "-vfi")))))) + (native-inputs + `(("autoconf" ,autoconf) + ("automake" ,automake) + ("pkg-config" ,pkg-config) + ("libtool" ,libtool) + ;; For rst2man.py + ("python-docutils" ,python-docutils))) + (home-page "https://github.com/rsyslog/liblogging") + (synopsis + "Easy to use and lightweight signal-safe logging library") + (description + "Liblogging is an easy to use library for logging. It offers an enhanced +replacement for the syslog() call, but retains its ease of use.") + (license license:bsd-2))) -- 2.26.2