mbox

[bug#43913,0/4] gnu: Add aws-sdk-cpp.

Message ID CA+3U0Zmi2puFkuccZ30OgA8VTbN7wvgyVT8wNVpe1vAB9R6YZQ@mail.gmail.com
Headers show

Message

Greg Hogan Oct. 10, 2020, 6:13 p.m. UTC 
2       0       gnu/local.mk
72      0       gnu/packages/c.scm
38      0       gnu/packages/cpp.scm
13      0
gnu/packages/patches/aws-c-event-stream-read-cmake-prefix-path.patch
13      0
gnu/packages/patches/aws-checksums-read-cmake-prefix-path.patch

Comments

Ludovic Courtès Oct. 23, 2020, 1:34 p.m. UTC | #1 
Hi Greg,

Overall the patches LGTM.  Two minor issues:

  1. They were mangled on the way.  Could you send them as attachments
     or with ‘git send-email’ to this address?

  2. Could you improve descriptions?  In particular, please write full
     sentences, explain acronyms, and expound a bit as you see fit:

     https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

Could you send updated patches?

Thanks, and sorry for the delay!

Ludo’.
Greg Hogan Dec. 9, 2020, 10:35 p.m. UTC | #2 
Sending as attachments with improved descriptions; also, updated versions.

On Fri, Oct 23, 2020 at 9:34 AM Ludovic Courtès <ludo@gnu.org> wrote:

> Hi Greg,
>
> Overall the patches LGTM.  Two minor issues:
>
>   1. They were mangled on the way.  Could you send them as attachments
>      or with ‘git send-email’ to this address?
>
>   2. Could you improve descriptions?  In particular, please write full
>      sentences, explain acronyms, and expound a bit as you see fit:
>
>
> https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html
>
> Could you send updated patches?
>
> Thanks, and sorry for the delay!
>
> Ludo’.
>